[INFO] fetching crate vm-memory 0.14.1... [INFO] checking vm-memory-0.14.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vm-memory 0.14.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate vm-memory 0.14.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/.cargo/config [INFO] started tweaking crates.io crate vm-memory 0.14.1 [INFO] finished tweaking crates.io crate vm-memory 0.14.1 [INFO] tweaked toml for crates.io crate vm-memory 0.14.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 77 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4c6b721f6953f4012473a4916951b1d567016a78cd58c3b53f4153ba2a0b228f [INFO] running `Command { std: "docker" "start" "-a" "4c6b721f6953f4012473a4916951b1d567016a78cd58c3b53f4153ba2a0b228f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4c6b721f6953f4012473a4916951b1d567016a78cd58c3b53f4153ba2a0b228f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c6b721f6953f4012473a4916951b1d567016a78cd58c3b53f4153ba2a0b228f", kill_on_drop: false }` [INFO] [stdout] 4c6b721f6953f4012473a4916951b1d567016a78cd58c3b53f4153ba2a0b228f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2c26a5563ff803ed5f5baba1c4a51d88c684ae3b2cacc6dd813484d863492320 [INFO] running `Command { std: "docker" "start" "-a" "2c26a5563ff803ed5f5baba1c4a51d88c684ae3b2cacc6dd813484d863492320", kill_on_drop: false }` [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking num-traits v0.2.19 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking vmm-sys-util v0.12.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking vm-memory v0.14.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bytes.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 270 | fn read_obj(&self, addr: A) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | self.read_slice(result.as_mut_slice(), addr).map(|_| result) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guest_memory.rs:140:30 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn new(file: File, start: u64) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | FileOffset::from_arc(Arc::new(file), start) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guest_memory.rs:575:9 [INFO] [stdout] | [INFO] [stdout] 570 | fn map_and_fold(&self, init: T, mapf: F, foldf: G) -> T [INFO] [stdout] | ------- ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 575 | self.iter().enumerate().map(mapf).fold(init, foldf) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guest_memory.rs:729:13 [INFO] [stdout] | [INFO] [stdout] 727 | let mut vslice = region.get_slice(caddr, len)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 728 | [INFO] [stdout] 729 | src.read_volatile(&mut vslice) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/volatile_memory.rs:480:12 [INFO] [stdout] | [INFO] [stdout] 475 | let end = self.offset(mid)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 476 | let start = [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 480 | Ok((start, end)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/volatile_memory.rs:992:22 [INFO] [stdout] | [INFO] [stdout] 992 | .map(|r| r.load(order).into()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/volatile_memory.rs:1008:13 [INFO] [stdout] | [INFO] [stdout] 1008 | / unsafe { [INFO] [stdout] 1009 | | VolatileSlice::with_bitmap( [INFO] [stdout] 1010 | | self.addr.add(offset), [INFO] [stdout] 1011 | | count, [INFO] [stdout] ... | [INFO] [stdout] 1014 | | ) [INFO] [stdout] 1015 | | }, [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vm-memory` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "2c26a5563ff803ed5f5baba1c4a51d88c684ae3b2cacc6dd813484d863492320", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c26a5563ff803ed5f5baba1c4a51d88c684ae3b2cacc6dd813484d863492320", kill_on_drop: false }` [INFO] [stdout] 2c26a5563ff803ed5f5baba1c4a51d88c684ae3b2cacc6dd813484d863492320