[INFO] fetching crate vls-protocol-signer 0.12.0... [INFO] checking vls-protocol-signer-0.12.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vls-protocol-signer 0.12.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate vls-protocol-signer 0.12.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vls-protocol-signer 0.12.0 [INFO] finished tweaking crates.io crate vls-protocol-signer 0.12.0 [INFO] tweaked toml for crates.io crate vls-protocol-signer 0.12.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 128 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding ahash v0.3.8 (latest: v0.8.11) [INFO] [stderr] Adding bech32 v0.9.1 (latest: v0.11.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitcoin v0.29.2 (latest: v0.32.2) [INFO] [stderr] Adding bitcoin-push-decoder v0.2.2 (latest: v0.3.0) [INFO] [stderr] Adding bitcoin_hashes v0.11.0 (latest: v0.14.0) [INFO] [stderr] Adding bitcoinconsensus v0.20.2-0.5.0 (latest: v0.106.0+26.0) [INFO] [stderr] Adding core2 v0.3.3 (latest: v0.4.0) [INFO] [stderr] Adding env_logger v0.9.3 (latest: v0.11.5) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.8.2 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding lightning v0.0.118 (latest: v0.0.123) [INFO] [stderr] Adding lightning-invoice v0.26.0 (latest: v0.31.0) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding secp256k1 v0.24.3 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1-sys v0.6.1 (latest: v0.10.0) [INFO] [stderr] Adding serde_bolt v0.3.5 (latest: v0.4.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding txoo v0.7.1 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `bit-vec` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `log` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 581e43a5be7b70f320848e9fd0be74a17b02901e0ae4174b0d2e2b28439e02aa [INFO] running `Command { std: "docker" "start" "-a" "581e43a5be7b70f320848e9fd0be74a17b02901e0ae4174b0d2e2b28439e02aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "581e43a5be7b70f320848e9fd0be74a17b02901e0ae4174b0d2e2b28439e02aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "581e43a5be7b70f320848e9fd0be74a17b02901e0ae4174b0d2e2b28439e02aa", kill_on_drop: false }` [INFO] [stdout] 581e43a5be7b70f320848e9fd0be74a17b02901e0ae4174b0d2e2b28439e02aa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 49d606a59e8a4b5e071ac0afdcac59b86f2617f349bbb14fa7ff0d2fb9edeba1 [INFO] running `Command { std: "docker" "start" "-a" "49d606a59e8a4b5e071ac0afdcac59b86f2617f349bbb14fa7ff0d2fb9edeba1", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `bit-vec` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `log` dependency) [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling hashbrown v0.8.2 [INFO] [stderr] Checking chunked-buffer v0.2.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Compiling bitcoinconsensus v0.20.2-0.5.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking ahash v0.3.8 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking as-any v0.3.1 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling bitcoin-consensus-derive v0.1.0 [INFO] [stderr] Compiling bolt-derive v0.3.1 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling test-log-macros v0.2.16 [INFO] [stderr] Checking test-log v0.2.16 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling serde_with_macros v3.9.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Checking serde_with v3.9.0 [INFO] [stderr] Checking secp256k1 v0.24.3 [INFO] [stderr] Checking bitcoin v0.29.2 [INFO] [stderr] Checking lightning v0.0.118 [INFO] [stderr] Checking serde_bolt v0.3.5 [INFO] [stderr] Checking bitcoin-push-decoder v0.2.2 [INFO] [stderr] Checking txoo v0.7.1 [INFO] [stderr] Checking lightning-invoice v0.26.0 [INFO] [stderr] Checking vls-core v0.12.0 [INFO] [stderr] Checking vls-protocol v0.12.0 [INFO] [stderr] Checking vls-protocol-signer v0.12.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/approver.rs:389:37 [INFO] [stdout] | [INFO] [stdout] 388 | pub fn new(delegate: A) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 389 | Self { delegate, approvals: Mutex::new(Vec::new()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:301:23 [INFO] [stdout] | [INFO] [stdout] 292 | services: NodeServices, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 301 | approver: Arc::new(NegativeApprover()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:358:12 [INFO] [stdout] | [INFO] [stdout] 336 | pub fn build(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | let persister = self.services.persister.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | let nodes = persister.get_nodes().expect("get_nodes"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | let node = if nodes.is_empty() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 342 | let node = Arc::new(Node::new(config, &self.seed, vec![], self.services)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 352 | let (node_id, entry) = nodes.into_iter().next().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | Ok(InitHandler::new(self.id, node, self.approver, self.max_protocol_version)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:523:12 [INFO] [stdout] | [INFO] [stdout] 512 | pub fn handle(&mut self, msg: Message) -> Result<(bool, Option>)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 515 | let result = self.do_handle(msg); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 519 | let (is_done, maybe_reply) = result?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 523 | Ok((is_done, maybe_reply)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:869:32 [INFO] [stdout] | [INFO] [stdout] 869 | .map(|prf| deserialize(prf.0.as_slice()).expect("deserialize TxoProof")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:995:61 [INFO] [stdout] | [INFO] [stdout] 995 | .with_channel(&channel_id, |channel| Ok(channel.get_anchor_redeemscript()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:1556:8 [INFO] [stdout] | [INFO] [stdout] 1541 | let redeemscript = Script::from(wscript.0.clone()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1556 | Ok(Box::new(msgs::SignTxReply { [INFO] [stdout] | ________^ [INFO] [stdout] 1557 | | signature: BitcoinSignature { [INFO] [stdout] 1558 | | signature: Signature(sig.serialize_compact()), [INFO] [stdout] 1559 | | sighash: EcdsaSighashType::All as u8, [INFO] [stdout] 1560 | | }, [INFO] [stdout] 1561 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:1591:8 [INFO] [stdout] | [INFO] [stdout] 1576 | let redeemscript = Script::from(wscript.0.clone()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1591 | Ok(Box::new(msgs::SignTxReply { [INFO] [stdout] | ________^ [INFO] [stdout] 1592 | | signature: BitcoinSignature { [INFO] [stdout] 1593 | | signature: Signature(sig.serialize_compact()), [INFO] [stdout] 1594 | | sighash: EcdsaSighashType::All as u8, [INFO] [stdout] 1595 | | }, [INFO] [stdout] 1596 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:1625:8 [INFO] [stdout] | [INFO] [stdout] 1610 | let redeemscript = Script::from(wscript.0.clone()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1625 | Ok(Box::new(msgs::SignTxReply { [INFO] [stdout] | ________^ [INFO] [stdout] 1626 | | signature: BitcoinSignature { [INFO] [stdout] 1627 | | signature: Signature(sig.sig.serialize_compact()), [INFO] [stdout] 1628 | | sighash: sig.typ as u8, [INFO] [stdout] 1629 | | }, [INFO] [stdout] 1630 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:1658:8 [INFO] [stdout] | [INFO] [stdout] 1643 | let redeemscript = Script::from(wscript.0.clone()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1658 | Ok(Box::new(msgs::SignTxReply { [INFO] [stdout] | ________^ [INFO] [stdout] 1659 | | signature: BitcoinSignature { [INFO] [stdout] 1660 | | signature: Signature(sig.serialize_compact()), [INFO] [stdout] 1661 | | sighash: EcdsaSighashType::All as u8, [INFO] [stdout] 1662 | | }, [INFO] [stdout] 1663 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:1686:18 [INFO] [stdout] | [INFO] [stdout] 1686 | .map(|o| o.witness_script.clone().unwrap_or(Script::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:1686:53 [INFO] [stdout] | [INFO] [stdout] 1686 | .map(|o| o.witness_script.clone().unwrap_or(Script::new())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vls-protocol-signer` (lib) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/approver.rs:389:37 [INFO] [stdout] | [INFO] [stdout] 388 | pub fn new(delegate: A) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 389 | Self { delegate, approvals: Mutex::new(Vec::new()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:301:23 [INFO] [stdout] | [INFO] [stdout] 292 | services: NodeServices, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 301 | approver: Arc::new(NegativeApprover()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:358:12 [INFO] [stdout] | [INFO] [stdout] 336 | pub fn build(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | let persister = self.services.persister.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | let nodes = persister.get_nodes().expect("get_nodes"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | let node = if nodes.is_empty() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 342 | let node = Arc::new(Node::new(config, &self.seed, vec![], self.services)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 352 | let (node_id, entry) = nodes.into_iter().next().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | Ok(InitHandler::new(self.id, node, self.approver, self.max_protocol_version)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:523:12 [INFO] [stdout] | [INFO] [stdout] 512 | pub fn handle(&mut self, msg: Message) -> Result<(bool, Option>)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 515 | let result = self.do_handle(msg); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 519 | let (is_done, maybe_reply) = result?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 523 | Ok((is_done, maybe_reply)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:869:32 [INFO] [stdout] | [INFO] [stdout] 869 | .map(|prf| deserialize(prf.0.as_slice()).expect("deserialize TxoProof")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:995:61 [INFO] [stdout] | [INFO] [stdout] 995 | .with_channel(&channel_id, |channel| Ok(channel.get_anchor_redeemscript()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:1556:8 [INFO] [stdout] | [INFO] [stdout] 1541 | let redeemscript = Script::from(wscript.0.clone()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1556 | Ok(Box::new(msgs::SignTxReply { [INFO] [stdout] | ________^ [INFO] [stdout] 1557 | | signature: BitcoinSignature { [INFO] [stdout] 1558 | | signature: Signature(sig.serialize_compact()), [INFO] [stdout] 1559 | | sighash: EcdsaSighashType::All as u8, [INFO] [stdout] 1560 | | }, [INFO] [stdout] 1561 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:1591:8 [INFO] [stdout] | [INFO] [stdout] 1576 | let redeemscript = Script::from(wscript.0.clone()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1591 | Ok(Box::new(msgs::SignTxReply { [INFO] [stdout] | ________^ [INFO] [stdout] 1592 | | signature: BitcoinSignature { [INFO] [stdout] 1593 | | signature: Signature(sig.serialize_compact()), [INFO] [stdout] 1594 | | sighash: EcdsaSighashType::All as u8, [INFO] [stdout] 1595 | | }, [INFO] [stdout] 1596 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:1625:8 [INFO] [stdout] | [INFO] [stdout] 1610 | let redeemscript = Script::from(wscript.0.clone()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1625 | Ok(Box::new(msgs::SignTxReply { [INFO] [stdout] | ________^ [INFO] [stdout] 1626 | | signature: BitcoinSignature { [INFO] [stdout] 1627 | | signature: Signature(sig.sig.serialize_compact()), [INFO] [stdout] 1628 | | sighash: sig.typ as u8, [INFO] [stdout] 1629 | | }, [INFO] [stdout] 1630 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:1658:8 [INFO] [stdout] | [INFO] [stdout] 1643 | let redeemscript = Script::from(wscript.0.clone()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1658 | Ok(Box::new(msgs::SignTxReply { [INFO] [stdout] | ________^ [INFO] [stdout] 1659 | | signature: BitcoinSignature { [INFO] [stdout] 1660 | | signature: Signature(sig.serialize_compact()), [INFO] [stdout] 1661 | | sighash: EcdsaSighashType::All as u8, [INFO] [stdout] 1662 | | }, [INFO] [stdout] 1663 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:1686:18 [INFO] [stdout] | [INFO] [stdout] 1686 | .map(|o| o.witness_script.clone().unwrap_or(Script::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handler.rs:1686:53 [INFO] [stdout] | [INFO] [stdout] 1686 | .map(|o| o.witness_script.clone().unwrap_or(Script::new())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vls-protocol-signer` (lib test) due to 13 previous errors [INFO] running `Command { std: "docker" "inspect" "49d606a59e8a4b5e071ac0afdcac59b86f2617f349bbb14fa7ff0d2fb9edeba1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49d606a59e8a4b5e071ac0afdcac59b86f2617f349bbb14fa7ff0d2fb9edeba1", kill_on_drop: false }` [INFO] [stdout] 49d606a59e8a4b5e071ac0afdcac59b86f2617f349bbb14fa7ff0d2fb9edeba1