[INFO] fetching crate vls-protocol-client 0.12.0... [INFO] checking vls-protocol-client-0.12.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vls-protocol-client 0.12.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate vls-protocol-client 0.12.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vls-protocol-client 0.12.0 [INFO] finished tweaking crates.io crate vls-protocol-client 0.12.0 [INFO] tweaked toml for crates.io crate vls-protocol-client 0.12.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 106 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding ahash v0.3.8 (latest: v0.8.11) [INFO] [stderr] Adding bech32 v0.9.1 (latest: v0.11.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitcoin v0.29.2 (latest: v0.32.2) [INFO] [stderr] Adding bitcoin-push-decoder v0.2.2 (latest: v0.3.0) [INFO] [stderr] Adding bitcoin_hashes v0.11.0 (latest: v0.14.0) [INFO] [stderr] Adding bitcoinconsensus v0.20.2-0.5.0 (latest: v0.106.0+26.0) [INFO] [stderr] Adding delegate v0.6.2 (latest: v0.12.0) [INFO] [stderr] Adding env_logger v0.9.3 (latest: v0.11.5) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.8.2 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding lightning v0.0.118 (latest: v0.0.123) [INFO] [stderr] Adding lightning-invoice v0.26.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding secp256k1 v0.24.3 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1-sys v0.6.1 (latest: v0.10.0) [INFO] [stderr] Adding serde_bolt v0.3.5 (latest: v0.4.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding txoo v0.7.1 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c9259c6838865c7da9f8082a5220a1198cb0f432d91ba303924feeec66857be0 [INFO] running `Command { std: "docker" "start" "-a" "c9259c6838865c7da9f8082a5220a1198cb0f432d91ba303924feeec66857be0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c9259c6838865c7da9f8082a5220a1198cb0f432d91ba303924feeec66857be0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9259c6838865c7da9f8082a5220a1198cb0f432d91ba303924feeec66857be0", kill_on_drop: false }` [INFO] [stdout] c9259c6838865c7da9f8082a5220a1198cb0f432d91ba303924feeec66857be0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ba7c0fa3b70b5135b838210a69c2c6c11179adf4dbc8ab167789ec1701971c14 [INFO] running `Command { std: "docker" "start" "-a" "ba7c0fa3b70b5135b838210a69c2c6c11179adf4dbc8ab167789ec1701971c14", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Compiling hashbrown v0.8.2 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking chunked-buffer v0.2.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking ahash v0.3.8 [INFO] [stderr] Checking as-any v0.3.1 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling serde_with_macros v3.9.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Compiling bitcoin-consensus-derive v0.1.0 [INFO] [stderr] Compiling bolt-derive v0.3.1 [INFO] [stderr] Compiling delegate v0.6.2 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Checking serde_with v3.9.0 [INFO] [stderr] Checking secp256k1 v0.24.3 [INFO] [stderr] Checking bitcoin v0.29.2 [INFO] [stderr] Checking serde_bolt v0.3.5 [INFO] [stderr] Checking lightning v0.0.118 [INFO] [stderr] Checking bitcoin-push-decoder v0.2.2 [INFO] [stderr] Checking txoo v0.7.1 [INFO] [stderr] Checking lightning-invoice v0.26.0 [INFO] [stderr] Checking vls-core v0.12.0 [INFO] [stderr] Checking vls-protocol v0.12.0 [INFO] [stderr] Checking vls-protocol-signer v0.12.0 [INFO] [stderr] Checking vls-protocol-client v0.12.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 168 | fn call(&self, message: T) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | call(self.dbid, PubKey(self.peer_id), &*self.transport, message).map_err(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 168 | fn call(&self, message: T) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | call(self.dbid, PubKey(self.peer_id), &*self.transport, message).map_err(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:514:9 [INFO] [stdout] | [INFO] [stdout] 502 | let mut psbt = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 508 | let streamed_psbt = StreamedPSBT::new(psbt).into(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 511 | let message = SignWithdrawal { utxos, psbt: streamed_psbt }; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 512 | let result: SignWithdrawalReply = self.call(message).expect("sign failed"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 513 | let psbt = result.psbt.0; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 514 | psbt.inputs.into_iter().map(|i| i.final_script_witness.unwrap().to_vec()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:514:9 [INFO] [stdout] | [INFO] [stdout] 502 | let mut psbt = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 508 | let streamed_psbt = StreamedPSBT::new(psbt).into(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 511 | let message = SignWithdrawal { utxos, psbt: streamed_psbt }; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 512 | let result: SignWithdrawalReply = self.call(message).expect("sign failed"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 513 | let psbt = result.psbt.0; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 514 | psbt.inputs.into_iter().map(|i| i.final_script_witness.unwrap().to_vec()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:718:12 [INFO] [stdout] | [INFO] [stdout] 711 | let secp_ctx = Secp256k1::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 718 | Ok(Script::new_v0_p2wpkh(&WPubkeyHash::hash(&pubkey.serialize()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:718:12 [INFO] [stdout] | [INFO] [stdout] 711 | let secp_ctx = Secp256k1::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 718 | Ok(Script::new_v0_p2wpkh(&WPubkeyHash::hash(&pubkey.serialize()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dyn_signer.rs:48:28 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(inner: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | DynSigner { inner: Box::new(inner) } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dyn_signer.rs:48:28 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(inner: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | DynSigner { inner: Box::new(inner) } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vls-protocol-client` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `vls-protocol-client` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "ba7c0fa3b70b5135b838210a69c2c6c11179adf4dbc8ab167789ec1701971c14", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba7c0fa3b70b5135b838210a69c2c6c11179adf4dbc8ab167789ec1701971c14", kill_on_drop: false }` [INFO] [stdout] ba7c0fa3b70b5135b838210a69c2c6c11179adf4dbc8ab167789ec1701971c14