[INFO] fetching crate vls-persist 0.12.0... [INFO] checking vls-persist-0.12.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vls-persist 0.12.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate vls-persist 0.12.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vls-persist 0.12.0 [INFO] finished tweaking crates.io crate vls-persist 0.12.0 [INFO] tweaked toml for crates.io crate vls-persist 0.12.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate vls-persist 0.12.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e35aa456293bdb02fbffc2bdcf1593dcee34d58874819ecbbe836f1f53d1c5ef [INFO] running `Command { std: "docker" "start" "-a" "e35aa456293bdb02fbffc2bdcf1593dcee34d58874819ecbbe836f1f53d1c5ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e35aa456293bdb02fbffc2bdcf1593dcee34d58874819ecbbe836f1f53d1c5ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e35aa456293bdb02fbffc2bdcf1593dcee34d58874819ecbbe836f1f53d1c5ef", kill_on_drop: false }` [INFO] [stdout] e35aa456293bdb02fbffc2bdcf1593dcee34d58874819ecbbe836f1f53d1c5ef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6943546e3721991e16c94c43da2f4a5b95c8f4ed9681f089b7a7e110acbdcb18 [INFO] running `Command { std: "docker" "start" "-a" "6943546e3721991e16c94c43da2f4a5b95c8f4ed9681f089b7a7e110acbdcb18", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling cc v1.0.97 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling serde v1.0.174 [INFO] [stderr] Compiling serde_derive v1.0.174 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling target-lexicon v0.12.11 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Compiling quote v1.0.31 [INFO] [stderr] Compiling syn v2.0.32 [INFO] [stderr] Compiling pyo3-build-config v0.20.0 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Compiling bitcoinconsensus v0.20.2-0.5.0 [INFO] [stderr] Compiling backtrace v0.3.68 [INFO] [stderr] Compiling hashbrown v0.8.2 [INFO] [stderr] Checking gimli v0.27.3 [INFO] [stderr] Checking regex-automata v0.3.3 [INFO] [stderr] Checking chunked-buffer v0.2.0 [INFO] [stderr] Compiling anyhow v1.0.72 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking regex v1.9.1 [INFO] [stderr] Checking addr2line v0.20.0 [INFO] [stderr] Checking object v0.31.1 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking pin-project-lite v0.2.10 [INFO] [stderr] Checking ahash v0.3.8 [INFO] [stderr] Compiling serde_json v1.0.103 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking secp256k1 v0.24.3 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling redb v1.3.0 [INFO] [stderr] Compiling darling_core v0.20.3 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Compiling bitcoin-consensus-derive v0.1.0 [INFO] [stderr] Compiling bolt-derive v0.3.1 [INFO] [stderr] Compiling test-log v0.2.12 [INFO] [stderr] Checking uuid v1.4.1 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling darling_macro v0.20.3 [INFO] [stderr] Compiling darling v0.20.3 [INFO] [stderr] Compiling serde_with_macros v3.6.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking serde_with v3.6.0 [INFO] [stderr] Checking bitcoin v0.29.2 [INFO] [stderr] Checking serde_bolt v0.3.5 [INFO] [stderr] Checking lightning v0.0.118 [INFO] [stderr] Checking bitcoin-push-decoder v0.2.2 [INFO] [stderr] Checking txoo v0.7.1 [INFO] [stderr] Checking lightning-invoice v0.26.0 [INFO] [stderr] Checking vls-core v0.12.0 [INFO] [stderr] Checking vls-persist v0.12.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:204:45 [INFO] [stdout] | [INFO] [stdout] 204 | .map(|(k, (l, s))| (k.clone(), (l.get_state().clone(), s.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:235:13 [INFO] [stdout] | [INFO] [stdout] 215 | validator_factory: Arc, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | / ChainTracker::restore( [INFO] [stdout] 236 | | headers, [INFO] [stdout] 237 | | tip, [INFO] [stdout] 238 | | self.height, [INFO] [stdout] ... | [INFO] [stdout] 243 | | vec![], [INFO] [stdout] 244 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:228:41 [INFO] [stdout] | [INFO] [stdout] 228 | self.headers.iter().map(|h| deserialize(h).expect("deserialize header")).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kvv.rs:204:12 [INFO] [stdout] | [INFO] [stdout] 199 | validator_factory: Arc, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | Ok(model.into_tracker(node_id.clone(), validator_factory)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kvv.rs:230:12 [INFO] [stdout] | [INFO] [stdout] 229 | let entry: ChannelEntry = F::de_value(&value)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | Ok(entry.into()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vls-persist` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backup_persister.rs:295:16 [INFO] [stdout] | [INFO] [stdout] 289 | validator_factory: Arc, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 290 | ) -> Result<(ChainTracker, Vec), Error> { [INFO] [stdout] 291 | let state = self.state.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 295 | Ok(model.into_tracker(node_id.clone(), validator_factory)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:204:45 [INFO] [stdout] | [INFO] [stdout] 204 | .map(|(k, (l, s))| (k.clone(), (l.get_state().clone(), s.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:235:13 [INFO] [stdout] | [INFO] [stdout] 215 | validator_factory: Arc, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | / ChainTracker::restore( [INFO] [stdout] 236 | | headers, [INFO] [stdout] 237 | | tip, [INFO] [stdout] 238 | | self.height, [INFO] [stdout] ... | [INFO] [stdout] 243 | | vec![], [INFO] [stdout] 244 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:228:41 [INFO] [stdout] | [INFO] [stdout] 228 | self.headers.iter().map(|h| deserialize(h).expect("deserialize header")).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kvv.rs:204:12 [INFO] [stdout] | [INFO] [stdout] 199 | validator_factory: Arc, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | Ok(model.into_tracker(node_id.clone(), validator_factory)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kvv.rs:230:12 [INFO] [stdout] | [INFO] [stdout] 229 | let entry: ChannelEntry = F::de_value(&value)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | Ok(entry.into()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vls-persist` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "6943546e3721991e16c94c43da2f4a5b95c8f4ed9681f089b7a7e110acbdcb18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6943546e3721991e16c94c43da2f4a5b95c8f4ed9681f089b7a7e110acbdcb18", kill_on_drop: false }` [INFO] [stdout] 6943546e3721991e16c94c43da2f4a5b95c8f4ed9681f089b7a7e110acbdcb18