[INFO] fetching crate vivisect 0.1.12... [INFO] checking vivisect-0.1.12 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vivisect 0.1.12 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate vivisect 0.1.12 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vivisect 0.1.12 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate vivisect 0.1.12 [INFO] tweaked toml for crates.io crate vivisect 0.1.12 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate vivisect 0.1.12 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `log` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `scroll` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 610edba476d4e8d39cdfb4e8341d532735b172de7b85c1b62d552449211257cd [INFO] running `Command { std: "docker" "start" "-a" "610edba476d4e8d39cdfb4e8341d532735b172de7b85c1b62d552449211257cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "610edba476d4e8d39cdfb4e8341d532735b172de7b85c1b62d552449211257cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "610edba476d4e8d39cdfb4e8341d532735b172de7b85c1b62d552449211257cd", kill_on_drop: false }` [INFO] [stdout] 610edba476d4e8d39cdfb4e8341d532735b172de7b85c1b62d552449211257cd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5ed418e8c3217d724ff508753203977b667dd941d232102d2c5eab2f375fcc43 [INFO] running `Command { std: "docker" "start" "-a" "5ed418e8c3217d724ff508753203977b667dd941d232102d2c5eab2f375fcc43", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `log` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `scroll` dependency) [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling cc v1.0.96 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking plain v0.2.3 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Compiling capstone-sys v0.16.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking simple_logger v5.0.0 [INFO] [stderr] Compiling scroll_derive v0.12.0 [INFO] [stderr] Checking scroll v0.12.0 [INFO] [stderr] Checking goblin v0.8.2 [INFO] [stderr] Checking capstone v0.12.0 [INFO] [stderr] Checking vivisect v0.1.12 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pe/export.rs:198:28 [INFO] [stdout] | [INFO] [stdout] 198 | .and_then(|offset| bytes.pread(offset).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pe/export.rs:258:13 [INFO] [stdout] | [INFO] [stdout] 258 | Err(error::Error::Malformed(format!( [INFO] [stdout] | _____________^ [INFO] [stdout] 259 | | "Reexport {:#} is malformed", [INFO] [stdout] 260 | | reexport [INFO] [stdout] 261 | | ))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pe/export.rs:310:32 [INFO] [stdout] | [INFO] [stdout] 310 | .and_then(|offset| bytes.pread::<&str>(offset).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vivisect` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pe/export.rs:198:28 [INFO] [stdout] | [INFO] [stdout] 198 | .and_then(|offset| bytes.pread(offset).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pe/export.rs:258:13 [INFO] [stdout] | [INFO] [stdout] 258 | Err(error::Error::Malformed(format!( [INFO] [stdout] | _____________^ [INFO] [stdout] 259 | | "Reexport {:#} is malformed", [INFO] [stdout] 260 | | reexport [INFO] [stdout] 261 | | ))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pe/export.rs:310:32 [INFO] [stdout] | [INFO] [stdout] 310 | .and_then(|offset| bytes.pread::<&str>(offset).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pe/mod.rs:366:32 [INFO] [stdout] | [INFO] [stdout] 366 | .map(|(_, _, sym)| sym.name(&strings).unwrap().to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vivisect` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "5ed418e8c3217d724ff508753203977b667dd941d232102d2c5eab2f375fcc43", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ed418e8c3217d724ff508753203977b667dd941d232102d2c5eab2f375fcc43", kill_on_drop: false }` [INFO] [stdout] 5ed418e8c3217d724ff508753203977b667dd941d232102d2c5eab2f375fcc43