[INFO] fetching crate vivid 0.10.1... [INFO] checking vivid-0.10.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vivid 0.10.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate vivid 0.10.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vivid 0.10.1 [INFO] finished tweaking crates.io crate vivid 0.10.1 [INFO] tweaked toml for crates.io crate vivid 0.10.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate vivid 0.10.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4f74be604d559bcb38f5dadd9646de120016b9775d104c9c23064a16fa07b3a3 [INFO] running `Command { std: "docker" "start" "-a" "4f74be604d559bcb38f5dadd9646de120016b9775d104c9c23064a16fa07b3a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4f74be604d559bcb38f5dadd9646de120016b9775d104c9c23064a16fa07b3a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f74be604d559bcb38f5dadd9646de120016b9775d104c9c23064a16fa07b3a3", kill_on_drop: false }` [INFO] [stdout] 4f74be604d559bcb38f5dadd9646de120016b9775d104c9c23064a16fa07b3a3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 88010a0857d0abd5bb508514b0117a0eb0464154af0e1c7a02b17c09dfd92854 [INFO] running `Command { std: "docker" "start" "-a" "88010a0857d0abd5bb508514b0117a0eb0464154af0e1c7a02b17c09dfd92854", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling cpufeatures v0.2.12 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking bytemuck v1.16.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking etcetera v0.8.0 [INFO] [stderr] Checking rgb v0.8.37 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Compiling syn v2.0.67 [INFO] [stderr] Checking ansi_colours v1.2.2 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking rust-embed-utils v8.4.0 [INFO] [stderr] Compiling rust-embed-impl v8.4.0 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking rust-embed v8.4.0 [INFO] [stderr] Checking vivid v0.10.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | Err(VividError::CouldNotFindTheme(theme.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:189:52 [INFO] [stdout] | [INFO] [stdout] 189 | .map(|(filetype, category)| (filetype, theme.get_style(category))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/theme.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 28 | let mut docs = YamlLoader::load_from_str(contents)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let doc = docs.pop().ok_or(VividError::EmptyThemeFile)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(Theme { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | colors, [INFO] [stdout] 49 | | categories: doc, [INFO] [stdout] 50 | | color_mode, [INFO] [stdout] 51 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/theme.rs:58:25 [INFO] [stdout] | [INFO] [stdout] 58 | .or_else(|| color_str.parse().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 17 | opt: Option>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | ) -> std::result::Result, E> { [INFO] [stdout] 19 | opt.map_or(Ok(None), |res| res.map(Some)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vivid` (bin "vivid") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | Err(VividError::CouldNotFindTheme(theme.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:189:52 [INFO] [stdout] | [INFO] [stdout] 189 | .map(|(filetype, category)| (filetype, theme.get_style(category))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/theme.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 28 | let mut docs = YamlLoader::load_from_str(contents)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let doc = docs.pop().ok_or(VividError::EmptyThemeFile)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(Theme { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | colors, [INFO] [stdout] 49 | | categories: doc, [INFO] [stdout] 50 | | color_mode, [INFO] [stdout] 51 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/theme.rs:58:25 [INFO] [stdout] | [INFO] [stdout] 58 | .or_else(|| color_str.parse().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 17 | opt: Option>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | ) -> std::result::Result, E> { [INFO] [stdout] 19 | opt.map_or(Ok(None), |res| res.map(Some)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vivid` (bin "vivid" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "88010a0857d0abd5bb508514b0117a0eb0464154af0e1c7a02b17c09dfd92854", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88010a0857d0abd5bb508514b0117a0eb0464154af0e1c7a02b17c09dfd92854", kill_on_drop: false }` [INFO] [stdout] 88010a0857d0abd5bb508514b0117a0eb0464154af0e1c7a02b17c09dfd92854