[INFO] fetching crate visqol-rs 0.1.2... [INFO] checking visqol-rs-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate visqol-rs 0.1.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate visqol-rs 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate visqol-rs 0.1.2 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate visqol-rs 0.1.2 [INFO] tweaked toml for crates.io crate visqol-rs 0.1.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate visqol-rs 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6e8f97b0af787fadef702e908c213c21165d9e34020610744f2be752adb11b34 [INFO] running `Command { std: "docker" "start" "-a" "6e8f97b0af787fadef702e908c213c21165d9e34020610744f2be752adb11b34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6e8f97b0af787fadef702e908c213c21165d9e34020610744f2be752adb11b34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e8f97b0af787fadef702e908c213c21165d9e34020610744f2be752adb11b34", kill_on_drop: false }` [INFO] [stdout] 6e8f97b0af787fadef702e908c213c21165d9e34020610744f2be752adb11b34 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f41ccb1010c8db9d1ec1e2e170b44dc4b414271a126977388b3f143f398ab47f [INFO] running `Command { std: "docker" "start" "-a" "f41ccb1010c8db9d1ec1e2e170b44dc4b414271a126977388b3f143f398ab47f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking cblas-sys v0.1.4 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling rustfft v6.2.0 [INFO] [stderr] Checking lapack-sys v0.14.0 [INFO] [stderr] Checking num-bigint v0.4.5 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking transpose v0.2.3 [INFO] [stderr] Checking primal-check v0.3.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking noisy_float v0.2.0 [INFO] [stderr] Checking simd_aligned v0.4.0 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking ffsvm v0.9.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling katexit v0.1.4 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking cauchy v0.4.0 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking lax v0.16.0 [INFO] [stderr] Checking ndarray-linalg v0.16.0 [INFO] [stderr] Checking ndarray-stats v0.5.1 [INFO] [stderr] Checking visqol-rs v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alignment.rs:38:10 [INFO] [stdout] | [INFO] [stdout] 13 | let (aligned_deg_signal, lag) = globally_align(ref_signal, deg_signal)?; [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | [INFO] [stdout] 15 | let mut new_ref_matrix = ref_signal.data_matrix.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let mut new_deg_matrix = aligned_deg_signal.data_matrix; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Some(( [INFO] [stdout] | __________^ [INFO] [stdout] 39 | | AudioSignal::new(new_ref_matrix.as_slice()?, ref_signal.sample_rate), [INFO] [stdout] 40 | | AudioSignal::new(new_deg_matrix.as_slice()?, deg_signal.sample_rate), [INFO] [stdout] 41 | | lag, [INFO] [stdout] 42 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio_utils.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 53 | let final_signal = extract_multichannel(wav_reader.num_channels as usize, &data_vector_float); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | [INFO] [stdout] 55 | let final_signal = to_mono_matrix(&final_signal); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | [INFO] [stdout] 57 | Ok(AudioSignal { [INFO] [stdout] | ________^ [INFO] [stdout] 58 | | data_matrix: final_signal / wav_reader.num_channels as f64, [INFO] [stdout] 59 | | sample_rate: wav_reader.sample_rate, [INFO] [stdout] 60 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/envelope.rs:59:10 [INFO] [stdout] | [INFO] [stdout] 23 | let mut fft_manager = FftManager::new(signal.len()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let mut element_wise_product = Array1::::zeros(freq_domain_signal.len()); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Some(Array1::::from_vec(hilbert)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gammatone_spectrogram_builder.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 30 | let (mut filter_coeffs, mut center_freqs) = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let mut out_matrix = Array2::::zeros((self.filter_bank.num_bands, num_cols)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Ok(Spectrogram::new(out_matrix, center_freqs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `visqol-rs` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alignment.rs:38:10 [INFO] [stdout] | [INFO] [stdout] 13 | let (aligned_deg_signal, lag) = globally_align(ref_signal, deg_signal)?; [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | [INFO] [stdout] 15 | let mut new_ref_matrix = ref_signal.data_matrix.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let mut new_deg_matrix = aligned_deg_signal.data_matrix; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Some(( [INFO] [stdout] | __________^ [INFO] [stdout] 39 | | AudioSignal::new(new_ref_matrix.as_slice()?, ref_signal.sample_rate), [INFO] [stdout] 40 | | AudioSignal::new(new_deg_matrix.as_slice()?, deg_signal.sample_rate), [INFO] [stdout] 41 | | lag, [INFO] [stdout] 42 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio_utils.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 53 | let final_signal = extract_multichannel(wav_reader.num_channels as usize, &data_vector_float); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | [INFO] [stdout] 55 | let final_signal = to_mono_matrix(&final_signal); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | [INFO] [stdout] 57 | Ok(AudioSignal { [INFO] [stdout] | ________^ [INFO] [stdout] 58 | | data_matrix: final_signal / wav_reader.num_channels as f64, [INFO] [stdout] 59 | | sample_rate: wav_reader.sample_rate, [INFO] [stdout] 60 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/envelope.rs:59:10 [INFO] [stdout] | [INFO] [stdout] 23 | let mut fft_manager = FftManager::new(signal.len()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let mut element_wise_product = Array1::::zeros(freq_domain_signal.len()); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Some(Array1::::from_vec(hilbert)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gammatone_spectrogram_builder.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 30 | let (mut filter_coeffs, mut center_freqs) = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let mut out_matrix = Array2::::zeros((self.filter_bank.num_bands, num_cols)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Ok(Spectrogram::new(out_matrix, center_freqs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `visqol-rs` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "f41ccb1010c8db9d1ec1e2e170b44dc4b414271a126977388b3f143f398ab47f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f41ccb1010c8db9d1ec1e2e170b44dc4b414271a126977388b3f143f398ab47f", kill_on_drop: false }` [INFO] [stdout] f41ccb1010c8db9d1ec1e2e170b44dc4b414271a126977388b3f143f398ab47f