[INFO] fetching crate vimg 0.1.3... [INFO] checking vimg-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vimg 0.1.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate vimg 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vimg 0.1.3 [INFO] finished tweaking crates.io crate vimg 0.1.3 [INFO] tweaked toml for crates.io crate vimg 0.1.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate vimg 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c2f7bd6b33bf4753dacb6c41d699f768ec19ff5dae6c2baa667cc82e84b0a38d [INFO] running `Command { std: "docker" "start" "-a" "c2f7bd6b33bf4753dacb6c41d699f768ec19ff5dae6c2baa667cc82e84b0a38d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c2f7bd6b33bf4753dacb6c41d699f768ec19ff5dae6c2baa667cc82e84b0a38d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2f7bd6b33bf4753dacb6c41d699f768ec19ff5dae6c2baa667cc82e84b0a38d", kill_on_drop: false }` [INFO] [stdout] c2f7bd6b33bf4753dacb6c41d699f768ec19ff5dae6c2baa667cc82e84b0a38d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e246e6d25d086edbddf90edaeba1b6da2beb98d3d43ecb6aa5b9d51d9ff1dc4c [INFO] running `Command { std: "docker" "start" "-a" "e246e6d25d086edbddf90edaeba1b6da2beb98d3d43ecb6aa5b9d51d9ff1dc4c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Compiling rustix v0.38.4 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Compiling rustix v0.37.23 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Compiling serde v1.0.176 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling portable-atomic v1.4.1 [INFO] [stderr] Checking ttf-parser v0.19.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling serde_derive v1.0.176 [INFO] [stderr] Compiling serde_json v1.0.104 [INFO] [stderr] Checking weezl v0.1.7 [INFO] [stderr] Checking fdeflate v0.3.0 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Compiling anyhow v1.0.72 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking flate2 v1.0.26 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Checking half v2.2.1 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking bytemuck v1.13.1 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Compiling syn v2.0.27 [INFO] [stderr] Checking gif v0.12.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking xi-unicode v0.3.0 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Checking fastrand v2.0.0 [INFO] [stderr] Checking png v0.17.9 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking nix v0.26.2 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking indicatif v0.17.5 [INFO] [stderr] Checking owned_ttf_parser v0.19.0 [INFO] [stderr] Checking ab_glyph v0.2.21 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking glyph_brush_layout v0.2.3 [INFO] [stderr] Checking ctrlc v3.4.0 [INFO] [stderr] Checking terminal_size v0.2.6 [INFO] [stderr] Checking clap_builder v4.3.19 [INFO] [stderr] Checking jpeg-decoder v0.3.0 [INFO] [stderr] Checking ffprobe v0.3.3 [INFO] [stderr] Compiling pin-project-internal v1.1.2 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Checking tiff v0.8.1 [INFO] [stderr] Checking pin-project v1.1.2 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking exr v1.7.0 [INFO] [stderr] Checking clap v4.3.19 [INFO] [stderr] Checking clap_complete v4.3.2 [INFO] [stderr] Checking image v0.24.6 [INFO] [stderr] Checking vimg v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `arg_if` and `arg2_if` are never used [INFO] [stdout] --> src/process.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub trait CommandExt { [INFO] [stdout] | ---------- methods in this trait [INFO] [stdout] 4 | /// Adds an argument if `condition` otherwise noop. [INFO] [stdout] 5 | fn arg_if(&mut self, condition: bool, a: impl ArgString) -> &mut Self; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 14 | fn arg2_if(&mut self, condition: bool, a: impl ArgString, b: impl ArgString) -> &mut Self; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/extract.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | / rayon::ThreadPoolBuilder::new() [INFO] [stdout] 93 | | .num_threads(*threads) [INFO] [stdout] 94 | | .build()? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/extract.rs:198:61 [INFO] [stdout] | [INFO] [stdout] 198 | fs::hard_link(&prev, &next).or_else(|_| fs::copy(&prev, &next).map(|_| ()))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/join.rs:50:22 [INFO] [stdout] | [INFO] [stdout] 50 | .map(|i| self.load_image(i).map_err(|e| anyhow!("{i:?}: {e}"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/vcs.rs:194:26 [INFO] [stdout] | [INFO] [stdout] 194 | .or_else(|_| fs::copy(&temp_out_file, &out_file).map(|_| ()))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/temporary.rs:26:39 [INFO] [stdout] | [INFO] [stdout] 26 | conf_parent.unwrap_or_else(|| env::current_dir().expect("current working directory")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vimg` (bin "vimg") due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: methods `arg_if` and `arg2_if` are never used [INFO] [stdout] --> src/process.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub trait CommandExt { [INFO] [stdout] | ---------- methods in this trait [INFO] [stdout] 4 | /// Adds an argument if `condition` otherwise noop. [INFO] [stdout] 5 | fn arg_if(&mut self, condition: bool, a: impl ArgString) -> &mut Self; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 14 | fn arg2_if(&mut self, condition: bool, a: impl ArgString, b: impl ArgString) -> &mut Self; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/extract.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | / rayon::ThreadPoolBuilder::new() [INFO] [stdout] 93 | | .num_threads(*threads) [INFO] [stdout] 94 | | .build()? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/extract.rs:198:61 [INFO] [stdout] | [INFO] [stdout] 198 | fs::hard_link(&prev, &next).or_else(|_| fs::copy(&prev, &next).map(|_| ()))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/join.rs:50:22 [INFO] [stdout] | [INFO] [stdout] 50 | .map(|i| self.load_image(i).map_err(|e| anyhow!("{i:?}: {e}"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/vcs.rs:194:26 [INFO] [stdout] | [INFO] [stdout] 194 | .or_else(|_| fs::copy(&temp_out_file, &out_file).map(|_| ()))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/temporary.rs:26:39 [INFO] [stdout] | [INFO] [stdout] 26 | conf_parent.unwrap_or_else(|| env::current_dir().expect("current working directory")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vimg` (bin "vimg" test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "e246e6d25d086edbddf90edaeba1b6da2beb98d3d43ecb6aa5b9d51d9ff1dc4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e246e6d25d086edbddf90edaeba1b6da2beb98d3d43ecb6aa5b9d51d9ff1dc4c", kill_on_drop: false }` [INFO] [stdout] e246e6d25d086edbddf90edaeba1b6da2beb98d3d43ecb6aa5b9d51d9ff1dc4c