[INFO] fetching crate video_hash_filesystem_cache 0.1.0... [INFO] checking video_hash_filesystem_cache-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate video_hash_filesystem_cache 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate video_hash_filesystem_cache 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate video_hash_filesystem_cache 0.1.0 [INFO] finished tweaking crates.io crate video_hash_filesystem_cache 0.1.0 [INFO] tweaked toml for crates.io crate video_hash_filesystem_cache 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 119 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding deflate v0.8.6 (latest: v1.0.0) [INFO] [stderr] Adding gif v0.11.4 (latest: v0.13.1) [INFO] [stderr] Adding image v0.23.14 (latest: v0.25.2) [INFO] [stderr] Adding image v0.24.9 (latest: v0.25.2) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding jpeg-decoder v0.1.22 (latest: v0.3.1) [INFO] [stderr] Adding miniz_oxide v0.3.7 (latest: v0.8.0) [INFO] [stderr] Adding miniz_oxide v0.4.4 (latest: v0.8.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding num-complex v0.3.1 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.3.2 (latest: v0.4.2) [INFO] [stderr] Adding png v0.16.8 (latest: v0.17.13) [INFO] [stderr] Adding rustdct v0.6.0 (latest: v0.7.1) [INFO] [stderr] Adding rustfft v5.1.1 (latest: v6.2.0) [INFO] [stderr] Adding tiff v0.6.1 (latest: v0.9.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 20f40a942fae7a37557190d93052715ec822d3b893f556e3931c4974553d5317 [INFO] running `Command { std: "docker" "start" "-a" "20f40a942fae7a37557190d93052715ec822d3b893f556e3931c4974553d5317", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "20f40a942fae7a37557190d93052715ec822d3b893f556e3931c4974553d5317", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "20f40a942fae7a37557190d93052715ec822d3b893f556e3931c4974553d5317", kill_on_drop: false }` [INFO] [stdout] 20f40a942fae7a37557190d93052715ec822d3b893f556e3931c4974553d5317 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 348463288d8ff10b9656ce5eb52fef7f98aba3af7136074c9a7b4b6a75a28613 [INFO] running `Command { std: "docker" "start" "-a" "348463288d8ff10b9656ce5eb52fef7f98aba3af7136074c9a7b4b6a75a28613", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.3.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking primal-check v0.3.4 [INFO] [stderr] Checking transpose v0.2.3 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking rustfft v5.1.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rustdct v0.6.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking generic_filesystem_cache v0.1.0 [INFO] [stderr] Checking ffmpeg_cmdline_utils v0.1.3 [INFO] [stderr] Checking vid_dup_finder_lib v0.1.1 [INFO] [stderr] Checking video_hash_filesystem_cache v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_projection.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 74 | src_paths: impl IntoIterator>, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | excl_paths: impl IntoIterator>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | excl_exts: impl IntoIterator>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 104 | | src_paths, [INFO] [stdout] 105 | | excl_paths, [INFO] [stdout] 106 | | projected_files: Default::default(), [INFO] [stdout] 107 | | state: Unprojected, [INFO] [stdout] 108 | | excl_exts: excl_exts.into_iter().map(|x| x.as_ref().to_os_string()).collect(), [INFO] [stdout] 109 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_projection.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 74 | src_paths: impl IntoIterator>, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | excl_paths: impl IntoIterator>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | excl_exts: impl IntoIterator>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 104 | | src_paths, [INFO] [stdout] 105 | | excl_paths, [INFO] [stdout] 106 | | projected_files: Default::default(), [INFO] [stdout] 107 | | state: Unprojected, [INFO] [stdout] 108 | | excl_exts: excl_exts.into_iter().map(|x| x.as_ref().to_os_string()).collect(), [INFO] [stdout] 109 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hash_filesystem_cache.rs:77:32 [INFO] [stdout] | [INFO] [stdout] 77 | .filter(|src_path| self.fetch(src_path).is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hash_filesystem_cache.rs:77:32 [INFO] [stdout] | [INFO] [stdout] 77 | .filter(|src_path| self.fetch(src_path).is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hash_filesystem_cache.rs:90:15 [INFO] [stdout] | [INFO] [stdout] 88 | src_path: impl AsRef, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | ) -> Result>, VdfCacheError> { [INFO] [stdout] 90 | match self.0.fetch_update(&src_path.as_ref().to_path_buf()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hash_filesystem_cache.rs:90:15 [INFO] [stdout] | [INFO] [stdout] 88 | src_path: impl AsRef, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | ) -> Result>, VdfCacheError> { [INFO] [stdout] 90 | match self.0.fetch_update(&src_path.as_ref().to_path_buf()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hash_filesystem_cache.rs:147:42 [INFO] [stdout] | [INFO] [stdout] 147 | .filter_map(|path| match self.fetch_update(&path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hash_filesystem_cache.rs:147:42 [INFO] [stdout] | [INFO] [stdout] 147 | .filter_map(|path| match self.fetch_update(&path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hash_filesystem_cache.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 167 | fn fetch_entry(&self, src_path: impl AsRef) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | / self.0 [INFO] [stdout] 169 | | .fetch(src_path.as_ref().to_path_buf()) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hash_filesystem_cache.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 167 | fn fetch_entry(&self, src_path: impl AsRef) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | / self.0 [INFO] [stdout] 169 | | .fetch(src_path.as_ref().to_path_buf()) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `video_hash_filesystem_cache` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `video_hash_filesystem_cache` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "348463288d8ff10b9656ce5eb52fef7f98aba3af7136074c9a7b4b6a75a28613", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "348463288d8ff10b9656ce5eb52fef7f98aba3af7136074c9a7b4b6a75a28613", kill_on_drop: false }` [INFO] [stdout] 348463288d8ff10b9656ce5eb52fef7f98aba3af7136074c9a7b4b6a75a28613