[INFO] fetching crate vid_dup_finder_lib 0.1.1... [INFO] checking vid_dup_finder_lib-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vid_dup_finder_lib 0.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate vid_dup_finder_lib 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vid_dup_finder_lib 0.1.1 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate vid_dup_finder_lib 0.1.1 [INFO] tweaked toml for crates.io crate vid_dup_finder_lib 0.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate vid_dup_finder_lib 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5bf33a0d5992b6ad8382e52b1702bf661edeaafceeffdbf9973a526e8fcc0e13 [INFO] running `Command { std: "docker" "start" "-a" "5bf33a0d5992b6ad8382e52b1702bf661edeaafceeffdbf9973a526e8fcc0e13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5bf33a0d5992b6ad8382e52b1702bf661edeaafceeffdbf9973a526e8fcc0e13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5bf33a0d5992b6ad8382e52b1702bf661edeaafceeffdbf9973a526e8fcc0e13", kill_on_drop: false }` [INFO] [stdout] 5bf33a0d5992b6ad8382e52b1702bf661edeaafceeffdbf9973a526e8fcc0e13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d79e019cd7c7cf3749dbc3f09cffa5cf1b04cbd382124e0b5cc060267e09a43b [INFO] running `Command { std: "docker" "start" "-a" "d79e019cd7c7cf3749dbc3f09cffa5cf1b04cbd382124e0b5cc060267e09a43b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.127 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling crossbeam-utils v0.8.11 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling crossbeam-epoch v0.9.10 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking either v1.7.0 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking crossbeam-deque v0.8.2 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Compiling serde_derive v1.0.142 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking spin v0.9.4 [INFO] [stderr] Checking deflate v1.0.0 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking weezl v0.1.7 [INFO] [stderr] Compiling serde v1.0.142 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking strength_reduce v0.2.3 [INFO] [stderr] Checking lebe v0.5.1 [INFO] [stderr] Checking bit_field v0.10.1 [INFO] [stderr] Compiling serde_json v1.0.83 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking png v0.17.5 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Checking transpose v0.2.1 [INFO] [stderr] Checking primal-check v0.3.1 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking num-complex v0.3.1 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking bytemuck v1.11.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rustfft v5.1.1 [INFO] [stderr] Checking jpeg-decoder v0.2.6 [INFO] [stderr] Checking tiff v0.7.3 [INFO] [stderr] Compiling pin-project-internal v1.0.11 [INFO] [stderr] Compiling thiserror-impl v1.0.32 [INFO] [stderr] Checking pin-project v1.0.11 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking thiserror v1.0.32 [INFO] [stderr] Checking exr v1.4.2 [INFO] [stderr] Checking rustdct v0.6.0 [INFO] [stderr] Checking image v0.24.3 [INFO] [stderr] Checking ffmpeg_cmdline_utils v0.1.2 [INFO] [stderr] Checking vid_dup_finder_lib v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/lib.rs:108:54 [INFO] [stdout] | [INFO] [stdout] 108 | pub use video_hashing::video_hash::test_util::{self, *}; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/video_hashing/search.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | for mut entry in self.duration_slice(target.duration()) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/video_hashing/search.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | for mut entry in self.duration_slice(target.duration()) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/hash_creation_error_kind.rs:9:42 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Error, Debug, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/hash_creation_error_kind.rs:9:42 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Error, Debug, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/matches/match_group.rs:21:25 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(entries: impl IntoIterator) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | duplicates: entries.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/matches/match_group.rs:21:25 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(entries: impl IntoIterator) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | duplicates: entries.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/matches/match_group.rs:30:25 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new_with_reference(reference: VideoHash, entries: impl IntoIterator) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | duplicates: entries.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/matches/match_group.rs:30:25 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new_with_reference(reference: VideoHash, entries: impl IntoIterator) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | duplicates: entries.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/matches/match_group.rs:56:25 [INFO] [stdout] | [INFO] [stdout] 55 | fn from(it: I) -> MatchGroup { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | MatchGroup::new(it.into_iter().map(|x| x.borrow().clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/matches/match_group.rs:56:25 [INFO] [stdout] | [INFO] [stdout] 55 | fn from(it: I) -> MatchGroup { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | MatchGroup::new(it.into_iter().map(|x| x.borrow().clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/video_dup_finder.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 18 | ref_hashes: impl IntoIterator, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | new_hashes: impl IntoIterator, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | / ref_hashes [INFO] [stdout] 24 | | .into_iter() [INFO] [stdout] 25 | | .filter_map(|new_hash| { [INFO] [stdout] 26 | | let search_result = [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/video_hash.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 89 | src_path: impl AsRef [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | ) -> Result<(FfmpegFrames, VideoInfo), HashCreationErrorKind> { [INFO] [stdout] 91 | / FfmpegFrameReaderBuilder::new(src_path.as_ref().to_owned()) [INFO] [stdout] 92 | | .num_frames(HASH_NUM_IMAGES as u32) [INFO] [stdout] 93 | | .fps(crate::definitions::HASH_FRAMERATE) [INFO] [stdout] 94 | | .timeout_secs(60) [INFO] [stdout] 95 | | .spawn() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/video_dup_finder.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 18 | ref_hashes: impl IntoIterator, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | new_hashes: impl IntoIterator, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | / ref_hashes [INFO] [stdout] 24 | | .into_iter() [INFO] [stdout] 25 | | .filter_map(|new_hash| { [INFO] [stdout] 26 | | let search_result = [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/video_hash.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 89 | src_path: impl AsRef [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | ) -> Result<(FfmpegFrames, VideoInfo), HashCreationErrorKind> { [INFO] [stdout] 91 | / FfmpegFrameReaderBuilder::new(src_path.as_ref().to_owned()) [INFO] [stdout] 92 | | .num_frames(HASH_NUM_IMAGES as u32) [INFO] [stdout] 93 | | .fps(crate::definitions::HASH_FRAMERATE) [INFO] [stdout] 94 | | .timeout_secs(60) [INFO] [stdout] 95 | | .spawn() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vid_dup_finder_lib` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `vid_dup_finder_lib` (lib) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d79e019cd7c7cf3749dbc3f09cffa5cf1b04cbd382124e0b5cc060267e09a43b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d79e019cd7c7cf3749dbc3f09cffa5cf1b04cbd382124e0b5cc060267e09a43b", kill_on_drop: false }` [INFO] [stdout] d79e019cd7c7cf3749dbc3f09cffa5cf1b04cbd382124e0b5cc060267e09a43b