[INFO] fetching crate victorem 0.8.2... [INFO] checking victorem-0.8.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate victorem 0.8.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate victorem 0.8.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate victorem 0.8.2 [INFO] finished tweaking crates.io crate victorem 0.8.2 [INFO] tweaked toml for crates.io crate victorem 0.8.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.8.2 (latest: v0.13.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cc1f758d8b0d43246a0517a9a2f191d99b252881b25dcb839c38bf108048219c [INFO] running `Command { std: "docker" "start" "-a" "cc1f758d8b0d43246a0517a9a2f191d99b252881b25dcb839c38bf108048219c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cc1f758d8b0d43246a0517a9a2f191d99b252881b25dcb839c38bf108048219c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc1f758d8b0d43246a0517a9a2f191d99b252881b25dcb839c38bf108048219c", kill_on_drop: false }` [INFO] [stdout] cc1f758d8b0d43246a0517a9a2f191d99b252881b25dcb839c38bf108048219c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 75cc90881c570fb69cb7f975949bbda2d168bda0d86ad7d19e24fd9bcb97efc9 [INFO] running `Command { std: "docker" "start" "-a" "75cc90881c570fb69cb7f975949bbda2d168bda0d86ad7d19e24fd9bcb97efc9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking victorem v0.8.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/business_logic_layer/key.rs:59:36 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn is_valid(&self, value: &IWithKey) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 59 | pub fn is_valid(&self, value: &dyn IWithKey) -> bool { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/business_logic_layer/key.rs:59:36 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn is_valid(&self, value: &IWithKey) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 59 | pub fn is_valid(&self, value: &dyn IWithKey) -> bool { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `command2` [INFO] [stdout] --> src/business_logic_layer/mod.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | let command2 = client.send(vec![2]); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_command2` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> src/business_logic_layer/mod.rs:204:14 [INFO] [stdout] | [INFO] [stdout] 204 | let (b, commands) = client.recv(state1).unwrap(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `command2` [INFO] [stdout] --> src/business_logic_layer/mod.rs:220:13 [INFO] [stdout] | [INFO] [stdout] 220 | let command2 = client.send(vec![2]); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_command2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r1` [INFO] [stdout] --> src/business_logic_layer/mod.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | let r1 = server.recv(command1); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_r1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set` is never used [INFO] [stdout] --> src/business_logic_layer/version.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait IWithVersion { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] 6 | fn get(&self) -> u8; [INFO] [stdout] 7 | fn set(&mut self, version: u8); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set` is never used [INFO] [stdout] --> src/business_logic_layer/protocol.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait IWithProtocol { [INFO] [stdout] | ------------- method in this trait [INFO] [stdout] 6 | fn get(&self) -> u8; [INFO] [stdout] 7 | fn set(&mut self, id: u8); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set` is never used [INFO] [stdout] --> src/business_logic_layer/id.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait IWithId { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 5 | fn get(&self) -> u32; [INFO] [stdout] 6 | fn set(&mut self, id: u32); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set` is never used [INFO] [stdout] --> src/business_logic_layer/key.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait IWithKey { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] 5 | fn get(&self) -> Duration; [INFO] [stdout] 6 | fn set(&mut self, key: Duration); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn new(port: u16, server_address: impl ToSocketAddrs) -> Result { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Ok(ClientSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 84 | | socket: TypedClientSocket::new(port, server_address)?, [INFO] [stdout] 85 | | client: bll::Client::new(), [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set` is never used [INFO] [stdout] --> src/business_logic_layer/version.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait IWithVersion { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] 6 | fn get(&self) -> u8; [INFO] [stdout] 7 | fn set(&mut self, version: u8); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set` is never used [INFO] [stdout] --> src/business_logic_layer/protocol.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait IWithProtocol { [INFO] [stdout] | ------------- method in this trait [INFO] [stdout] 6 | fn get(&self) -> u8; [INFO] [stdout] 7 | fn set(&mut self, id: u8); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set` is never used [INFO] [stdout] --> src/business_logic_layer/id.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait IWithId { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 5 | fn get(&self) -> u32; [INFO] [stdout] 6 | fn set(&mut self, id: u32); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:148:46 [INFO] [stdout] | [INFO] [stdout] 148 | .map_err(|e| exceptions.push((*a, e))); [INFO] [stdout] | - ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set` is never used [INFO] [stdout] --> src/business_logic_layer/key.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait IWithKey { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] 5 | fn get(&self) -> Duration; [INFO] [stdout] 6 | fn set(&mut self, key: Duration); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 168 | pub fn new(game: T, port: u16) -> Result, Exception> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | Ok(GameServer { [INFO] [stdout] | ____________^ [INFO] [stdout] 170 | | game, [INFO] [stdout] 171 | | socket: ServerSocket::new(port)?, [INFO] [stdout] 172 | | is_running: true, [INFO] [stdout] ... | [INFO] [stdout] 175 | | after_draw_elapsed_timer: bll::timer::ElapsedTimer::new(), [INFO] [stdout] 176 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:201:46 [INFO] [stdout] | [INFO] [stdout] 199 | .map(|ex| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | self.game [INFO] [stdout] 201 | .handle_server_event(ServerEvent::ExceptionOnSend(ex)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn new(port: u16, server_address: impl ToSocketAddrs) -> Result { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Ok(ClientSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 84 | | socket: TypedClientSocket::new(port, server_address)?, [INFO] [stdout] 85 | | client: bll::Client::new(), [INFO] [stdout] 86 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:148:46 [INFO] [stdout] | [INFO] [stdout] 148 | .map_err(|e| exceptions.push((*a, e))); [INFO] [stdout] | - ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_access_layer.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 16 | fn new(port: u16, server_address: impl ToSocketAddrs) -> Result { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let local_address = format!("0.0.0.0:{}", port); [INFO] [stdout] 18 | let socket = UdpSocket::bind(&local_address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Ok(ClientSocket { socket }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_access_layer.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 38 | let socket = UdpSocket::bind(&local_address.trim())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | socket.set_nonblocking(true)?; [INFO] [stdout] 40 | Ok(ServerSocket { socket }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 168 | pub fn new(game: T, port: u16) -> Result, Exception> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | Ok(GameServer { [INFO] [stdout] | ____________^ [INFO] [stdout] 170 | | game, [INFO] [stdout] 171 | | socket: ServerSocket::new(port)?, [INFO] [stdout] 172 | | is_running: true, [INFO] [stdout] ... | [INFO] [stdout] 175 | | after_draw_elapsed_timer: bll::timer::ElapsedTimer::new(), [INFO] [stdout] 176 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:201:46 [INFO] [stdout] | [INFO] [stdout] 199 | .map(|ex| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | self.game [INFO] [stdout] 201 | .handle_server_event(ServerEvent::ExceptionOnSend(ex)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_access_layer.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 61 | let socket = ServerSocket::new(port)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let buffer = vec![0u8; MAX_DATAGRAM_SIZE]; [INFO] [stdout] 63 | Ok(BufferedServerSocket { socket, buffer }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_access_layer.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 82 | fn new(port: u16, server_address: impl ToSocketAddrs) -> Result { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let socket = ClientSocket::new(port, server_address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let buffer = vec![0u8; MAX_DATAGRAM_SIZE]; [INFO] [stdout] 85 | Ok(BufferedClientSocket { socket, buffer }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_access_layer.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 104 | let socket = BufferedServerSocket::new(port)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Ok(TypedServerSocket { socket }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_access_layer.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn new(port: u16, server_address: impl ToSocketAddrs) -> Result { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let socket = BufferedClientSocket::new(port, server_address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | Ok(TypedClientSocket { socket }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_access_layer.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 16 | fn new(port: u16, server_address: impl ToSocketAddrs) -> Result { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let local_address = format!("0.0.0.0:{}", port); [INFO] [stdout] 18 | let socket = UdpSocket::bind(&local_address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Ok(ClientSocket { socket }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_access_layer.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 38 | let socket = UdpSocket::bind(&local_address.trim())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | socket.set_nonblocking(true)?; [INFO] [stdout] 40 | Ok(ServerSocket { socket }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_access_layer.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 61 | let socket = ServerSocket::new(port)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let buffer = vec![0u8; MAX_DATAGRAM_SIZE]; [INFO] [stdout] 63 | Ok(BufferedServerSocket { socket, buffer }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_access_layer.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 82 | fn new(port: u16, server_address: impl ToSocketAddrs) -> Result { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let socket = ClientSocket::new(port, server_address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let buffer = vec![0u8; MAX_DATAGRAM_SIZE]; [INFO] [stdout] 85 | Ok(BufferedClientSocket { socket, buffer }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_access_layer.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 104 | let socket = BufferedServerSocket::new(port)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Ok(TypedServerSocket { socket }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_access_layer.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn new(port: u16, server_address: impl ToSocketAddrs) -> Result { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let socket = BufferedClientSocket::new(port, server_address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | Ok(TypedClientSocket { socket }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `victorem` (lib test) due to 11 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `victorem` (lib) due to 11 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "75cc90881c570fb69cb7f975949bbda2d168bda0d86ad7d19e24fd9bcb97efc9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "75cc90881c570fb69cb7f975949bbda2d168bda0d86ad7d19e24fd9bcb97efc9", kill_on_drop: false }` [INFO] [stdout] 75cc90881c570fb69cb7f975949bbda2d168bda0d86ad7d19e24fd9bcb97efc9