[INFO] crate vfs-zip 0.2.1 is already in cache [INFO] checking vfs-zip-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vfs-zip 0.2.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate vfs-zip 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vfs-zip 0.2.1 [INFO] finished tweaking crates.io crate vfs-zip 0.2.1 [INFO] tweaked toml for crates.io crate vfs-zip 0.2.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate vfs-zip 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c6575354d08907f9f01114011879027747bbc8e9855e06d0702e38df2401fef2 [INFO] running `Command { std: "docker" "start" "-a" "c6575354d08907f9f01114011879027747bbc8e9855e06d0702e38df2401fef2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c6575354d08907f9f01114011879027747bbc8e9855e06d0702e38df2401fef2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6575354d08907f9f01114011879027747bbc8e9855e06d0702e38df2401fef2", kill_on_drop: false }` [INFO] [stdout] c6575354d08907f9f01114011879027747bbc8e9855e06d0702e38df2401fef2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e972ca544410f15a89bcfb76ab42068e5254500759ad0e26f38ba79c730a7d89 [INFO] running `Command { std: "docker" "start" "-a" "e972ca544410f15a89bcfb76ab42068e5254500759ad0e26f38ba79c730a7d89", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.20 [INFO] [stderr] Compiling libc v0.2.76 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling pkg-config v0.3.18 [INFO] [stderr] Compiling syn v1.0.40 [INFO] [stderr] Compiling cc v1.0.59 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking podio v0.1.7 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling bzip2-sys v0.1.9+1.0.8 [INFO] [stderr] Checking flate2 v1.0.14 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking zip v0.5.3 [INFO] [stderr] Compiling thiserror-impl v1.0.20 [INFO] [stderr] Checking thiserror v1.0.20 [INFO] [stderr] Checking vfs v0.4.0 [INFO] [stderr] Checking vfs-zip v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `external_doc` [INFO] [stdout] --> src/lib.rs:1:13 [INFO] [stdout] | [INFO] [stdout] 1 | #![cfg_attr(external_doc, feature(external_doc))] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(external_doc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(external_doc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `external_doc` [INFO] [stdout] --> src/lib.rs:2:13 [INFO] [stdout] | [INFO] [stdout] 2 | #![cfg_attr(external_doc, doc(include = "../Readme.md"))] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(external_doc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(external_doc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `external_doc` [INFO] [stdout] --> src/lib.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | #![cfg_attr(external_doc, warn(missing_docs))] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(external_doc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(external_doc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `external_doc` [INFO] [stdout] --> src/lib.rs:1:13 [INFO] [stdout] | [INFO] [stdout] 1 | #![cfg_attr(external_doc, feature(external_doc))] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(external_doc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(external_doc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `external_doc` [INFO] [stdout] --> src/lib.rs:2:13 [INFO] [stdout] | [INFO] [stdout] 2 | #![cfg_attr(external_doc, doc(include = "../Readme.md"))] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(external_doc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(external_doc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `external_doc` [INFO] [stdout] --> src/lib.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | #![cfg_attr(external_doc, warn(missing_docs))] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(external_doc)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(external_doc)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write/_write.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 41 | fn new_impl(io: IO, weak: bool) -> Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 43 | | imp: Arc::new(Mutex::new(Imp { [INFO] [stdout] 44 | | writer: zip::write::ZipWriter::new(io), [INFO] [stdout] 45 | | dirs: Default::default(), [INFO] [stdout] 46 | | })), [INFO] [stdout] 47 | | weak, [INFO] [stdout] 48 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write/vfs04.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | Ok(Box::new(ZipFileWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | path: path.into(), [INFO] [stdout] 63 | | buffer: Cursor::new(Vec::new()), [INFO] [stdout] 64 | | imp: match self.weak { [INFO] [stdout] ... | [INFO] [stdout] 67 | | } [INFO] [stdout] 68 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vfs-zip` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write/_write.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 41 | fn new_impl(io: IO, weak: bool) -> Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 43 | | imp: Arc::new(Mutex::new(Imp { [INFO] [stdout] 44 | | writer: zip::write::ZipWriter::new(io), [INFO] [stdout] 45 | | dirs: Default::default(), [INFO] [stdout] 46 | | })), [INFO] [stdout] 47 | | weak, [INFO] [stdout] 48 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write/vfs04.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | Ok(Box::new(ZipFileWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | path: path.into(), [INFO] [stdout] 63 | | buffer: Cursor::new(Vec::new()), [INFO] [stdout] 64 | | imp: match self.weak { [INFO] [stdout] ... | [INFO] [stdout] 67 | | } [INFO] [stdout] 68 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vfs-zip` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e972ca544410f15a89bcfb76ab42068e5254500759ad0e26f38ba79c730a7d89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e972ca544410f15a89bcfb76ab42068e5254500759ad0e26f38ba79c730a7d89", kill_on_drop: false }` [INFO] [stdout] e972ca544410f15a89bcfb76ab42068e5254500759ad0e26f38ba79c730a7d89