[INFO] fetching crate vexilla_client 1.0.0... [INFO] checking vexilla_client-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vexilla_client 1.0.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate vexilla_client 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vexilla_client 1.0.0 [INFO] finished tweaking crates.io crate vexilla_client 1.0.0 [INFO] tweaked toml for crates.io crate vexilla_client 1.0.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 163 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding chrono-tz v0.8.6 (latest: v0.9.0) [INFO] [stderr] Adding chrono-tz-build v0.2.1 (latest: v0.3.0) [INFO] [stderr] Adding convert_case v0.3.2 (latest: v0.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding h2 v0.2.7 (latest: v0.4.6) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.3.1 (latest: v1.0.1) [INFO] [stderr] Adding httpdate v0.3.2 (latest: v1.0.3) [INFO] [stderr] Adding hyper v0.13.10 (latest: v1.4.1) [INFO] [stderr] Adding hyper-tls v0.4.3 (latest: v0.6.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itoa v0.4.8 (latest: v1.0.11) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding miow v0.3.7 (latest: v0.6.0) [INFO] [stderr] Adding pin-project-lite v0.1.12 (latest: v0.2.14) [INFO] [stderr] Adding reqwest v0.10.10 (latest: v0.12.7) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding socket2 v0.3.19 (latest: v0.5.7) [INFO] [stderr] Adding strum v0.25.0 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.25.3 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tokio v0.2.25 (latest: v1.40.0) [INFO] [stderr] Adding tokio-macros v0.2.6 (latest: v2.4.0) [INFO] [stderr] Adding tokio-util v0.3.1 (latest: v0.7.11) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winreg v0.7.0 (latest: v0.52.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 87c1848f6d445c29f427353d17c564c540c626c102e717f87b66e0660463e921 [INFO] running `Command { std: "docker" "start" "-a" "87c1848f6d445c29f427353d17c564c540c626c102e717f87b66e0660463e921", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "87c1848f6d445c29f427353d17c564c540c626c102e717f87b66e0660463e921", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87c1848f6d445c29f427353d17c564c540c626c102e717f87b66e0660463e921", kill_on_drop: false }` [INFO] [stdout] 87c1848f6d445c29f427353d17c564c540c626c102e717f87b66e0660463e921 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 066fe7b64f6637b77d98be25b28fe62e4a8e223e700b7ad28aab8a7716671ff7 [INFO] running `Command { std: "docker" "start" "-a" "066fe7b64f6637b77d98be25b28fe62e4a8e223e700b7ad28aab8a7716671ff7", kill_on_drop: false }` [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking convert_case v0.3.2 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling tokio-macros v0.2.6 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking tokio v0.2.25 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Compiling chrono-tz-build v0.2.1 [INFO] [stderr] Compiling chrono-tz v0.8.6 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Checking openssl v0.10.66 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking tokio-util v0.3.1 [INFO] [stderr] Checking h2 v0.2.7 [INFO] [stderr] Checking native-tls v0.2.12 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking tokio-tls v0.3.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking hyper v0.13.10 [INFO] [stderr] Checking hyper-tls v0.4.3 [INFO] [stderr] Checking reqwest v0.10.10 [INFO] [stderr] Checking vexilla_client v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | _ => Err(VexillaError::InvalidShouldFeatureType(feature.value_type())), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/lib.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 153 | SelectiveFeature::String { value, .. } => { [INFO] [stdout] | -------------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 156 | SelectiveFeature::Number(feature) => match feature { [INFO] [stdout] | --------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 172 | _ => Err(VexillaError::InvalidShouldFeatureType(feature.value_type())), [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `show_logs` is never read [INFO] [stdout] --> src/lib.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct VexillaClient { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 29 | show_logs: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VexillaClient` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `toggle`, `gradual`, `selective`, and `value` are never read [INFO] [stdout] --> src/types.rs:331:9 [INFO] [stdout] | [INFO] [stdout] 330 | pub struct DefaultFeatureValues { [INFO] [stdout] | -------------------- fields in this struct [INFO] [stdout] 331 | pub toggle: ToggleFeature, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 332 | pub gradual: GradualFeature, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 333 | pub selective: SelectiveFeature, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 334 | pub value: ValueFeature, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DefaultFeatureValues` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | _ => Err(VexillaError::InvalidShouldFeatureType(feature.value_type())), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/lib.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 153 | SelectiveFeature::String { value, .. } => { [INFO] [stdout] | -------------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 156 | SelectiveFeature::Number(feature) => match feature { [INFO] [stdout] | --------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 172 | _ => Err(VexillaError::InvalidShouldFeatureType(feature.value_type())), [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `show_logs` is never read [INFO] [stdout] --> src/lib.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct VexillaClient { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 29 | show_logs: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VexillaClient` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `toggle`, `gradual`, `selective`, and `value` are never read [INFO] [stdout] --> src/types.rs:331:9 [INFO] [stdout] | [INFO] [stdout] 330 | pub struct DefaultFeatureValues { [INFO] [stdout] | -------------------- fields in this struct [INFO] [stdout] 331 | pub toggle: ToggleFeature, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 332 | pub gradual: GradualFeature, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 333 | pub selective: SelectiveFeature, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 334 | pub value: ValueFeature, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DefaultFeatureValues` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:473:36 [INFO] [stdout] | [INFO] [stdout] 473 | .get_manifest(|url| Ok(reqwest::blocking::get(url).unwrap().text().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:479:37 [INFO] [stdout] | [INFO] [stdout] 479 | .sync_manifest(|url| Ok(reqwest::blocking::get(url).unwrap().text().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vexilla_client` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "066fe7b64f6637b77d98be25b28fe62e4a8e223e700b7ad28aab8a7716671ff7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "066fe7b64f6637b77d98be25b28fe62e4a8e223e700b7ad28aab8a7716671ff7", kill_on_drop: false }` [INFO] [stdout] 066fe7b64f6637b77d98be25b28fe62e4a8e223e700b7ad28aab8a7716671ff7