[INFO] fetching crate vexide-async 0.1.2... [INFO] checking vexide-async-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vexide-async 0.1.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate vexide-async 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vexide-async 0.1.2 [INFO] finished tweaking crates.io crate vexide-async 0.1.2 [INFO] tweaked toml for crates.io crate vexide-async 0.1.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 38 packages to latest compatible versions [INFO] [stderr] Adding vex-sdk v0.17.0 (latest: v0.19.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cd006825feaef419ee56ef0077ac0f794ab53e58dd6a704099105db1b6bd2fdf [INFO] running `Command { std: "docker" "start" "-a" "cd006825feaef419ee56ef0077ac0f794ab53e58dd6a704099105db1b6bd2fdf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd006825feaef419ee56ef0077ac0f794ab53e58dd6a704099105db1b6bd2fdf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd006825feaef419ee56ef0077ac0f794ab53e58dd6a704099105db1b6bd2fdf", kill_on_drop: false }` [INFO] [stdout] cd006825feaef419ee56ef0077ac0f794ab53e58dd6a704099105db1b6bd2fdf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8290f405c52756a59f2022e64ebbc7dbaea3eafe9d948f59c68f53a0fdc261a6 [INFO] running `Command { std: "docker" "start" "-a" "8290f405c52756a59f2022e64ebbc7dbaea3eafe9d948f59c68f53a0fdc261a6", kill_on_drop: false }` [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking vex-sdk v0.17.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking critical-section v1.1.3 [INFO] [stderr] Checking replace_with v0.1.7 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking talc v4.4.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking no_std_io v0.6.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling snafu-derive v0.8.4 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking snafu v0.8.4 [INFO] [stderr] Checking vexide-core v0.3.0 [INFO] [stderr] Checking vexide-async v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn block_on(future: F) -> F::Output { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let task = spawn(future); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | EXECUTOR.block_on(task) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:34:32 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn spawn(&self, future: impl Future + 'static) -> Task { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | critical_section::with(|_| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 35 | | // SAFETY: `runnable` will never be moved off this thread or shared with another thread because of the `!Send + !Sync` bounds... [INFO] [stdout] 36 | | // Both `future` and `schedule` are `'static` so they cannot be used after being freed. [INFO] [stdout] 37 | | // TODO: Make sure that the waker can never be sent off the thread. [INFO] [stdout] ... | [INFO] [stdout] 46 | | task [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 39 | async_task::spawn_unchecked(future, |runnable| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | self.queue.borrow_mut().push_back(runnable) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn spawn(future: impl Future + 'static) -> Task { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | EXECUTOR.spawn(future) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time.rs:33:67 [INFO] [stdout] | [INFO] [stdout] 33 | EXECUTOR.with_reactor(|reactor| reactor.sleepers.push(cx.waker().clone(), self.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vexide-async` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn block_on(future: F) -> F::Output { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let task = spawn(future); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | EXECUTOR.block_on(task) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:34:32 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn spawn(&self, future: impl Future + 'static) -> Task { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | critical_section::with(|_| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 35 | | // SAFETY: `runnable` will never be moved off this thread or shared with another thread because of the `!Send + !Sync` bounds... [INFO] [stdout] 36 | | // Both `future` and `schedule` are `'static` so they cannot be used after being freed. [INFO] [stdout] 37 | | // TODO: Make sure that the waker can never be sent off the thread. [INFO] [stdout] ... | [INFO] [stdout] 46 | | task [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 39 | async_task::spawn_unchecked(future, |runnable| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | self.queue.borrow_mut().push_back(runnable) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn spawn(future: impl Future + 'static) -> Task { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | EXECUTOR.spawn(future) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time.rs:33:67 [INFO] [stdout] | [INFO] [stdout] 33 | EXECUTOR.with_reactor(|reactor| reactor.sleepers.push(cx.waker().clone(), self.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vexide-async` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "8290f405c52756a59f2022e64ebbc7dbaea3eafe9d948f59c68f53a0fdc261a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8290f405c52756a59f2022e64ebbc7dbaea3eafe9d948f59c68f53a0fdc261a6", kill_on_drop: false }` [INFO] [stdout] 8290f405c52756a59f2022e64ebbc7dbaea3eafe9d948f59c68f53a0fdc261a6