[INFO] fetching crate versyon 0.0.14... [INFO] checking versyon-0.0.14 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate versyon 0.0.14 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate versyon 0.0.14 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate versyon 0.0.14 [INFO] finished tweaking crates.io crate versyon 0.0.14 [INFO] tweaked toml for crates.io crate versyon 0.0.14 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate versyon 0.0.14 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7e5268005c6cec5a06e94ab2c1f4a2d45220e20886f0418cc6f55d7b855595bb [INFO] running `Command { std: "docker" "start" "-a" "7e5268005c6cec5a06e94ab2c1f4a2d45220e20886f0418cc6f55d7b855595bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7e5268005c6cec5a06e94ab2c1f4a2d45220e20886f0418cc6f55d7b855595bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e5268005c6cec5a06e94ab2c1f4a2d45220e20886f0418cc6f55d7b855595bb", kill_on_drop: false }` [INFO] [stdout] 7e5268005c6cec5a06e94ab2c1f4a2d45220e20886f0418cc6f55d7b855595bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6fbe9a25f82922cce58ac2e80da9967ff8e8f2e73926b614b0eb5800132b1bf0 [INFO] running `Command { std: "docker" "start" "-a" "6fbe9a25f82922cce58ac2e80da9967ff8e8f2e73926b614b0eb5800132b1bf0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.131 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Checking os_str_bytes v6.2.0 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling openssl-sys v0.9.75 [INFO] [stderr] Compiling libz-sys v1.1.8 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling libgit2-sys v0.14.0+1.5.0 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Compiling clap_derive v3.2.17 [INFO] [stderr] Checking clap v3.2.17 [INFO] [stderr] Checking git2 v0.15.0 [INFO] [stderr] Checking versyon v0.0.14 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:169:3 [INFO] [stdout] | [INFO] [stdout] 167 | fn search_file_names(folder: &str, pattern_checker: F) -> Vec [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | where F: Fn(&DirEntry) -> bool { [INFO] [stdout] 169 | / WalkDir::new(folder) [INFO] [stdout] 170 | | .into_iter() [INFO] [stdout] 171 | | .filter_entry(|e| !is_target_folder(e)) [INFO] [stdout] 172 | | .filter_map(|e| e.ok()) [INFO] [stdout] 173 | | .filter(|e| pattern_checker(e)) [INFO] [stdout] 174 | | .map(|e| e.into_path()) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:181:8 [INFO] [stdout] | [INFO] [stdout] 178 | fn read_lines

(filename: P) -> Option> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | where P: AsRef, { [INFO] [stdout] 180 | let file = File::open(filename).ok()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | Some(io::BufReader::new(file).lines().filter_map(|line| line.ok()).collect::>()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:237:3 [INFO] [stdout] | [INFO] [stdout] 236 | let obj = repo.head()?.resolve()?.peel(ObjectType::Commit)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | obj.into_commit().map_err(|_| git2::Error::from_str("Couldn't find commit")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:272:32 [INFO] [stdout] | [INFO] [stdout] 272 | message.clone(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `versyon` (bin "versyon" test) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:169:3 [INFO] [stdout] | [INFO] [stdout] 167 | fn search_file_names(folder: &str, pattern_checker: F) -> Vec [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | where F: Fn(&DirEntry) -> bool { [INFO] [stdout] 169 | / WalkDir::new(folder) [INFO] [stdout] 170 | | .into_iter() [INFO] [stdout] 171 | | .filter_entry(|e| !is_target_folder(e)) [INFO] [stdout] 172 | | .filter_map(|e| e.ok()) [INFO] [stdout] 173 | | .filter(|e| pattern_checker(e)) [INFO] [stdout] 174 | | .map(|e| e.into_path()) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:181:8 [INFO] [stdout] | [INFO] [stdout] 178 | fn read_lines

(filename: P) -> Option> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | where P: AsRef, { [INFO] [stdout] 180 | let file = File::open(filename).ok()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | Some(io::BufReader::new(file).lines().filter_map(|line| line.ok()).collect::>()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:237:3 [INFO] [stdout] | [INFO] [stdout] 236 | let obj = repo.head()?.resolve()?.peel(ObjectType::Commit)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | obj.into_commit().map_err(|_| git2::Error::from_str("Couldn't find commit")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:272:32 [INFO] [stdout] | [INFO] [stdout] 272 | message.clone(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `versyon` (bin "versyon") due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "6fbe9a25f82922cce58ac2e80da9967ff8e8f2e73926b614b0eb5800132b1bf0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6fbe9a25f82922cce58ac2e80da9967ff8e8f2e73926b614b0eb5800132b1bf0", kill_on_drop: false }` [INFO] [stdout] 6fbe9a25f82922cce58ac2e80da9967ff8e8f2e73926b614b0eb5800132b1bf0