[INFO] fetching crate version-control-clean-check 0.1.2... [INFO] checking version-control-clean-check-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate version-control-clean-check 0.1.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate version-control-clean-check 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate version-control-clean-check 0.1.2 [INFO] finished tweaking crates.io crate version-control-clean-check 0.1.2 [INFO] tweaked toml for crates.io crate version-control-clean-check 0.1.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 124 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding git2 v0.18.3 (latest: v0.19.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding libgit2-sys v0.16.2+1.7.2 (latest: v0.17.0+1.8.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding rstest v0.19.0 (latest: v0.22.0) [INFO] [stderr] Adding rstest_macros v0.19.0 (latest: v0.22.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7399ae3198bb66f5b73ec2b76fc85f62cc76800b2da615389075821ce1651ae0 [INFO] running `Command { std: "docker" "start" "-a" "7399ae3198bb66f5b73ec2b76fc85f62cc76800b2da615389075821ce1651ae0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7399ae3198bb66f5b73ec2b76fc85f62cc76800b2da615389075821ce1651ae0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7399ae3198bb66f5b73ec2b76fc85f62cc76800b2da615389075821ce1651ae0", kill_on_drop: false }` [INFO] [stdout] 7399ae3198bb66f5b73ec2b76fc85f62cc76800b2da615389075821ce1651ae0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c726727ba24dfa3533e741df2b5e6fc489fa350650a7204b6a7e7ac346a1627 [INFO] running `Command { std: "docker" "start" "-a" "1c726727ba24dfa3533e741df2b5e6fc489fa350650a7204b6a7e7ac346a1627", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling rstest_macros v0.19.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking cargo-util v0.2.13 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking rstest v0.19.0 [INFO] [stderr] Checking git2 v0.18.3 [INFO] [stderr] Checking version-control-clean-check v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/utils/mod.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 40 | fn try_from(value: VCSResult) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok(Self(value.unwrap_err())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/utils/git_commands.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn init>(path: P) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | Ok(git2::Repository::init(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `version-control-clean-check` (test "checks") due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "1c726727ba24dfa3533e741df2b5e6fc489fa350650a7204b6a7e7ac346a1627", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c726727ba24dfa3533e741df2b5e6fc489fa350650a7204b6a7e7ac346a1627", kill_on_drop: false }` [INFO] [stdout] 1c726727ba24dfa3533e741df2b5e6fc489fa350650a7204b6a7e7ac346a1627