[INFO] fetching crate venial 0.6.0... [INFO] checking venial-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate venial 0.6.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate venial 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate venial 0.6.0 [INFO] finished tweaking crates.io crate venial 0.6.0 [INFO] tweaked toml for crates.io crate venial 0.6.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 29 packages to latest compatible versions [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 133479acefa46535c641313b2387df6d52914e551eb1f7c2f766e66da4b7419f [INFO] running `Command { std: "docker" "start" "-a" "133479acefa46535c641313b2387df6d52914e551eb1f7c2f766e66da4b7419f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "133479acefa46535c641313b2387df6d52914e551eb1f7c2f766e66da4b7419f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "133479acefa46535c641313b2387df6d52914e551eb1f7c2f766e66da4b7419f", kill_on_drop: false }` [INFO] [stdout] 133479acefa46535c641313b2387df6d52914e551eb1f7c2f766e66da4b7419f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d67359eafd4be6e8f9b0acec2b6e7bfd20676e7b84cc93fc3f36c2300e38d1de [INFO] running `Command { std: "docker" "start" "-a" "d67359eafd4be6e8f9b0acec2b6e7bfd20676e7b84cc93fc3f36c2300e38d1de", kill_on_drop: false }` [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking similar-asserts v1.5.0 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking venial v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_extern.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | attributes: Vec, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | vis_marker: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | ) -> ExternCrate { [INFO] [stdout] 11 | consume_extern_crate(tokens, attributes, vis_marker).expect("cannot parse extern crate") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_extern.rs:41:10 [INFO] [stdout] | [INFO] [stdout] 16 | attributes: Vec, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | vis_marker: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | ) -> Option { [INFO] [stdout] 19 | let tk_extern = consume_ident(tokens, "extern")?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let tk_crate = consume_ident(tokens, "crate")?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | let name = parse_any_ident(tokens, "extern crate"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let tk_as = consume_ident(tokens, "as"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | let alias; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let tk_underscore; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | Some(ExternCrate { [INFO] [stdout] | __________^ [INFO] [stdout] 42 | | attributes, [INFO] [stdout] 43 | | vis_marker, [INFO] [stdout] 44 | | tk_extern, [INFO] [stdout] ... | [INFO] [stdout] 50 | | tk_semicolon, [INFO] [stdout] 51 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_extern.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 56 | attributes: Vec, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | vis_marker: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | ) -> ExternBlock { [INFO] [stdout] 59 | consume_extern_block(tokens, attributes, vis_marker).expect("cannot parse extern block") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_extern.rs:89:10 [INFO] [stdout] | [INFO] [stdout] 64 | attributes: Vec, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | vis_marker: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | ) -> Option { [INFO] [stdout] 67 | let tk_unsafe = consume_ident(tokens, "unsafe"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let tk_extern = consume_ident(tokens, "extern")?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let (tk_braces, inner_attributes, body_items) = match tokens.next() { [INFO] [stdout] | ---------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Some(TokenTree::Group(group)) if group.delimiter() == Delimiter::Brace => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Some(ExternBlock { [INFO] [stdout] | __________^ [INFO] [stdout] 90 | | attributes, [INFO] [stdout] 91 | | vis_marker, [INFO] [stdout] 92 | | tk_unsafe, [INFO] [stdout] ... | [INFO] [stdout] 97 | | body_items, [INFO] [stdout] 98 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_fn.rs:242:8 [INFO] [stdout] | [INFO] [stdout] 150 | attributes: Vec, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | vis_marker: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let before_start = tokens.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let qualifiers = consume_fn_qualifiers(tokens); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let next_token = tokens.next(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | let tk_fn_keyword = match &next_token { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | let fn_name = consume_item_name(tokens); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | let generic_params = consume_generic_params(tokens); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | [INFO] [stdout] 219 | let (params, tk_params_parens) = match tokens.next().unwrap() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | TokenTree::Group(group) if group.delimiter() == Delimiter::Parenthesis => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | let (tk_return_arrow, return_ty) = if let Some((arrow, ty)) = consume_fn_return(tokens) { [INFO] [stdout] | --------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let where_clause = consume_where_clause(tokens); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | [INFO] [stdout] 234 | let (function_body, tk_semicolon) = match &tokens.next().unwrap() { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | Ok(Function { [INFO] [stdout] | ________^ [INFO] [stdout] 243 | | attributes, [INFO] [stdout] 244 | | vis_marker, [INFO] [stdout] 245 | | qualifiers, [INFO] [stdout] ... | [INFO] [stdout] 255 | | body: function_body, [INFO] [stdout] 256 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_fn.rs:263:11 [INFO] [stdout] | [INFO] [stdout] 259 | pub(crate) fn consume_macro(tokens: &mut TokenIter, attributes: Vec) -> Option { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | // TODO consider multiple-lookahead instead of potentially cloning many tokens [INFO] [stdout] 261 | let before_start = tokens.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | [INFO] [stdout] 263 | match consume_macro_inner(tokens, attributes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_fn.rs:292:10 [INFO] [stdout] | [INFO] [stdout] 273 | fn consume_macro_inner(tokens: &mut TokenIter, attributes: Vec) -> Option { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | let name = consume_any_ident(tokens)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | let tk_bang = consume_punct(tokens, '!')?; [INFO] [stdout] 276 | let tk_declared_name = consume_any_ident(tokens); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | [INFO] [stdout] 278 | let (is_paren, macro_body) = match tokens.next().expect("unexpected end of macro") { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | TokenTree::Group(group) if group.delimiter() == Delimiter::Parenthesis => (true, group), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | TokenTree::Group(group) if group.delimiter() == Delimiter::Brace => (false, group), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 284 | let inner_tokens = macro_body.stream().into_iter().collect(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | Some(Macro { [INFO] [stdout] | __________^ [INFO] [stdout] 293 | | attributes, [INFO] [stdout] 294 | | name, [INFO] [stdout] 295 | | tk_bang, [INFO] [stdout] ... | [INFO] [stdout] 299 | | tk_semicolon, [INFO] [stdout] 300 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_impl.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 21 | attributes: Vec, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | vis_marker: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | ) -> Constant { [INFO] [stdout] 24 | let (tk_const_or_static, is_const) = match tokens.next() { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Some(TokenTree::Ident(ident)) if ident == "const" => (ident, true), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Some(TokenTree::Ident(ident)) if ident == "static" => (ident, false), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let tk_mut = match tokens.peek() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let name = parse_any_ident(tokens, "const/static"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let ty_tokens = consume_stuff_until( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let value_tokens = consume_stuff_until( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let initializer = if value_tokens.is_empty() { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | ty: TypeExpr { tokens: ty_tokens }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_impl.rs:109:10 [INFO] [stdout] | [INFO] [stdout] 80 | attributes: Vec, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | vis_marker: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let tk_type = parse_ident(tokens, "type", context); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let name = parse_any_ident(tokens, context); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | [INFO] [stdout] 87 | let bound = consume_bound(tokens, |token| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let initializer_ty = if tk_equals.is_some() { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | let ty_tokens = consume_stuff_until( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | Some(TypeAlias { [INFO] [stdout] | __________^ [INFO] [stdout] 110 | | attributes, [INFO] [stdout] 111 | | vis_marker, [INFO] [stdout] 112 | | tk_type, [INFO] [stdout] ... | [INFO] [stdout] 117 | | tk_semicolon, [INFO] [stdout] 118 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_mod.rs:90:22 [INFO] [stdout] | [INFO] [stdout] 70 | attributes: Vec, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | vis_marker: Option, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | ) -> UseDeclaration { [INFO] [stdout] 73 | let tk_use = parse_ident(tokens, "use", "use declaration"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | [INFO] [stdout] 75 | let import_tree = consume_stuff_until( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | import_tree: TypeExpr { [INFO] [stdout] | ______________________^ [INFO] [stdout] 91 | | tokens: import_tree, [INFO] [stdout] 92 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_type.rs:88:10 [INFO] [stdout] | [INFO] [stdout] 45 | let mut generic_params = Punctuated::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Some(GenericParamList { [INFO] [stdout] | __________^ [INFO] [stdout] 89 | | tk_l_bracket: gt, [INFO] [stdout] 90 | | params: generic_params, [INFO] [stdout] 91 | | tk_r_bracket: lt, [INFO] [stdout] 92 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_type.rs:125:15 [INFO] [stdout] | [INFO] [stdout] 95 | fn parse_generic_arg(tokens: Vec) -> GenericArg { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | // Note: method not called if tokens is empty [INFO] [stdout] 97 | let mut tokens = tokens.into_iter().peekable(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let before_ident = tokens.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | let remaining: Vec = before_ident.collect(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | expr: TypeExpr { tokens: remaining }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_type.rs:207:10 [INFO] [stdout] | [INFO] [stdout] 172 | let before_start = tokens.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let mut generic_args = Punctuated::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Some(GenericArgList { [INFO] [stdout] | __________^ [INFO] [stdout] 208 | | tk_turbofish_colons, [INFO] [stdout] 209 | | tk_l_bracket, [INFO] [stdout] 210 | | args: generic_args, [INFO] [stdout] 211 | | tk_r_bracket, [INFO] [stdout] 212 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_type.rs:274:10 [INFO] [stdout] | [INFO] [stdout] 216 | let where_token = consume_ident(tokens, "where")?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | [INFO] [stdout] 218 | let mut items = Punctuated::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | Some(WhereClause { [INFO] [stdout] | __________^ [INFO] [stdout] 275 | | tk_where: where_token, [INFO] [stdout] 276 | | items, [INFO] [stdout] 277 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_type.rs:317:8 [INFO] [stdout] | [INFO] [stdout] 308 | let value_token = tokens.next().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | Ok(Some(EnumVariantValue { [INFO] [stdout] | ________^ [INFO] [stdout] 318 | | tk_equal, [INFO] [stdout] 319 | | value: value_token, [INFO] [stdout] 320 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_utils.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | let stream = TokenStream::from_iter(slice.iter().cloned()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | stream.into_iter().peekable() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_utils.rs:334:10 [INFO] [stdout] | [INFO] [stdout] 301 | pub(crate) fn consume_path(mut tokens: TokenIter) -> Option { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | let mut segments = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | Some(Path { segments }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/punctuated.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn push(&mut self, value: T, comma: Option) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | self.inner.push((value, comma)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types_edition.rs:327:30 [INFO] [stdout] | [INFO] [stdout] 327 | .map(|field| field.name.clone().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types_edition.rs:585:24 [INFO] [stdout] | [INFO] [stdout] 583 | let lifetime_ident = Ident::new(name, Span::call_site()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 584 | GenericParam { [INFO] [stdout] 585 | tk_prefix: Some(Punct::new('\'', Spacing::Joint).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types_edition.rs:587:20 [INFO] [stdout] | [INFO] [stdout] 583 | let lifetime_ident = Ident::new(name, Span::call_site()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 587 | bound: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types_edition.rs:602:24 [INFO] [stdout] | [INFO] [stdout] 599 | pub fn bounded_lifetime(name: &str, bound: Vec) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 600 | let lifetime_ident = Ident::new(name, Span::call_site()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 601 | GenericParam { [INFO] [stdout] 602 | tk_prefix: Some(Punct::new('\'', Spacing::Alone).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types_edition.rs:604:20 [INFO] [stdout] | [INFO] [stdout] 599 | pub fn bounded_lifetime(name: &str, bound: Vec) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 600 | let lifetime_ident = Ident::new(name, Span::call_site()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 604 | bound: Some(GenericBound { [INFO] [stdout] | ____________________^ [INFO] [stdout] 605 | | tk_colon: Punct::new(':', Spacing::Alone), [INFO] [stdout] 606 | | tokens: bound, [INFO] [stdout] 607 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types_edition.rs:621:24 [INFO] [stdout] | [INFO] [stdout] 619 | let ty_ident = Ident::new(name, Span::call_site()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 620 | GenericParam { [INFO] [stdout] 621 | tk_prefix: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types_edition.rs:623:20 [INFO] [stdout] | [INFO] [stdout] 619 | let ty_ident = Ident::new(name, Span::call_site()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 623 | bound: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types_edition.rs:638:24 [INFO] [stdout] | [INFO] [stdout] 635 | pub fn bounded_ty(name: &str, bound: Vec) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 636 | let ty_ident = Ident::new(name, Span::call_site()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 637 | GenericParam { [INFO] [stdout] 638 | tk_prefix: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types_edition.rs:640:20 [INFO] [stdout] | [INFO] [stdout] 635 | pub fn bounded_ty(name: &str, bound: Vec) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 636 | let ty_ident = Ident::new(name, Span::call_site()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 640 | bound: Some(GenericBound { [INFO] [stdout] | ____________________^ [INFO] [stdout] 641 | | tk_colon: Punct::new(':', Spacing::Alone), [INFO] [stdout] 642 | | tokens: bound, [INFO] [stdout] 643 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types_edition.rs:658:24 [INFO] [stdout] | [INFO] [stdout] 655 | pub fn const_param(name: &str, ty: Vec) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 656 | let lifetime_ident = Ident::new(name, Span::call_site()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 657 | GenericParam { [INFO] [stdout] 658 | tk_prefix: Some(Ident::new("const", Span::call_site()).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types_edition.rs:660:20 [INFO] [stdout] | [INFO] [stdout] 655 | pub fn const_param(name: &str, ty: Vec) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 656 | let lifetime_ident = Ident::new(name, Span::call_site()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 660 | bound: Some(GenericBound { [INFO] [stdout] | ____________________^ [INFO] [stdout] 661 | | tk_colon: Punct::new(':', Spacing::Alone), [INFO] [stdout] 662 | | tokens: ty, [INFO] [stdout] 663 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types_edition.rs:747:9 [INFO] [stdout] | [INFO] [stdout] 746 | pub fn from_predicate(item: WhereClausePredicate) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 747 | Self::default().with_predicate(item) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types_edition.rs:790:20 [INFO] [stdout] | [INFO] [stdout] 763 | pub fn parse(tokens: TokenStream) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 764 | let mut tokens = tokens.into_iter().peekable(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 765 | [INFO] [stdout] 766 | let left_side = crate::parse_utils::consume_stuff_until( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 777 | Some(token) => panic!( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 786 | let bound_tokens = tokens.collect(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 790 | bound: GenericBound { [INFO] [stdout] | ____________________^ [INFO] [stdout] 791 | | tk_colon: colon, [INFO] [stdout] 792 | | tokens: bound_tokens, [INFO] [stdout] 793 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 31 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `venial` (lib) due to 32 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d67359eafd4be6e8f9b0acec2b6e7bfd20676e7b84cc93fc3f36c2300e38d1de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d67359eafd4be6e8f9b0acec2b6e7bfd20676e7b84cc93fc3f36c2300e38d1de", kill_on_drop: false }` [INFO] [stdout] d67359eafd4be6e8f9b0acec2b6e7bfd20676e7b84cc93fc3f36c2300e38d1de