[INFO] fetching crate velopack 0.0.89... [INFO] checking velopack-0.0.89 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate velopack 0.0.89 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate velopack 0.0.89 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate velopack 0.0.89 [INFO] finished tweaking crates.io crate velopack 0.0.89 [INFO] tweaked toml for crates.io crate velopack 0.0.89 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate velopack 0.0.89 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f4e8f0f8449c42ecb53fcc98e9146029ea5528a5d893060a40adc45d1c28b502 [INFO] running `Command { std: "docker" "start" "-a" "f4e8f0f8449c42ecb53fcc98e9146029ea5528a5d893060a40adc45d1c28b502", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f4e8f0f8449c42ecb53fcc98e9146029ea5528a5d893060a40adc45d1c28b502", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4e8f0f8449c42ecb53fcc98e9146029ea5528a5d893060a40adc45d1c28b502", kill_on_drop: false }` [INFO] [stdout] f4e8f0f8449c42ecb53fcc98e9146029ea5528a5d893060a40adc45d1c28b502 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e3532e60f6af8f098cb154bc0bcaa9d7f95217787a58bab547abb30798285826 [INFO] running `Command { std: "docker" "start" "-a" "e3532e60f6af8f098cb154bc0bcaa9d7f95217787a58bab547abb30798285826", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling cc v1.0.87 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling openssl-sys v0.9.101 [INFO] [stderr] Checking xml-rs v0.8.19 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking xml v0.8.10 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking ureq v2.9.6 [INFO] [stderr] Checking velopack v0.0.89 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/download.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 50 | let tls_builder = native_tls::TlsConnector::builder(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let tls_connector = tls_builder.build()?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Ok(ureq::AgentBuilder::new().tls_connector(tls_connector.into()).build()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn new(source: T, options: Option) -> Result> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | Ok(UpdateManager { [INFO] [stdout] | ____________^ [INFO] [stdout] 153 | | paths: locator::auto_locate()?, [INFO] [stdout] 154 | | allow_version_downgrade: options.as_ref().map(|f| f.AllowVersionDowngrade).unwrap_or(false), [INFO] [stdout] 155 | | explicit_channel: options.as_ref().map(|f| f.ExplicitChannel.clone()).unwrap_or(None), [INFO] [stdout] 156 | | source, [INFO] [stdout] 157 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/locator.rs:104:8 [INFO] [stdout] | [INFO] [stdout] 103 | let app = read_current_manifest(&metadata_path)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | Ok(VelopackLocator { [INFO] [stdout] | ________^ [INFO] [stdout] 105 | | root_app_dir, [INFO] [stdout] 106 | | update_exe_path, [INFO] [stdout] 107 | | packages_dir: PathBuf::from("/var/tmp/velopack").join(&app.id).join("packages"), [INFO] [stdout] 108 | | manifest: app, [INFO] [stdout] 109 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `velopack` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/download.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 50 | let tls_builder = native_tls::TlsConnector::builder(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let tls_connector = tls_builder.build()?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Ok(ureq::AgentBuilder::new().tls_connector(tls_connector.into()).build()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn new(source: T, options: Option) -> Result> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | Ok(UpdateManager { [INFO] [stdout] | ____________^ [INFO] [stdout] 153 | | paths: locator::auto_locate()?, [INFO] [stdout] 154 | | allow_version_downgrade: options.as_ref().map(|f| f.AllowVersionDowngrade).unwrap_or(false), [INFO] [stdout] 155 | | explicit_channel: options.as_ref().map(|f| f.ExplicitChannel.clone()).unwrap_or(None), [INFO] [stdout] 156 | | source, [INFO] [stdout] 157 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/locator.rs:104:8 [INFO] [stdout] | [INFO] [stdout] 103 | let app = read_current_manifest(&metadata_path)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | Ok(VelopackLocator { [INFO] [stdout] | ________^ [INFO] [stdout] 105 | | root_app_dir, [INFO] [stdout] 106 | | update_exe_path, [INFO] [stdout] 107 | | packages_dir: PathBuf::from("/var/tmp/velopack").join(&app.id).join("packages"), [INFO] [stdout] 108 | | manifest: app, [INFO] [stdout] 109 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `velopack` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "e3532e60f6af8f098cb154bc0bcaa9d7f95217787a58bab547abb30798285826", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3532e60f6af8f098cb154bc0bcaa9d7f95217787a58bab547abb30798285826", kill_on_drop: false }` [INFO] [stdout] e3532e60f6af8f098cb154bc0bcaa9d7f95217787a58bab547abb30798285826