[INFO] fetching crate velarixdb 0.0.15... [INFO] checking velarixdb-0.0.15 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate velarixdb 0.0.15 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate velarixdb 0.0.15 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate velarixdb 0.0.15 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate velarixdb 0.0.15 [INFO] tweaked toml for crates.io crate velarixdb 0.0.15 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate velarixdb 0.0.15 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5b267536db98946845059dff50cc79f6c6270a8e620d3547a535e926ace8519b [INFO] running `Command { std: "docker" "start" "-a" "5b267536db98946845059dff50cc79f6c6270a8e620d3547a535e926ace8519b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5b267536db98946845059dff50cc79f6c6270a8e620d3547a535e926ace8519b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b267536db98946845059dff50cc79f6c6270a8e620d3547a535e926ace8519b", kill_on_drop: false }` [INFO] [stdout] 5b267536db98946845059dff50cc79f6c6270a8e620d3547a535e926ace8519b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 713bc9ff8bbcf3c2f9f16aefa63c6caffcb66ea1e07b3e5c0df0617047cd8ffd [INFO] running `Command { std: "docker" "start" "-a" "713bc9ff8bbcf3c2f9f16aefa63c6caffcb66ea1e07b3e5c0df0617047cd8ffd", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling serde v1.0.205 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking rustix v0.38.34 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking crossbeam-skiplist v0.1.3 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking use v0.0.1-pre.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking async-broadcast v0.7.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.205 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking skip-list v0.1.3 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking velarixdb v0.0.15 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bucket/bucket_manager.rs:116:35 [INFO] [stdout] | [INFO] [stdout] 116 | .map(|s| tokio::spawn(fs::metadata(s.data_file.path.clone()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bucket/bucket_manager.rs:118:75 [INFO] [stdout] | [INFO] [stdout] 118 | let meta_data = meta_task.await.map_err(|err| GetFileMetaData(err.into()))?.unwrap(); [INFO] [stdout] | --- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compactors/insertor.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn from(entries: SkipMapEntries, filter: &BloomFilter) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | filter: filter.to_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compactors/sized.rs:177:53 [INFO] [stdout] | [INFO] [stdout] 177 | .map_err(|err| CompactionFailed(Box::new(err)))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/store.rs:234:35 [INFO] [stdout] | [INFO] [stdout] 233 | let gc_table = Arc::clone(&self.gc_table); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | tokio::spawn(async move { gc_table.write().await.insert(&entry) }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/bf.rs:189:22 [INFO] [stdout] | [INFO] [stdout] 179 | let mut bits = self.bit_vec.lock().expect("Failed to lock file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | bit_vec: Arc::new(Mutex::new(bit_vec)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flush/flusher.rs:82:19 [INFO] [stdout] | [INFO] [stdout] 72 | table_id: Id, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | table_to_flush: InActiveMemtable, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let tx = flush_tx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | let buckets = self.bucket_map.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let key_range = self.key_range.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let read_only_memtable = self.read_only_memtable.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | tokio::spawn(async move { [INFO] [stdout] 81 | let mut flusher = Flusher::new(read_only_memtable.clone(), buckets, key_range); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | match flusher.flush(table_to_flush).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:164:83 [INFO] [stdout] | [INFO] [stdout] 164 | async fn create + Send + Sync>(path: P) -> Result { [INFO] [stdout] | ___________________________________________________-------_________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | | Ok(OpenOptions::new() [INFO] [stdout] 166 | | .read(true) [INFO] [stdout] 167 | | .append(true) [INFO] [stdout] ... | [INFO] [stdout] 174 | | })?) [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:177:88 [INFO] [stdout] | [INFO] [stdout] 177 | async fn create_dir_all + Send + Sync>(dir: P) -> Result<(), Error> { [INFO] [stdout] | ___________________________________________________________------_______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | | let dir = dir.as_ref(); [INFO] [stdout] 179 | | if !dir.exists() { [INFO] [stdout] 180 | | return fs::create_dir_all(&dir).await.map_err(|err| DirCreation { [INFO] [stdout] ... | [INFO] [stdout] 185 | | Ok(()) [INFO] [stdout] 186 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:193:81 [INFO] [stdout] | [INFO] [stdout] 193 | async fn open + Send + Sync>(path: P) -> Result { [INFO] [stdout] | _________________________________________________-------_________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | | Ok(File::open(path.as_ref()).await.map_err(|err| FileOpen { [INFO] [stdout] 195 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 196 | | error: err, [INFO] [stdout] 197 | | })?) [INFO] [stdout] 198 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:259:109 [INFO] [stdout] | [INFO] [stdout] 259 | async fn new + Send + Sync>(path: P, file_type: FileType) -> Result { [INFO] [stdout] | ________________________________________________-------______________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | | let node = FileNode::new(path, file_type).await?; [INFO] [stdout] 261 | | Ok(DataFileNode { node }) [INFO] [stdout] 262 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:449:109 [INFO] [stdout] | [INFO] [stdout] 449 | async fn new + Send + Sync>(path: P, file_type: FileType) -> Result { [INFO] [stdout] | ________________________________________________-------______________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 450 | | let node = FileNode::new(path, file_type).await?; [INFO] [stdout] 451 | | Ok(VLogFileNode { node }) [INFO] [stdout] 452 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:641:110 [INFO] [stdout] | [INFO] [stdout] 641 | async fn new + Send + Sync>(path: P, file_type: FileType) -> Result { [INFO] [stdout] | ________________________________________________-------_______________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 642 | | let node = FileNode::new(path, file_type).await?; [INFO] [stdout] 643 | | Ok(IndexFileNode { node }) [INFO] [stdout] 644 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:735:111 [INFO] [stdout] | [INFO] [stdout] 735 | async fn new + Send + Sync>(path: P, file_type: FileType) -> Result { [INFO] [stdout] | ________________________________________________-------________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 736 | | let node = FileNode::new(path, file_type).await?; [INFO] [stdout] 737 | | Ok(FilterFileNode { node }) [INFO] [stdout] 738 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:742:67 [INFO] [stdout] | [INFO] [stdout] 741 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 742 | ) -> Result<(FalsePositive, NoHashFunc, NoOfElements), Error> { [INFO] [stdout] | ___________________________________________________________________^ [INFO] [stdout] 743 | | let mut file = FileNode::open(path.as_ref()) [INFO] [stdout] 744 | | .await [INFO] [stdout] 745 | | .map_err(|_| return FilterFileOpen(path.as_ref().to_owned()))?; [INFO] [stdout] ... | [INFO] [stdout] 769 | | return Ok((false_positive_rate.unwrap(), no_of_hash_func, no_of_elements)); [INFO] [stdout] 770 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:780:109 [INFO] [stdout] | [INFO] [stdout] 780 | async fn new + Send + Sync>(path: P, file_type: FileType) -> Result { [INFO] [stdout] | ________________________________________________-------______________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 781 | | let node = FileNode::new(path, file_type).await?; [INFO] [stdout] 782 | | Ok(MetaFileNode { node }) [INFO] [stdout] 783 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:786:71 [INFO] [stdout] | [INFO] [stdout] 785 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 786 | ) -> Result<(VLogHead, VLogTail, CreatedAt, LastModified), Error> { [INFO] [stdout] | _______________________________________________________________________^ [INFO] [stdout] 787 | | let mut file = FileNode::open(path.as_ref()) [INFO] [stdout] 788 | | .await [INFO] [stdout] 789 | | .map_err(|_| return FilterFileOpen(path.as_ref().to_owned()))?; [INFO] [stdout] ... | [INFO] [stdout] 822 | | )); [INFO] [stdout] 823 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:833:112 [INFO] [stdout] | [INFO] [stdout] 833 | async fn new + Send + Sync>(path: P, file_type: FileType) -> Result { [INFO] [stdout] | ________________________________________________-------_________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 834 | | let node = FileNode::new(path, file_type).await?; [INFO] [stdout] 835 | | Ok(SummaryFileNode { node }) [INFO] [stdout] 836 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:837:105 [INFO] [stdout] | [INFO] [stdout] 837 | async fn recover + Send + Sync>(path: P) -> Result<(SmallestKey, BiggestKey), Error> { [INFO] [stdout] | ____________________________________________________-------______________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 838 | | let mut file = FileNode::open(path.as_ref()) [INFO] [stdout] 839 | | .await [INFO] [stdout] 840 | | .map_err(|_| return FilterFileOpen(path.as_ref().to_owned()))?; [INFO] [stdout] ... | [INFO] [stdout] 865 | | return Ok((smallest_key, biggest_key)); [INFO] [stdout] 866 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gc/garbage_collector.rs:108:27 [INFO] [stdout] | [INFO] [stdout] 101 | table: GCTable, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | vlog: GCLog, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | gc_updated_entries: GCUpdatedEntries, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | punch_marker: Arc::new(Mutex::new(PunchMarker::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gc/garbage_collector.rs:192:34 [INFO] [stdout] | [INFO] [stdout] 185 | let invalid_entries_ref = Arc::clone(&invalid_entries); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | let valid_entries_ref = Arc::clone(&valid_entries); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let table_ref = Arc::clone(&memtable); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let vlog_ref = Arc::clone(&vlog); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let key_range_ref = Arc::clone(&key_range); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let read_only_memtables_ref = Arc::clone(&read_only_memtables); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | [INFO] [stdout] 192 | tokio::spawn(async move { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 193 | | let most_recent_value = GC::get( [INFO] [stdout] 194 | | std::str::from_utf8(&entry.key).unwrap(), [INFO] [stdout] 195 | | Arc::clone(&table_ref), [INFO] [stdout] ... | [INFO] [stdout] 211 | | } [INFO] [stdout] 212 | | }) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index/indexer.rs:124:19 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn new + Send + Sync>(path: P, file: IndexFileNode) -> Self { [INFO] [stdout] | ------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | file: IndexFile::new(path, file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memtable/mem.rs:191:22 [INFO] [stdout] | [INFO] [stdout] 186 | let bf = BloomFilter::new(false_positive_rate, max_no_of_entries); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let entries = SkipMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | entries: Arc::new(entries), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 23 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `velarixdb` (lib) due to 24 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bucket/bucket_manager.rs:116:35 [INFO] [stdout] | [INFO] [stdout] 116 | .map(|s| tokio::spawn(fs::metadata(s.data_file.path.clone()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bucket/bucket_manager.rs:118:75 [INFO] [stdout] | [INFO] [stdout] 118 | let meta_data = meta_task.await.map_err(|err| GetFileMetaData(err.into()))?.unwrap(); [INFO] [stdout] | --- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compactors/insertor.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn from(entries: SkipMapEntries, filter: &BloomFilter) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | filter: filter.to_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compactors/sized.rs:177:53 [INFO] [stdout] | [INFO] [stdout] 177 | .map_err(|err| CompactionFailed(Box::new(err)))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/store.rs:234:35 [INFO] [stdout] | [INFO] [stdout] 233 | let gc_table = Arc::clone(&self.gc_table); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | tokio::spawn(async move { gc_table.write().await.insert(&entry) }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/bf.rs:189:22 [INFO] [stdout] | [INFO] [stdout] 179 | let mut bits = self.bit_vec.lock().expect("Failed to lock file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | bit_vec: Arc::new(Mutex::new(bit_vec)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flush/flusher.rs:82:19 [INFO] [stdout] | [INFO] [stdout] 72 | table_id: Id, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | table_to_flush: InActiveMemtable, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let tx = flush_tx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | let buckets = self.bucket_map.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let key_range = self.key_range.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let read_only_memtable = self.read_only_memtable.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | tokio::spawn(async move { [INFO] [stdout] 81 | let mut flusher = Flusher::new(read_only_memtable.clone(), buckets, key_range); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | match flusher.flush(table_to_flush).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:164:83 [INFO] [stdout] | [INFO] [stdout] 164 | async fn create + Send + Sync>(path: P) -> Result { [INFO] [stdout] | ___________________________________________________-------_________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | | Ok(OpenOptions::new() [INFO] [stdout] 166 | | .read(true) [INFO] [stdout] 167 | | .append(true) [INFO] [stdout] ... | [INFO] [stdout] 174 | | })?) [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:177:88 [INFO] [stdout] | [INFO] [stdout] 177 | async fn create_dir_all + Send + Sync>(dir: P) -> Result<(), Error> { [INFO] [stdout] | ___________________________________________________________------_______________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | | let dir = dir.as_ref(); [INFO] [stdout] 179 | | if !dir.exists() { [INFO] [stdout] 180 | | return fs::create_dir_all(&dir).await.map_err(|err| DirCreation { [INFO] [stdout] ... | [INFO] [stdout] 185 | | Ok(()) [INFO] [stdout] 186 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:193:81 [INFO] [stdout] | [INFO] [stdout] 193 | async fn open + Send + Sync>(path: P) -> Result { [INFO] [stdout] | _________________________________________________-------_________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | | Ok(File::open(path.as_ref()).await.map_err(|err| FileOpen { [INFO] [stdout] 195 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 196 | | error: err, [INFO] [stdout] 197 | | })?) [INFO] [stdout] 198 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:259:109 [INFO] [stdout] | [INFO] [stdout] 259 | async fn new + Send + Sync>(path: P, file_type: FileType) -> Result { [INFO] [stdout] | ________________________________________________-------______________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | | let node = FileNode::new(path, file_type).await?; [INFO] [stdout] 261 | | Ok(DataFileNode { node }) [INFO] [stdout] 262 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:449:109 [INFO] [stdout] | [INFO] [stdout] 449 | async fn new + Send + Sync>(path: P, file_type: FileType) -> Result { [INFO] [stdout] | ________________________________________________-------______________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 450 | | let node = FileNode::new(path, file_type).await?; [INFO] [stdout] 451 | | Ok(VLogFileNode { node }) [INFO] [stdout] 452 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:641:110 [INFO] [stdout] | [INFO] [stdout] 641 | async fn new + Send + Sync>(path: P, file_type: FileType) -> Result { [INFO] [stdout] | ________________________________________________-------_______________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 642 | | let node = FileNode::new(path, file_type).await?; [INFO] [stdout] 643 | | Ok(IndexFileNode { node }) [INFO] [stdout] 644 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:735:111 [INFO] [stdout] | [INFO] [stdout] 735 | async fn new + Send + Sync>(path: P, file_type: FileType) -> Result { [INFO] [stdout] | ________________________________________________-------________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 736 | | let node = FileNode::new(path, file_type).await?; [INFO] [stdout] 737 | | Ok(FilterFileNode { node }) [INFO] [stdout] 738 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:742:67 [INFO] [stdout] | [INFO] [stdout] 741 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 742 | ) -> Result<(FalsePositive, NoHashFunc, NoOfElements), Error> { [INFO] [stdout] | ___________________________________________________________________^ [INFO] [stdout] 743 | | let mut file = FileNode::open(path.as_ref()) [INFO] [stdout] 744 | | .await [INFO] [stdout] 745 | | .map_err(|_| return FilterFileOpen(path.as_ref().to_owned()))?; [INFO] [stdout] ... | [INFO] [stdout] 769 | | return Ok((false_positive_rate.unwrap(), no_of_hash_func, no_of_elements)); [INFO] [stdout] 770 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:780:109 [INFO] [stdout] | [INFO] [stdout] 780 | async fn new + Send + Sync>(path: P, file_type: FileType) -> Result { [INFO] [stdout] | ________________________________________________-------______________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 781 | | let node = FileNode::new(path, file_type).await?; [INFO] [stdout] 782 | | Ok(MetaFileNode { node }) [INFO] [stdout] 783 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:786:71 [INFO] [stdout] | [INFO] [stdout] 785 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 786 | ) -> Result<(VLogHead, VLogTail, CreatedAt, LastModified), Error> { [INFO] [stdout] | _______________________________________________________________________^ [INFO] [stdout] 787 | | let mut file = FileNode::open(path.as_ref()) [INFO] [stdout] 788 | | .await [INFO] [stdout] 789 | | .map_err(|_| return FilterFileOpen(path.as_ref().to_owned()))?; [INFO] [stdout] ... | [INFO] [stdout] 822 | | )); [INFO] [stdout] 823 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:833:112 [INFO] [stdout] | [INFO] [stdout] 833 | async fn new + Send + Sync>(path: P, file_type: FileType) -> Result { [INFO] [stdout] | ________________________________________________-------_________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 834 | | let node = FileNode::new(path, file_type).await?; [INFO] [stdout] 835 | | Ok(SummaryFileNode { node }) [INFO] [stdout] 836 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/mod.rs:837:105 [INFO] [stdout] | [INFO] [stdout] 837 | async fn recover + Send + Sync>(path: P) -> Result<(SmallestKey, BiggestKey), Error> { [INFO] [stdout] | ____________________________________________________-------______________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 838 | | let mut file = FileNode::open(path.as_ref()) [INFO] [stdout] 839 | | .await [INFO] [stdout] 840 | | .map_err(|_| return FilterFileOpen(path.as_ref().to_owned()))?; [INFO] [stdout] ... | [INFO] [stdout] 865 | | return Ok((smallest_key, biggest_key)); [INFO] [stdout] 866 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gc/garbage_collector.rs:108:27 [INFO] [stdout] | [INFO] [stdout] 101 | table: GCTable, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | vlog: GCLog, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | gc_updated_entries: GCUpdatedEntries, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | punch_marker: Arc::new(Mutex::new(PunchMarker::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gc/garbage_collector.rs:192:34 [INFO] [stdout] | [INFO] [stdout] 185 | let invalid_entries_ref = Arc::clone(&invalid_entries); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | let valid_entries_ref = Arc::clone(&valid_entries); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let table_ref = Arc::clone(&memtable); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let vlog_ref = Arc::clone(&vlog); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let key_range_ref = Arc::clone(&key_range); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let read_only_memtables_ref = Arc::clone(&read_only_memtables); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | [INFO] [stdout] 192 | tokio::spawn(async move { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 193 | | let most_recent_value = GC::get( [INFO] [stdout] 194 | | std::str::from_utf8(&entry.key).unwrap(), [INFO] [stdout] 195 | | Arc::clone(&table_ref), [INFO] [stdout] ... | [INFO] [stdout] 211 | | } [INFO] [stdout] 212 | | }) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index/indexer.rs:124:19 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn new + Send + Sync>(path: P, file: IndexFileNode) -> Self { [INFO] [stdout] | ------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | file: IndexFile::new(path, file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memtable/mem.rs:191:22 [INFO] [stdout] | [INFO] [stdout] 186 | let bf = BloomFilter::new(false_positive_rate, max_no_of_entries); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let entries = SkipMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | entries: Arc::new(entries), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/bucket_test.rs:54:35 [INFO] [stdout] | [INFO] [stdout] 54 | .map(|s| tokio::spawn(fs::metadata(s.data_file.path.clone()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/bucket_test.rs:59:55 [INFO] [stdout] | [INFO] [stdout] 59 | .map_err(|err| Error::GetFileMetaData(err.into())) [INFO] [stdout] | --- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/bucket_test.rs:79:35 [INFO] [stdout] | [INFO] [stdout] 79 | .map(|s| tokio::spawn(fs::metadata(s.data_file.path.clone()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/bucket_test.rs:84:55 [INFO] [stdout] | [INFO] [stdout] 84 | .map_err(|err| Error::GetFileMetaData(err.into())) [INFO] [stdout] | --- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/bucket_test.rs:120:35 [INFO] [stdout] | [INFO] [stdout] 120 | .map(|s| tokio::spawn(fs::metadata(s.data_file.path.clone()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/bucket_test.rs:125:55 [INFO] [stdout] | [INFO] [stdout] 125 | .map_err(|err| Error::GetFileMetaData(err.into())) [INFO] [stdout] | --- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/store_test.rs:54:26 [INFO] [stdout] | [INFO] [stdout] 51 | let store_inner = Arc::clone(&store_ref); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 55 | | let mut writer = store_inner.write().await; [INFO] [stdout] 56 | | writer.put(key, val).await [INFO] [stdout] 57 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/store_test.rs:56:38 [INFO] [stdout] | [INFO] [stdout] 51 | let store_inner = Arc::clone(&store_ref); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let mut writer = store_inner.write().await; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | writer.put(key, val).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/store_test.rs:85:26 [INFO] [stdout] | [INFO] [stdout] 82 | let store_inner = Arc::clone(&store_ref); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 86 | | let mut value = store_inner.write().await; [INFO] [stdout] 87 | | value.put(key, val).await [INFO] [stdout] 88 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/store_test.rs:87:37 [INFO] [stdout] | [INFO] [stdout] 82 | let store_inner = Arc::clone(&store_ref); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let mut value = store_inner.write().await; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | value.put(key, val).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/store_test.rs:101:26 [INFO] [stdout] | [INFO] [stdout] 99 | let store_inner = Arc::clone(&store_ref); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let key = e.to_owned(); [INFO] [stdout] 101 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 102 | | match store_inner.read().await.get(key.to_owned()).await { [INFO] [stdout] 103 | | Ok(entry) => Ok((key, entry)), [INFO] [stdout] 104 | | Err(err) => Err(err), [INFO] [stdout] 105 | | } [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/store_test.rs:102:23 [INFO] [stdout] | [INFO] [stdout] 99 | let store_inner = Arc::clone(&store_ref); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | match store_inner.read().await.get(key.to_owned()).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/store_test.rs:150:26 [INFO] [stdout] | [INFO] [stdout] 147 | let store_inner = Arc::clone(&store_ref); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 151 | | let mut value = store_inner.write().await; [INFO] [stdout] 152 | | value.put(key, val).await [INFO] [stdout] 153 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/store_test.rs:152:37 [INFO] [stdout] | [INFO] [stdout] 147 | let store_inner = Arc::clone(&store_ref); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let mut value = store_inner.write().await; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | value.put(key, val).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/workload.rs:99:26 [INFO] [stdout] | [INFO] [stdout] 96 | let s_engine = Arc::clone(&store); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 100 | | let key_str = std::str::from_utf8(&key).unwrap(); [INFO] [stdout] 101 | | let val_str = std::str::from_utf8(&val).unwrap(); [INFO] [stdout] 102 | | let mut value = s_engine.write().await; [INFO] [stdout] 103 | | value.put(key_str, val_str).await [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/workload.rs:103:45 [INFO] [stdout] | [INFO] [stdout] 96 | let s_engine = Arc::clone(&store); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let mut value = s_engine.write().await; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | value.put(key_str, val_str).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 39 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `velarixdb` (lib test) due to 40 previous errors [INFO] running `Command { std: "docker" "inspect" "713bc9ff8bbcf3c2f9f16aefa63c6caffcb66ea1e07b3e5c0df0617047cd8ffd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "713bc9ff8bbcf3c2f9f16aefa63c6caffcb66ea1e07b3e5c0df0617047cd8ffd", kill_on_drop: false }` [INFO] [stdout] 713bc9ff8bbcf3c2f9f16aefa63c6caffcb66ea1e07b3e5c0df0617047cd8ffd