[INFO] fetching crate vectorview 0.1.0... [INFO] checking vectorview-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vectorview 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate vectorview 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vectorview 0.1.0 [INFO] finished tweaking crates.io crate vectorview 0.1.0 [INFO] tweaked toml for crates.io crate vectorview 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 61 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding num v0.2.1 (latest: v0.4.3) [INFO] [stderr] Adding num-bigint v0.2.6 (latest: v0.4.6) [INFO] [stderr] Adding num-complex v0.2.4 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.2.4 (latest: v0.4.2) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] [stderr] Adding rpg-stat v3.0.0 (latest: v2021.12.16) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding strum v0.22.0 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.22.0 (latest: v0.26.4) [INFO] [stderr] Adding svg v0.10.0 (latest: v0.17.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9a580772ce31f43d4c12eb7e850b20c936a5b770f70c0dff7a4abc8f5bcc9160 [INFO] running `Command { std: "docker" "start" "-a" "9a580772ce31f43d4c12eb7e850b20c936a5b770f70c0dff7a4abc8f5bcc9160", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9a580772ce31f43d4c12eb7e850b20c936a5b770f70c0dff7a4abc8f5bcc9160", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a580772ce31f43d4c12eb7e850b20c936a5b770f70c0dff7a4abc8f5bcc9160", kill_on_drop: false }` [INFO] [stdout] 9a580772ce31f43d4c12eb7e850b20c936a5b770f70c0dff7a4abc8f5bcc9160 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 039e94d43287e5260bb2b047a14a19e4816971310dece582eb5f4a84765af28a [INFO] running `Command { std: "docker" "start" "-a" "039e94d43287e5260bb2b047a14a19e4816971310dece582eb5f4a84765af28a", kill_on_drop: false }` [INFO] [stderr] Checking svg v0.10.0 [INFO] [stderr] Checking vectorview v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::fmt` [INFO] [stdout] --> src/svg.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `svg::Document` [INFO] [stdout] --> src/svg.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use svg::Document; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Filter` [INFO] [stdout] --> src/svg.rs:3:35 [INFO] [stdout] | [INFO] [stdout] 3 | use svg::node::element::{Ellipse, Filter, Rectangle, path::Data, Path}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Teeth` [INFO] [stdout] --> src/prelude.rs:1:20 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::enums::{Teeth, Expression}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt` [INFO] [stdout] --> src/svg.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `svg::Document` [INFO] [stdout] --> src/svg.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use svg::Document; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Filter` [INFO] [stdout] --> src/svg.rs:3:35 [INFO] [stdout] | [INFO] [stdout] 3 | use svg::node::element::{Ellipse, Filter, Rectangle, path::Data, Path}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Teeth` [INFO] [stdout] --> src/prelude.rs:1:20 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::enums::{Teeth, Expression}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::prelude::*` [INFO] [stdout] --> src/lib.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `anger` [INFO] [stdout] --> src/svg.rs:43:139 [INFO] [stdout] | [INFO] [stdout] 43 | ...olor:&str, teeth_color:&str, anger:bool, teeth:Teeth) -> Group { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_anger` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hand` [INFO] [stdout] --> src/svg.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | let hand = skin_color; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_hand` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `jaw_w` [INFO] [stdout] --> src/svg.rs:252:13 [INFO] [stdout] | [INFO] [stdout] 252 | let jaw_w:f64 = face_w / 3.0;//(face_w / 16.0) * 8.5; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_jaw_w` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ear_h` [INFO] [stdout] --> src/svg.rs:260:13 [INFO] [stdout] | [INFO] [stdout] 260 | let ear_h:f64 = nose_h; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_ear_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ear_rx` [INFO] [stdout] --> src/svg.rs:261:13 [INFO] [stdout] | [INFO] [stdout] 261 | let ear_rx:f64 = face_x + face_w - spacer; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_ear_rx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/svg.rs:339:45 [INFO] [stdout] | [INFO] [stdout] 339 | fn get_fang(&self, x:f64, y:f64, w:f64, h:f64, color:&str, opacity:f64, amount:usize, current:usize) -> Path { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opacity` [INFO] [stdout] --> src/prelude.rs:6:66 [INFO] [stdout] | [INFO] [stdout] 6 | fn make_image(&self, x:f64, y:f64, w:f64, h:f64, color:&str, opacity:f64) -> Group { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_opacity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/svg.rs:19:44 [INFO] [stdout] | [INFO] [stdout] 19 | self.make_eye_default(x,y,w,h,color.clone()) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/svg.rs:80:44 [INFO] [stdout] | [INFO] [stdout] 80 | self.make_smile_mouth(x,y,w,h,color.clone(), teeth) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 104 | let arm_upper = self.make_rectangle(x, y, length, thickness, clothes_color); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let arm = self.make_rectangle(arm_x, y, thickness, length, clothes_color); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | / Group::new() [INFO] [stdout] 113 | | .add(arm_upper) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 138 | let debug = self.make_rectangle(x, y, w, h, "red"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let head = self.make_face(head_x, y, head_w, head_h, skin_color, eye_color, nose_color, hair_color, teeth_color, false, teeth); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | let clothes1 = self.make_rectangle(center_x - quarter_w, y, torso_w, torso_h, clothes_color1); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | let l_arm = self.make_arm(x, y, arm_length, arm_thickness, clothes_color1, true); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let r_arm = self.make_arm(center_x + (torso_w / 2.0), y, arm_length, arm_thickness, clothes_color1, false); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | let hips = self.make_rectangle(center_x - quarter_w, y + torso_h - spacer, torso_w, hip_h, clothes_color2); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | let leg1 = self.make_rectangle(center_x - quarter_w, leg_y, leg_thickness, leg_length, clothes_color2); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let leg2 = self.make_rectangle(center_x + quarter_w - leg_thickness, leg_y, leg_thickness, leg_length, clothes_color2); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | / Group::new() [INFO] [stdout] 150 | | .add(debug) [INFO] [stdout] 151 | | .add(hips) [INFO] [stdout] 152 | | .add(leg1) [INFO] [stdout] ... | [INFO] [stdout] 155 | | .add(r_arm) [INFO] [stdout] 156 | | .add(l_arm) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 166 | let nose = self.make_ellipse(x, y, w, h, nose_color); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let nose_shine = self.make_ellipse_opacity(x + spacer, y, shine_w, shine_h, "white",0.2); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | Group::new().add(nose).add(nose_shine) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 180 | let nose = self.make_rectangle_roundness(nose_x, y, nose_w, h, nose_color, 5.0); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | let nostrils = self.make_ellipse(x, nos_y, w, nos_h, nose_color); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | Group::new().add(nose).add(nostrils) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 190 | let ear = self.make_ellipse(x, y, w, h, ear_color); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | let shadow = self.make_ellipse_shadow(x1,y1,w1,h1,"black"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | let ear_thing = self.make_ellipse(x2, y2, small_w, small_h, ear_color); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | / Group::new() [INFO] [stdout] 209 | | .add(ear) [INFO] [stdout] 210 | | .add(shadow) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 228 | let face = self.make_ellipse(x, y, w, face_h, skin_color); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | let cheeks = self.make_ellipse(center_x - (cheek_w / 2.0), y, cheek_w, h, skin_color); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | let jaw = self.make_rectangle_roundness(jaw_x, jaw_y, jaw_w, jaw_h, skin_color, 7.0); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | / Group::new() [INFO] [stdout] 232 | | .add(cheeks) [INFO] [stdout] 233 | | .add(face) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `anger` [INFO] [stdout] --> src/svg.rs:43:139 [INFO] [stdout] | [INFO] [stdout] 43 | ...olor:&str, teeth_color:&str, anger:bool, teeth:Teeth) -> Group { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_anger` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 275 | let bg = self.make_rectangle(x,y,w,h, "red"); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | //face [INFO] [stdout] 277 | let face = self.make_head(face_x, face_y, face_w, total_face_h, skin_color); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | //nose [INFO] [stdout] 279 | let nose = self.make_nose(nose_x, features_y, nose_w, nose_h, nose_color); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | //ears [INFO] [stdout] 281 | let l_ear = self.make_ear(ear_lx, features_y, ear_w, eye_w * 2.0, skin_color, true); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | let r_ear = self.make_ear(face_x + face_w - spacer, features_y, ear_w, eye_w * 2.0, skin_color, false); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | //eyebrows [INFO] [stdout] 284 | let eye_brow_r = self.make_slant(eye_l_x, brow_y, eye_w, brow_h, hair_color, 1.0, !anger); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | let eye_brow_l = self.make_slant(center_x + half_eye, brow_y, eye_w, brow_h, hair_color, 1.0, anger); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | //eyes [INFO] [stdout] 287 | let eye_l = self.make_eye(eye_l_x, features_y, eye_w, eye_w, eye_color); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 288 | let eye_r = self.make_eye(center_x + half_eye, features_y, eye_w, eye_w, eye_color); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 289 | //mouth [INFO] [stdout] 290 | let mouth = self.make_mouth(mouth_x, mouth_y, mouth_w, mouth_h, teeth_color, teeth); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | //let hair = self.make_hair(x,y,w,h,hair_color); [INFO] [stdout] 292 | / Group::new() [INFO] [stdout] 293 | | .add(bg) [INFO] [stdout] 294 | | .add(face) [INFO] [stdout] 295 | | .add(l_ear) [INFO] [stdout] ... | [INFO] [stdout] 300 | | .add(eye_brow_r) [INFO] [stdout] 301 | | .add(eye_brow_l) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:400:9 [INFO] [stdout] | [INFO] [stdout] 386 | let face = self.make_ellipse(face_x, y, face_w, face_h, color); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | //nose [INFO] [stdout] 388 | let nose = self.make_ellipse_shadow(nose_x, features_y + nose_w, nose_w, eye_w, "black"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 389 | //eyebrows [INFO] [stdout] 390 | let eye_brow_r = self.make_slant(eye_l_x, brow_y, eye_w, brow_h, "black", 0.4, true); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 391 | let eye_brow_l = self.make_slant(center_x + eye_w, brow_y, eye_w, brow_h, "black", 0.4, false); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | //eyes [INFO] [stdout] 393 | let eye_l = self.make_ellipse_shadow(eye_l_x, features_y, eye_w, eye_w, "black"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 394 | let eye_r = self.make_ellipse_shadow(center_x + eye_w, features_y, eye_w, eye_w, "black"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | //mouth2 [INFO] [stdout] 396 | let mouth2 = self.make_rectangle_roundness(mouth_x, mouth_y, mouth_w, mouth_h / 2.0, color, 4.0); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 397 | //mouth [INFO] [stdout] 398 | let mouth = self.make_tooth_row(mouth_x, mouth_y, mouth_w, mouth_h, color, 0.7, 5); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 399 | [INFO] [stdout] 400 | / Group::new() [INFO] [stdout] 401 | | .add(face) [INFO] [stdout] 402 | | .add(mouth) [INFO] [stdout] 403 | | .add(mouth2) [INFO] [stdout] ... | [INFO] [stdout] 406 | | .add(eye_l) [INFO] [stdout] 407 | | .add(eye_brow_r) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:490:9 [INFO] [stdout] | [INFO] [stdout] 485 | let path = self.make_down_part(x, y, w, h, "black", 1.0); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 489 | let tooth = self.make_teeth(x + spacer, y, tooth_w, tooth_h, color, teeth); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 490 | / Group::new() [INFO] [stdout] 491 | | .add(path) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/prelude.rs:8:68 [INFO] [stdout] | [INFO] [stdout] 8 | Expression::Smile =>self.make_simple_body(x,y,w,h,color.clone(),"#00004a","orange", "#76612d"), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/prelude.rs:9:52 [INFO] [stdout] | [INFO] [stdout] 9 | _=> self.make_simple_body(x,y,w,h,color.clone(),"brown","purple", "green"), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hand` [INFO] [stdout] --> src/svg.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | let hand = skin_color; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_hand` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `jaw_w` [INFO] [stdout] --> src/svg.rs:252:13 [INFO] [stdout] | [INFO] [stdout] 252 | let jaw_w:f64 = face_w / 3.0;//(face_w / 16.0) * 8.5; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_jaw_w` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ear_h` [INFO] [stdout] --> src/svg.rs:260:13 [INFO] [stdout] | [INFO] [stdout] 260 | let ear_h:f64 = nose_h; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_ear_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ear_rx` [INFO] [stdout] --> src/svg.rs:261:13 [INFO] [stdout] | [INFO] [stdout] 261 | let ear_rx:f64 = face_x + face_w - spacer; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_ear_rx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/svg.rs:339:45 [INFO] [stdout] | [INFO] [stdout] 339 | fn get_fang(&self, x:f64, y:f64, w:f64, h:f64, color:&str, opacity:f64, amount:usize, current:usize) -> Path { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opacity` [INFO] [stdout] --> src/prelude.rs:6:66 [INFO] [stdout] | [INFO] [stdout] 6 | fn make_image(&self, x:f64, y:f64, w:f64, h:f64, color:&str, opacity:f64) -> Group { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_opacity` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vectorview` (lib) due to 10 previous errors; 15 warnings emitted [INFO] [stdout] warning: unused variable: `opacity` [INFO] [stdout] --> src/lib.rs:18:70 [INFO] [stdout] | [INFO] [stdout] 18 | fn make_image(&self, x:f64, y:f64, w:f64, h:f64, color:&str, opacity:f64) -> Group { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_opacity` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct Test(u32); [INFO] [stdout] | ---- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/svg.rs:19:44 [INFO] [stdout] | [INFO] [stdout] 19 | self.make_eye_default(x,y,w,h,color.clone()) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/svg.rs:80:44 [INFO] [stdout] | [INFO] [stdout] 80 | self.make_smile_mouth(x,y,w,h,color.clone(), teeth) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 104 | let arm_upper = self.make_rectangle(x, y, length, thickness, clothes_color); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let arm = self.make_rectangle(arm_x, y, thickness, length, clothes_color); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | / Group::new() [INFO] [stdout] 113 | | .add(arm_upper) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 138 | let debug = self.make_rectangle(x, y, w, h, "red"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let head = self.make_face(head_x, y, head_w, head_h, skin_color, eye_color, nose_color, hair_color, teeth_color, false, teeth); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | let clothes1 = self.make_rectangle(center_x - quarter_w, y, torso_w, torso_h, clothes_color1); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | let l_arm = self.make_arm(x, y, arm_length, arm_thickness, clothes_color1, true); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let r_arm = self.make_arm(center_x + (torso_w / 2.0), y, arm_length, arm_thickness, clothes_color1, false); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | let hips = self.make_rectangle(center_x - quarter_w, y + torso_h - spacer, torso_w, hip_h, clothes_color2); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | let leg1 = self.make_rectangle(center_x - quarter_w, leg_y, leg_thickness, leg_length, clothes_color2); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let leg2 = self.make_rectangle(center_x + quarter_w - leg_thickness, leg_y, leg_thickness, leg_length, clothes_color2); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | / Group::new() [INFO] [stdout] 150 | | .add(debug) [INFO] [stdout] 151 | | .add(hips) [INFO] [stdout] 152 | | .add(leg1) [INFO] [stdout] ... | [INFO] [stdout] 155 | | .add(r_arm) [INFO] [stdout] 156 | | .add(l_arm) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 166 | let nose = self.make_ellipse(x, y, w, h, nose_color); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let nose_shine = self.make_ellipse_opacity(x + spacer, y, shine_w, shine_h, "white",0.2); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | Group::new().add(nose).add(nose_shine) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 180 | let nose = self.make_rectangle_roundness(nose_x, y, nose_w, h, nose_color, 5.0); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | let nostrils = self.make_ellipse(x, nos_y, w, nos_h, nose_color); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | Group::new().add(nose).add(nostrils) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 190 | let ear = self.make_ellipse(x, y, w, h, ear_color); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | let shadow = self.make_ellipse_shadow(x1,y1,w1,h1,"black"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | let ear_thing = self.make_ellipse(x2, y2, small_w, small_h, ear_color); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | / Group::new() [INFO] [stdout] 209 | | .add(ear) [INFO] [stdout] 210 | | .add(shadow) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 228 | let face = self.make_ellipse(x, y, w, face_h, skin_color); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | let cheeks = self.make_ellipse(center_x - (cheek_w / 2.0), y, cheek_w, h, skin_color); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | let jaw = self.make_rectangle_roundness(jaw_x, jaw_y, jaw_w, jaw_h, skin_color, 7.0); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | / Group::new() [INFO] [stdout] 232 | | .add(cheeks) [INFO] [stdout] 233 | | .add(face) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 275 | let bg = self.make_rectangle(x,y,w,h, "red"); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | //face [INFO] [stdout] 277 | let face = self.make_head(face_x, face_y, face_w, total_face_h, skin_color); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | //nose [INFO] [stdout] 279 | let nose = self.make_nose(nose_x, features_y, nose_w, nose_h, nose_color); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | //ears [INFO] [stdout] 281 | let l_ear = self.make_ear(ear_lx, features_y, ear_w, eye_w * 2.0, skin_color, true); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | let r_ear = self.make_ear(face_x + face_w - spacer, features_y, ear_w, eye_w * 2.0, skin_color, false); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | //eyebrows [INFO] [stdout] 284 | let eye_brow_r = self.make_slant(eye_l_x, brow_y, eye_w, brow_h, hair_color, 1.0, !anger); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | let eye_brow_l = self.make_slant(center_x + half_eye, brow_y, eye_w, brow_h, hair_color, 1.0, anger); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | //eyes [INFO] [stdout] 287 | let eye_l = self.make_eye(eye_l_x, features_y, eye_w, eye_w, eye_color); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 288 | let eye_r = self.make_eye(center_x + half_eye, features_y, eye_w, eye_w, eye_color); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 289 | //mouth [INFO] [stdout] 290 | let mouth = self.make_mouth(mouth_x, mouth_y, mouth_w, mouth_h, teeth_color, teeth); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | //let hair = self.make_hair(x,y,w,h,hair_color); [INFO] [stdout] 292 | / Group::new() [INFO] [stdout] 293 | | .add(bg) [INFO] [stdout] 294 | | .add(face) [INFO] [stdout] 295 | | .add(l_ear) [INFO] [stdout] ... | [INFO] [stdout] 300 | | .add(eye_brow_r) [INFO] [stdout] 301 | | .add(eye_brow_l) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:400:9 [INFO] [stdout] | [INFO] [stdout] 386 | let face = self.make_ellipse(face_x, y, face_w, face_h, color); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | //nose [INFO] [stdout] 388 | let nose = self.make_ellipse_shadow(nose_x, features_y + nose_w, nose_w, eye_w, "black"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 389 | //eyebrows [INFO] [stdout] 390 | let eye_brow_r = self.make_slant(eye_l_x, brow_y, eye_w, brow_h, "black", 0.4, true); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 391 | let eye_brow_l = self.make_slant(center_x + eye_w, brow_y, eye_w, brow_h, "black", 0.4, false); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | //eyes [INFO] [stdout] 393 | let eye_l = self.make_ellipse_shadow(eye_l_x, features_y, eye_w, eye_w, "black"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 394 | let eye_r = self.make_ellipse_shadow(center_x + eye_w, features_y, eye_w, eye_w, "black"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | //mouth2 [INFO] [stdout] 396 | let mouth2 = self.make_rectangle_roundness(mouth_x, mouth_y, mouth_w, mouth_h / 2.0, color, 4.0); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 397 | //mouth [INFO] [stdout] 398 | let mouth = self.make_tooth_row(mouth_x, mouth_y, mouth_w, mouth_h, color, 0.7, 5); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 399 | [INFO] [stdout] 400 | / Group::new() [INFO] [stdout] 401 | | .add(face) [INFO] [stdout] 402 | | .add(mouth) [INFO] [stdout] 403 | | .add(mouth2) [INFO] [stdout] ... | [INFO] [stdout] 406 | | .add(eye_l) [INFO] [stdout] 407 | | .add(eye_brow_r) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg.rs:490:9 [INFO] [stdout] | [INFO] [stdout] 485 | let path = self.make_down_part(x, y, w, h, "black", 1.0); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 489 | let tooth = self.make_teeth(x + spacer, y, tooth_w, tooth_h, color, teeth); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 490 | / Group::new() [INFO] [stdout] 491 | | .add(path) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/prelude.rs:8:68 [INFO] [stdout] | [INFO] [stdout] 8 | Expression::Smile =>self.make_simple_body(x,y,w,h,color.clone(),"#00004a","orange", "#76612d"), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/prelude.rs:9:52 [INFO] [stdout] | [INFO] [stdout] 9 | _=> self.make_simple_body(x,y,w,h,color.clone(),"brown","purple", "green"), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vectorview` (lib test) due to 10 previous errors; 18 warnings emitted [INFO] running `Command { std: "docker" "inspect" "039e94d43287e5260bb2b047a14a19e4816971310dece582eb5f4a84765af28a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "039e94d43287e5260bb2b047a14a19e4816971310dece582eb5f4a84765af28a", kill_on_drop: false }` [INFO] [stdout] 039e94d43287e5260bb2b047a14a19e4816971310dece582eb5f4a84765af28a