[INFO] fetching crate vecgrid 0.2.2... [INFO] checking vecgrid-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vecgrid 0.2.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate vecgrid 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vecgrid 0.2.2 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate vecgrid 0.2.2 [INFO] tweaked toml for crates.io crate vecgrid 0.2.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate vecgrid 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 125c489f01a7a48c4885f2b9391bd3f30b621eea3badff0266f3a0949ad4e278 [INFO] running `Command { std: "docker" "start" "-a" "125c489f01a7a48c4885f2b9391bd3f30b621eea3badff0266f3a0949ad4e278", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "125c489f01a7a48c4885f2b9391bd3f30b621eea3badff0266f3a0949ad4e278", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "125c489f01a7a48c4885f2b9391bd3f30b621eea3badff0266f3a0949ad4e278", kill_on_drop: false }` [INFO] [stdout] 125c489f01a7a48c4885f2b9391bd3f30b621eea3badff0266f3a0949ad4e278 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b8a40bb57b276d59923ea88270fdcab65e93b8fd6d35d2d339e1765b88710098 [INFO] running `Command { std: "docker" "start" "-a" "b8a40bb57b276d59923ea88270fdcab65e93b8fd6d35d2d339e1765b88710098", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Checking vecgrid v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:279:12 [INFO] [stdout] | [INFO] [stdout] 266 | pub fn from_columns(columns: Vec>) -> Result [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | let vecgrid = indices_row_major(num_rows, num_columns) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | Ok(Vecgrid { [INFO] [stdout] | ____________^ [INFO] [stdout] 280 | | vecgrid, [INFO] [stdout] 281 | | num_rows, [INFO] [stdout] 282 | | num_columns, [INFO] [stdout] 283 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:317:12 [INFO] [stdout] | [INFO] [stdout] 309 | elements: Vec, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | Ok(Vecgrid { [INFO] [stdout] | ____________^ [INFO] [stdout] 318 | | vecgrid: elements, [INFO] [stdout] 319 | | num_rows, [INFO] [stdout] 320 | | num_columns, [INFO] [stdout] 321 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:366:12 [INFO] [stdout] | [INFO] [stdout] 347 | elements: Vec, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | let vecgrid = indices_row_major [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 366 | Ok(Vecgrid { [INFO] [stdout] | ____________^ [INFO] [stdout] 367 | | vecgrid, [INFO] [stdout] 368 | | num_rows, [INFO] [stdout] 369 | | num_columns, [INFO] [stdout] 370 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:458:9 [INFO] [stdout] | [INFO] [stdout] 451 | pub fn filled_by_column_major(mut generator: F, num_rows: usize, num_columns: usize) -> Self [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 457 | let vecgrid_column_major = (0..total_len).map(|_| generator()).collect::>(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 458 | Vecgrid::from_column_major(vecgrid_column_major, num_rows, num_columns) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:497:12 [INFO] [stdout] | [INFO] [stdout] 485 | iterator: I, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 493 | let vecgrid = iterator.take(total_len).collect::>(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 497 | Ok(Vecgrid { [INFO] [stdout] | ____________^ [INFO] [stdout] 498 | | vecgrid, [INFO] [stdout] 499 | | num_rows, [INFO] [stdout] 500 | | num_columns, [INFO] [stdout] 501 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:537:9 [INFO] [stdout] | [INFO] [stdout] 527 | iterator: I, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 536 | let vecgrid_column_major = iterator.take(total_len).collect::>(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 537 | Vecgrid::from_column_major(vecgrid_column_major, num_rows, num_columns) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:742:18 [INFO] [stdout] | [INFO] [stdout] 740 | pub fn set(&mut self, row: usize, column: usize, element: T) -> Result<(), Error> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 741 | self.get_mut(row, column) [INFO] [stdout] 742 | .map(|location| { [INFO] [stdout] | __________________^ [INFO] [stdout] 743 | | *location = element; [INFO] [stdout] 744 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:772:18 [INFO] [stdout] | [INFO] [stdout] 770 | pub fn set_row_major(&mut self, index: usize, element: T) -> Result<(), Error> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 771 | self.get_mut_row_major(index) [INFO] [stdout] 772 | .map(|location| { [INFO] [stdout] | __________________^ [INFO] [stdout] 773 | | *location = element; [INFO] [stdout] 774 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:802:18 [INFO] [stdout] | [INFO] [stdout] 800 | pub fn set_column_major(&mut self, index: usize, element: T) -> Result<(), Error> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 801 | self.get_mut_column_major(index) [INFO] [stdout] 802 | .map(|location| { [INFO] [stdout] | __________________^ [INFO] [stdout] 803 | | *location = element; [INFO] [stdout] 804 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1255:29 [INFO] [stdout] | [INFO] [stdout] 1255 | .map(|row_iter| row_iter.cloned().collect()) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1281:32 [INFO] [stdout] | [INFO] [stdout] 1281 | .map(|column_iter| column_iter.cloned().collect()) [INFO] [stdout] | ----------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vecgrid` (lib) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "b8a40bb57b276d59923ea88270fdcab65e93b8fd6d35d2d339e1765b88710098", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8a40bb57b276d59923ea88270fdcab65e93b8fd6d35d2d339e1765b88710098", kill_on_drop: false }` [INFO] [stdout] b8a40bb57b276d59923ea88270fdcab65e93b8fd6d35d2d339e1765b88710098