[INFO] fetching crate vec_map 0.8.2... [INFO] checking vec_map-0.8.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vec_map 0.8.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate vec_map 0.8.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vec_map 0.8.2 [INFO] finished tweaking crates.io crate vec_map 0.8.2 [INFO] tweaked toml for crates.io crate vec_map 0.8.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f011a46b313867eaaf0286a9d4dcedd17f0b5dc3c29b1eaa74ef2de7733ac3e9 [INFO] running `Command { std: "docker" "start" "-a" "f011a46b313867eaaf0286a9d4dcedd17f0b5dc3c29b1eaa74ef2de7733ac3e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f011a46b313867eaaf0286a9d4dcedd17f0b5dc3c29b1eaa74ef2de7733ac3e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f011a46b313867eaaf0286a9d4dcedd17f0b5dc3c29b1eaa74ef2de7733ac3e9", kill_on_drop: false }` [INFO] [stdout] f011a46b313867eaaf0286a9d4dcedd17f0b5dc3c29b1eaa74ef2de7733ac3e9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ccf96fdbb32ef071ceb0be6bed69777e0dff265fcbbe9ec4703deb09dd193e5a [INFO] running `Command { std: "docker" "start" "-a" "ccf96fdbb32ef071ceb0be6bed69777e0dff265fcbbe9ec4703deb09dd193e5a", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking vec_map v0.8.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:1010:34 [INFO] [stdout] | [INFO] [stdout] 1010 | fn next(&mut self) -> Option<(&'a V)> { self.iter.next().map(|e| e.1) } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1010 - fn next(&mut self) -> Option<(&'a V)> { self.iter.next().map(|e| e.1) } [INFO] [stdout] 1010 + fn next(&mut self) -> Option<&'a V> { self.iter.next().map(|e| e.1) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:1017:39 [INFO] [stdout] | [INFO] [stdout] 1017 | fn next_back(&mut self) -> Option<(&'a V)> { self.iter.next_back().map(|e| e.1) } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1017 - fn next_back(&mut self) -> Option<(&'a V)> { self.iter.next_back().map(|e| e.1) } [INFO] [stdout] 1017 + fn next_back(&mut self) -> Option<&'a V> { self.iter.next_back().map(|e| e.1) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:1023:34 [INFO] [stdout] | [INFO] [stdout] 1023 | fn next(&mut self) -> Option<(&'a mut V)> { self.iter_mut.next().map(|e| e.1) } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1023 - fn next(&mut self) -> Option<(&'a mut V)> { self.iter_mut.next().map(|e| e.1) } [INFO] [stdout] 1023 + fn next(&mut self) -> Option<&'a mut V> { self.iter_mut.next().map(|e| e.1) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:1010:34 [INFO] [stdout] | [INFO] [stdout] 1010 | fn next(&mut self) -> Option<(&'a V)> { self.iter.next().map(|e| e.1) } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1010 - fn next(&mut self) -> Option<(&'a V)> { self.iter.next().map(|e| e.1) } [INFO] [stdout] 1010 + fn next(&mut self) -> Option<&'a V> { self.iter.next().map(|e| e.1) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:1017:39 [INFO] [stdout] | [INFO] [stdout] 1017 | fn next_back(&mut self) -> Option<(&'a V)> { self.iter.next_back().map(|e| e.1) } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1017 - fn next_back(&mut self) -> Option<(&'a V)> { self.iter.next_back().map(|e| e.1) } [INFO] [stdout] 1017 + fn next_back(&mut self) -> Option<&'a V> { self.iter.next_back().map(|e| e.1) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/lib.rs:1023:34 [INFO] [stdout] | [INFO] [stdout] 1023 | fn next(&mut self) -> Option<(&'a mut V)> { self.iter_mut.next().map(|e| e.1) } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1023 - fn next(&mut self) -> Option<(&'a mut V)> { self.iter_mut.next().map(|e| e.1) } [INFO] [stdout] 1023 + fn next(&mut self) -> Option<&'a mut V> { self.iter_mut.next().map(|e| e.1) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:691:9 [INFO] [stdout] | [INFO] [stdout] 689 | pub fn insert(&mut self, value: V) -> V { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 690 | let index = self.index; [INFO] [stdout] 691 | self.map.insert(index, value).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:776:19 [INFO] [stdout] | [INFO] [stdout] 772 | fn into_iter(self) -> IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 776 | iter: self.v.into_iter().enumerate() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vec_map` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:691:9 [INFO] [stdout] | [INFO] [stdout] 689 | pub fn insert(&mut self, value: V) -> V { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 690 | let index = self.index; [INFO] [stdout] 691 | self.map.insert(index, value).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:776:19 [INFO] [stdout] | [INFO] [stdout] 772 | fn into_iter(self) -> IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 776 | iter: self.v.into_iter().enumerate() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vec_map` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ccf96fdbb32ef071ceb0be6bed69777e0dff265fcbbe9ec4703deb09dd193e5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ccf96fdbb32ef071ceb0be6bed69777e0dff265fcbbe9ec4703deb09dd193e5a", kill_on_drop: false }` [INFO] [stdout] ccf96fdbb32ef071ceb0be6bed69777e0dff265fcbbe9ec4703deb09dd193e5a