[INFO] fetching crate vdf-reader 0.2.0... [INFO] checking vdf-reader-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vdf-reader 0.2.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate vdf-reader 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vdf-reader 0.2.0 [INFO] finished tweaking crates.io crate vdf-reader 0.2.0 [INFO] tweaked toml for crates.io crate vdf-reader 0.2.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate vdf-reader 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f267f852153ab8b6074cdac79bf57202f237236c8f1f022f03aed0a9efcfc024 [INFO] running `Command { std: "docker" "start" "-a" "f267f852153ab8b6074cdac79bf57202f237236c8f1f022f03aed0a9efcfc024", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f267f852153ab8b6074cdac79bf57202f237236c8f1f022f03aed0a9efcfc024", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f267f852153ab8b6074cdac79bf57202f237236c8f1f022f03aed0a9efcfc024", kill_on_drop: false }` [INFO] [stdout] f267f852153ab8b6074cdac79bf57202f237236c8f1f022f03aed0a9efcfc024 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c54520e479b9e7ecca794d2819fef64a9b926b4ac746287a197f0e388331edf [INFO] running `Command { std: "docker" "start" "-a" "8c54520e479b9e7ecca794d2819fef64a9b926b4ac746287a197f0e388331edf", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Compiling cc v1.0.96 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling serde v1.0.200 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking supports-color v3.0.0 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking supports-hyperlinks v3.0.0 [INFO] [stderr] Checking supports-unicode v3.0.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking similar v2.5.0 [INFO] [stderr] Compiling logos-codegen v0.14.0 [INFO] [stderr] Compiling test-case-core v3.3.1 [INFO] [stderr] Checking backtrace-ext v0.2.1 [INFO] [stderr] Compiling regex v1.10.4 [INFO] [stderr] Compiling structmeta-derive v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.200 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Compiling miette-derive v7.2.0 [INFO] [stderr] Compiling test-case-macros v3.3.1 [INFO] [stderr] Compiling logos-derive v0.14.0 [INFO] [stderr] Checking test-case v3.3.1 [INFO] [stderr] Checking logos v0.14.0 [INFO] [stderr] Compiling structmeta v0.3.0 [INFO] [stderr] Compiling parse-display-derive v0.9.0 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Checking parse-display v0.9.0 [INFO] [stderr] Checking ron v0.7.1 [INFO] [stderr] Checking vdf-reader v0.2.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking insta v1.38.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entry/mod.rs:654:17 [INFO] [stdout] | [INFO] [stdout] 650 | fn variant_seed(self, seed: V) -> Result<(V::Value, Self::Variant), Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 654 | seed.deserialize(self.variant) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entry/array.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 71 | fn next_element_seed(&mut self, seed: T) -> Result, Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | seed.deserialize(next).map(Some) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entry/table.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 147 | fn next_key_seed(&mut self, seed: K) -> std::result::Result, Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | seed.deserialize(Value::from(key)).map(Some) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entry/value.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 72 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | deserializer.deserialize_str(ValueVisitor).map(Value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entry/value.rs:318:13 [INFO] [stdout] | [INFO] [stdout] 314 | fn deserialize_seq(self, _visitor: V) -> Result [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | Err(SerdeParseError::new("seq", self.0.as_ref(), 0..0, "").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entry/value.rs:344:13 [INFO] [stdout] | [INFO] [stdout] 340 | fn deserialize_map(self, _visitor: V) -> Result [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | Err(SerdeParseError::new("map", self.0.as_ref(), 0..0, "").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entry/value.rs:356:13 [INFO] [stdout] | [INFO] [stdout] 351 | _visitor: V, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | Err(SerdeParseError::new("struct", self.0.as_ref(), 0..0, "").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entry/value.rs:368:13 [INFO] [stdout] | [INFO] [stdout] 363 | _visitor: V, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 368 | Err(SerdeParseError::new("map", self.0.as_ref(), 0..0, "").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:418:9 [INFO] [stdout] | [INFO] [stdout] 414 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 418 | / self.ok_or_else(|| { [INFO] [stdout] 419 | | NoValidTokenError::new(expected, (source.len()..source.len()).into(), source.into()) [INFO] [stdout] 420 | | .into() [INFO] [stdout] 421 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | T::from_str(str.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde.rs:435:9 [INFO] [stdout] | [INFO] [stdout] 429 | visitor: V, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 435 | / visitor [INFO] [stdout] 436 | | .visit_enum(Enum::new(self)) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde.rs:538:9 [INFO] [stdout] | [INFO] [stdout] 524 | fn next_key_seed(&mut self, seed: K) -> Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 533 | Err(e) => return Err(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 538 | seed.deserialize(&mut *self.de).map(Some) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde.rs:653:12 [INFO] [stdout] | [INFO] [stdout] 632 | seed: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 650 | let val = seed [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 653 | Ok(Some(val)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde.rs:694:12 [INFO] [stdout] | [INFO] [stdout] 680 | fn variant_seed(mut self, seed: V) -> Result<(V::Value, Self::Variant)> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 693 | let val = seed.deserialize(&mut *self.de)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 694 | Ok((val, self)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vdf-reader` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8c54520e479b9e7ecca794d2819fef64a9b926b4ac746287a197f0e388331edf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c54520e479b9e7ecca794d2819fef64a9b926b4ac746287a197f0e388331edf", kill_on_drop: false }` [INFO] [stdout] 8c54520e479b9e7ecca794d2819fef64a9b926b4ac746287a197f0e388331edf