[INFO] fetching crate vcsr 0.4.0... [INFO] checking vcsr-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vcsr 0.4.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate vcsr 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vcsr 0.4.0 [INFO] finished tweaking crates.io crate vcsr 0.4.0 [INFO] tweaked toml for crates.io crate vcsr 0.4.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate vcsr 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2bf8142e8d3e8bb30f80cede1dde88dec99cddc45e7395b57182d1469d453635 [INFO] running `Command { std: "docker" "start" "-a" "2bf8142e8d3e8bb30f80cede1dde88dec99cddc45e7395b57182d1469d453635", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2bf8142e8d3e8bb30f80cede1dde88dec99cddc45e7395b57182d1469d453635", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2bf8142e8d3e8bb30f80cede1dde88dec99cddc45e7395b57182d1469d453635", kill_on_drop: false }` [INFO] [stdout] 2bf8142e8d3e8bb30f80cede1dde88dec99cddc45e7395b57182d1469d453635 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 14c522a47242ac32c4c7241fbc9a3278b18924a690ccfcc3511704ffa362f901 [INFO] running `Command { std: "docker" "start" "-a" "14c522a47242ac32c4c7241fbc9a3278b18924a690ccfcc3511704ffa362f901", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling rand_core v0.4.2 [INFO] [stderr] Compiling proc-macro2 v1.0.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v1.0.11 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling getrandom v0.1.11 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling cc v1.0.41 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling siphasher v0.2.3 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_core v0.3.1 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling rand_hc v0.1.0 [INFO] [stderr] Compiling rand_xorshift v0.1.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling rand_isaac v0.1.1 [INFO] [stderr] Compiling rand_jitter v0.1.4 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling num-bigint v0.3.3 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Compiling phf_shared v0.7.24 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Checking regex-syntax v0.6.11 [INFO] [stderr] Compiling backtrace-sys v0.1.31 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Compiling rand_os v0.1.3 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling matrixmultiply v0.1.15 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Checking weezl v0.1.5 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Compiling num-complex v0.2.3 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Checking ttf-parser v0.6.2 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Compiling serde v1.0.99 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Checking rawpointer v0.1.0 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Compiling unicode-segmentation v1.3.0 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking gif v0.11.2 [INFO] [stderr] Checking backtrace v0.3.35 [INFO] [stderr] Checking num-complex v0.3.1 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Checking clicolors-control v1.0.1 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Checking lock_api v0.3.1 [INFO] [stderr] Checking owned_ttf_parser v0.6.0 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Checking bytemuck v1.7.2 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.4 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling palette v0.4.1 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking rusttype v0.9.2 [INFO] [stderr] Checking conv v0.3.3 [INFO] [stderr] Checking chrono v0.4.8 [INFO] [stderr] Checking rulinalg v0.4.2 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking phf v0.7.24 [INFO] [stderr] Checking number_prefix v0.2.8 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking strength_reduce v0.2.2 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking transpose v0.1.0 [INFO] [stderr] Checking approx v0.1.1 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking yansi v0.5.0 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking rand_distr v0.2.2 [INFO] [stderr] Checking rustfft v3.0.0 [INFO] [stderr] Checking exitcode v1.1.2 [INFO] [stderr] Checking humantime v1.2.0 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Checking regex v1.2.1 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking num v0.3.1 [INFO] [stderr] Compiling palette_derive v0.4.1 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking console v0.8.0 [INFO] [stderr] Checking flexi_logger v0.14.3 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Compiling proc-macro-error v0.2.6 [INFO] [stderr] Checking dotenv v0.14.1 [INFO] [stderr] Checking indicatif v0.11.0 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Compiling serde_derive v1.0.99 [INFO] [stderr] Compiling thiserror-impl v1.0.20 [INFO] [stderr] Compiling structopt-derive v0.3.0 [INFO] [stderr] Checking thiserror v1.0.20 [INFO] [stderr] Checking structopt v0.3.0 [INFO] [stderr] Checking imageproc v0.22.0 [INFO] [stderr] Checking serde_json v1.0.40 [INFO] [stderr] Checking vcsr v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/models.rs:542:31 [INFO] [stdout] | [INFO] [stdout] 542 | matrix_subset[(length - 1)] / 2.0 [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 542 - matrix_subset[(length - 1)] / 2.0 [INFO] [stdout] 542 + matrix_subset[length - 1] / 2.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/models.rs:542:31 [INFO] [stdout] | [INFO] [stdout] 542 | matrix_subset[(length - 1)] / 2.0 [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 542 - matrix_subset[(length - 1)] / 2.0 [INFO] [stdout] 542 + matrix_subset[length - 1] / 2.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/operations.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | &time_sorted.sort_by(|a, b| a.timestamp.partial_cmp(&b.timestamp).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 124 | let _ = &time_sorted.sort_by(|a, b| a.timestamp.partial_cmp(&b.timestamp).unwrap()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/operations.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | &time_sorted.sort_by(|a, b| a.timestamp.partial_cmp(&b.timestamp).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 124 | let _ = &time_sorted.sort_by(|a, b| a.timestamp.partial_cmp(&b.timestamp).unwrap()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:89:46 [INFO] [stdout] | [INFO] [stdout] 85 | let bar = multi.add(ProgressBar::new(1)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let _ = pool.spawn(move || match process_file(&entry, &mut current_args) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vcsr` (bin "vcsr" test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:89:46 [INFO] [stdout] | [INFO] [stdout] 85 | let bar = multi.add(ProgressBar::new(1)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let _ = pool.spawn(move || match process_file(&entry, &mut current_args) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vcsr` (bin "vcsr") due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "14c522a47242ac32c4c7241fbc9a3278b18924a690ccfcc3511704ffa362f901", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14c522a47242ac32c4c7241fbc9a3278b18924a690ccfcc3511704ffa362f901", kill_on_drop: false }` [INFO] [stdout] 14c522a47242ac32c4c7241fbc9a3278b18924a690ccfcc3511704ffa362f901