[INFO] fetching crate vcontrol 0.3.4... [INFO] checking vcontrol-0.3.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vcontrol 0.3.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate vcontrol 0.3.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vcontrol 0.3.4 [INFO] finished tweaking crates.io crate vcontrol 0.3.4 [INFO] tweaked toml for crates.io crate vcontrol 0.3.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate vcontrol 0.3.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a0c046fac94119a124e62d790509b3e80f737c1ac5ae8aff38753fd607fcda06 [INFO] running `Command { std: "docker" "start" "-a" "a0c046fac94119a124e62d790509b3e80f737c1ac5ae8aff38753fd607fcda06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a0c046fac94119a124e62d790509b3e80f737c1ac5ae8aff38753fd607fcda06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0c046fac94119a124e62d790509b3e80f737c1ac5ae8aff38753fd607fcda06", kill_on_drop: false }` [INFO] [stdout] a0c046fac94119a124e62d790509b3e80f737c1ac5ae8aff38753fd607fcda06 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f6923e8309d46b975c8d6333b75c8becc63aae88d4d3e5b583e9dbf50775c718 [INFO] running `Command { std: "docker" "start" "-a" "f6923e8309d46b975c8d6333b75c8becc63aae88d4d3e5b583e9dbf50775c718", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.67 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling syn v1.0.16 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling ppv-lite86 v0.2.6 [INFO] [stderr] Compiling siphasher v0.3.1 [INFO] [stderr] Compiling linked-hash-map v0.5.2 [INFO] [stderr] Compiling dtoa v0.4.5 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking phf_shared v0.8.0 [INFO] [stderr] Checking phf v0.8.0 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling yaml-rust v0.4.3 [INFO] [stderr] Checking serial-core v0.4.0 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking ioctl-rs v0.1.6 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Checking serial v0.4.0 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Compiling rand_pcg v0.2.1 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Compiling phf_generator v0.8.0 [INFO] [stderr] Compiling phf_codegen v0.8.0 [INFO] [stderr] Compiling thiserror-impl v1.0.11 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling serde_yaml v0.8.11 [INFO] [stderr] Compiling thiserror v1.0.11 [INFO] [stderr] Compiling yaml-merge-keys v0.4.0 [INFO] [stderr] Compiling vcontrol v0.3.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait `ToBytes` is never used [INFO] [stdout] --> src/types/mod.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | pub(crate) trait ToBytes { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/optolink.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn open(port: impl AsRef) -> io::Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let mut tty = serial::open(&port) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(Optolink { device: Device::Tty(tty), timeout: None }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/optolink.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn connect(addr: impl ToSocketAddrs) -> io::Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let stream = TcpStream::connect(&addrs as &[SocketAddr]) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Ok(Optolink { device: Device::Stream(stream), timeout: None }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vcontrol.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn connect(mut device: Optolink) -> Result, Error> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | D::Protocol::negotiate(&mut device)?; [INFO] [stdout] 12 | Ok(VControl { device, phantom: std::marker::PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vcontrol` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/optolink.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn open(port: impl AsRef) -> io::Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let mut tty = serial::open(&port) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(Optolink { device: Device::Tty(tty), timeout: None }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/optolink.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn connect(addr: impl ToSocketAddrs) -> io::Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let stream = TcpStream::connect(&addrs as &[SocketAddr]) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Ok(Optolink { device: Device::Stream(stream), timeout: None }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vcontrol.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn connect(mut device: Optolink) -> Result, Error> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | D::Protocol::negotiate(&mut device)?; [INFO] [stdout] 12 | Ok(VControl { device, phantom: std::marker::PhantomData }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vcontrol` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "f6923e8309d46b975c8d6333b75c8becc63aae88d4d3e5b583e9dbf50775c718", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f6923e8309d46b975c8d6333b75c8becc63aae88d4d3e5b583e9dbf50775c718", kill_on_drop: false }` [INFO] [stdout] f6923e8309d46b975c8d6333b75c8becc63aae88d4d3e5b583e9dbf50775c718