[INFO] fetching crate vaultssh 0.1.1... [INFO] checking vaultssh-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vaultssh 0.1.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate vaultssh 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vaultssh 0.1.1 [INFO] finished tweaking crates.io crate vaultssh 0.1.1 [INFO] tweaked toml for crates.io crate vaultssh 0.1.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate vaultssh 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 57ea151acfc124d1ffc81cd2b1e391c78af41b0c7abd41ba8f851e0c4c24fb14 [INFO] running `Command { std: "docker" "start" "-a" "57ea151acfc124d1ffc81cd2b1e391c78af41b0c7abd41ba8f851e0c4c24fb14", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "57ea151acfc124d1ffc81cd2b1e391c78af41b0c7abd41ba8f851e0c4c24fb14", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "57ea151acfc124d1ffc81cd2b1e391c78af41b0c7abd41ba8f851e0c4c24fb14", kill_on_drop: false }` [INFO] [stdout] 57ea151acfc124d1ffc81cd2b1e391c78af41b0c7abd41ba8f851e0c4c24fb14 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a93682cf32edfa5f95b80c67d053cb0febe18cbd67ce8ee6638dc4e9749a8e07 [INFO] running `Command { std: "docker" "start" "-a" "a93682cf32edfa5f95b80c67d053cb0febe18cbd67ce8ee6638dc4e9749a8e07", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling syn v1.0.75 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling cc v1.0.69 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking tracing-core v0.1.19 [INFO] [stderr] Checking instant v0.1.10 [INFO] [stderr] Compiling futures-channel v0.3.17 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking futures-sink v0.3.17 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Compiling tokio v1.11.0 [INFO] [stderr] Compiling futures-util v0.3.17 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Checking futures-io v0.3.17 [INFO] [stderr] Checking slab v0.4.4 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking http v0.2.4 [INFO] [stderr] Compiling anyhow v1.0.43 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking tinyvec v1.3.1 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking unicode-bidi v0.3.6 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking httpdate v1.0.1 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling rustversion v1.0.5 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling serde_json v1.0.67 [INFO] [stderr] Checking parking_lot_core v0.8.5 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking socket2 v0.4.1 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Compiling encoding_rs v0.8.28 [INFO] [stderr] Compiling typenum v1.14.0 [INFO] [stderr] Compiling async-trait v0.1.51 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking predicates-core v1.0.2 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking ipnet v2.3.1 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling siphasher v0.3.7 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking predicates-tree v1.0.3 [INFO] [stderr] Checking http-body v0.4.3 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking block-padding v0.1.5 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Compiling dockertest v0.2.1 [INFO] [stderr] Checking float-cmp v0.8.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking sharded-slab v0.1.3 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking bstr v0.2.16 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking ascii v1.0.0 [INFO] [stderr] Checking chunked_transfer v1.4.0 [INFO] [stderr] Checking predicates v1.0.8 [INFO] [stderr] Checking console v0.14.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking zeroize v1.4.1 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Checking dyn-clone v1.0.4 [INFO] [stderr] Checking globset v0.4.8 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking fragile v1.0.0 [INFO] [stderr] Checking sha2 v0.8.2 [INFO] [stderr] Checking downcast v0.10.0 [INFO] [stderr] Checking os_str_bytes v3.1.0 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Checking dialoguer v0.8.0 [INFO] [stderr] Checking dirs v3.0.2 [INFO] [stderr] Checking shellexpand v2.1.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking rpassword v5.0.1 [INFO] [stderr] Checking sshkeys v0.3.1 [INFO] [stderr] Checking webbrowser v0.5.5 [INFO] [stderr] Checking text_io v0.1.9 [INFO] [stderr] Checking predicates v2.0.2 [INFO] [stderr] Checking ignore v0.4.18 [INFO] [stderr] Checking assert_cmd v2.0.1 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking globwalk v0.8.1 [INFO] [stderr] Checking ct-logs v0.8.0 [INFO] [stderr] Checking assert_fs v1.0.5 [INFO] [stderr] Checking rustls v0.19.1 [INFO] [stderr] Checking webpki-roots v0.21.1 [INFO] [stderr] Compiling darling_core v0.13.0 [INFO] [stderr] Compiling darling_core v0.12.4 [INFO] [stderr] Compiling synstructure v0.12.5 [INFO] [stderr] Compiling tokio-macros v1.3.0 [INFO] [stderr] Compiling tracing-attributes v0.1.15 [INFO] [stderr] Compiling futures-macro v0.3.17 [INFO] [stderr] Compiling thiserror-impl v1.0.28 [INFO] [stderr] Compiling pin-project-internal v1.0.8 [INFO] [stderr] Compiling rustify_derive v0.4.3 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.4 [INFO] [stderr] Compiling mockall_derive v0.10.2 [INFO] [stderr] Compiling phf_macros v0.10.0 [INFO] [stderr] Compiling darling_macro v0.13.0 [INFO] [stderr] Checking tracing v0.1.26 [INFO] [stderr] Checking thiserror v1.0.28 [INFO] [stderr] Checking pin-project v1.0.8 [INFO] [stderr] Checking phf v0.10.0 [INFO] [stderr] Compiling darling v0.13.0 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Compiling darling_macro v0.12.4 [INFO] [stderr] Compiling serde_with_macros v1.4.2 [INFO] [stderr] Checking clap v3.0.0-beta.4 [INFO] [stderr] Compiling darling v0.12.4 [INFO] [stderr] Compiling derive_builder_core v0.10.2 [INFO] [stderr] Compiling derive_builder_macro v0.10.2 [INFO] [stderr] Checking mockall v0.10.2 [INFO] [stderr] Checking derive_builder v0.10.2 [INFO] [stderr] Checking futures-executor v0.3.17 [INFO] [stderr] Checking futures v0.3.17 [INFO] [stderr] Checking tokio-util v0.6.7 [INFO] [stderr] Checking tokio-rustls v0.22.0 [INFO] [stderr] Checking h2 v0.3.4 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking serde_urlencoded v0.7.0 [INFO] [stderr] Checking serde_with v1.9.4 [INFO] [stderr] Checking tracing-serde v0.1.2 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking hyper v0.14.12 [INFO] [stderr] Checking tiny_http v0.8.2 [INFO] [stderr] Checking tracing-subscriber v0.2.20 [INFO] [stderr] Checking bollard-stubs v1.41.0 [INFO] [stderr] Checking hyper-rustls v0.22.1 [INFO] [stderr] Checking hyper-unix-connector v0.2.2 [INFO] [stderr] Checking reqwest v0.11.4 [INFO] [stderr] Checking rustify v0.4.4 [INFO] [stderr] Checking vaultrs v0.5.3 [INFO] [stderr] Checking bollard v0.10.1 [INFO] [stderr] Checking vaultrs-login v0.1.3 [INFO] [stderr] Checking vaultssh v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 146 | / /// default authentication method to use [INFO] [stdout] 147 | | #[clap(short = 'a', long = "auth-method")] [INFO] [stdout] 148 | | auth: Option, [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:352:32 [INFO] [stdout] | [INFO] [stdout] 352 | .map_err(|e| anyhow! { ClientError::FileReadError { source: e, path: path_str}}) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:359:32 [INFO] [stdout] | [INFO] [stdout] 359 | .map_err(|e| anyhow! { ClientError::FileWriteError { source: e, path: path_str}}) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | toml::from_str::(content.as_str()).map_err(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 69 | let mut inp = Input::with_theme(&self.theme); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | / inp.with_prompt(prompt) [INFO] [stdout] 75 | | .with_initial_text(text.unwrap_or_else(|| String::from(""))) [INFO] [stdout] 76 | | .interact() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/login.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 71 | return Err(anyhow! { ClientError::FileNotFound { [INFO] [stdout] | ____________________________- [INFO] [stdout] 72 | | path: "$HOME".to_string(), [INFO] [stdout] 73 | | }}) [INFO] [stdout] | |__________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | std::fs::read_to_string(token_file).map_err(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/login.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 97 | return Err(anyhow! { ClientError::FileNotFound { [INFO] [stdout] | ____________________________- [INFO] [stdout] 98 | | path: "$HOME".to_string(), [INFO] [stdout] 99 | | }}) [INFO] [stdout] | |__________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | std::fs::write(token_file, self.settings().token.clone()).map_err(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ssh.rs:28:32 [INFO] [stdout] | [INFO] [stdout] 28 | .map_err(|e| anyhow! { ClientError::SSHParseError { source: e } }) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vaultssh` (bin "vssh") due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a93682cf32edfa5f95b80c67d053cb0febe18cbd67ce8ee6638dc4e9749a8e07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a93682cf32edfa5f95b80c67d053cb0febe18cbd67ce8ee6638dc4e9749a8e07", kill_on_drop: false }` [INFO] [stdout] a93682cf32edfa5f95b80c67d053cb0febe18cbd67ce8ee6638dc4e9749a8e07