[INFO] fetching crate vapcore-stratum 1.12.0... [INFO] checking vapcore-stratum-1.12.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate vapcore-stratum 1.12.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate vapcore-stratum 1.12.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vapcore-stratum 1.12.0 [INFO] finished tweaking crates.io crate vapcore-stratum 1.12.0 [INFO] tweaked toml for crates.io crate vapcore-stratum 1.12.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 129 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bitvec v0.17.4 (latest: v1.0.1) [INFO] [stderr] Adding byte-slice-cast v0.3.5 (latest: v1.2.2) [INFO] [stderr] Adding bytes v0.4.12 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding crossbeam-deque v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding crossbeam-epoch v0.8.2 (latest: v0.9.18) [INFO] [stderr] Adding crossbeam-queue v0.2.3 (latest: v0.3.11) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (latest: v0.8.20) [INFO] [stderr] Adding env_logger v0.5.13 (latest: v0.11.5) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding memoffset v0.5.6 (latest: v0.9.1) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding parking_lot v0.9.0 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot v0.10.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.6.3 (latest: v0.9.10) [INFO] [stderr] Adding parking_lot_core v0.7.3 (latest: v0.9.10) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding radium v0.3.0 (latest: v1.1.0) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding tetsy-fixed-hash v0.5.0 (latest: v0.7.1) [INFO] [stderr] Adding tetsy-impl-codec v0.4.1 (latest: v0.5.1) [INFO] [stderr] Adding tetsy-impl-rlp v0.2.0 (latest: v0.3.1) [INFO] [stderr] Adding tetsy-impl-serde v0.2.2 (latest: v0.3.2) [INFO] [stderr] Adding tetsy-jsonrpc-core v14.2.1 (latest: v15.1.0) [INFO] [stderr] Adding tetsy-jsonrpc-server-utils v14.2.1 (latest: v15.1.0) [INFO] [stderr] Adding tetsy-jsonrpc-tcp-server v14.2.1 (latest: v15.1.0) [INFO] [stderr] Adding tetsy-keccak-hash v0.4.0 (latest: v0.7.1) [INFO] [stderr] Adding tetsy-primitive-types v0.6.0 (latest: v0.9.1) [INFO] [stderr] Adding tetsy-rlp v0.4.5 (latest: v0.5.1) [INFO] [stderr] Adding tetsy-scale-codec v1.3.0 (latest: v2.0.1) [INFO] [stderr] Adding tiny-keccak v1.5.0 (latest: v2.0.2) [INFO] [stderr] Adding tokio v0.1.22 (latest: v1.40.0) [INFO] [stderr] Adding uint-crate v0.8.1 (latest: v0.9.1) [INFO] [stderr] Adding vapbloom v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding vapory-types v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3dc1f30d00e15e46cac79360a193e70989b98592774ac6f1216f8c2d30a2c062 [INFO] running `Command { std: "docker" "start" "-a" "3dc1f30d00e15e46cac79360a193e70989b98592774ac6f1216f8c2d30a2c062", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3dc1f30d00e15e46cac79360a193e70989b98592774ac6f1216f8c2d30a2c062", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3dc1f30d00e15e46cac79360a193e70989b98592774ac6f1216f8c2d30a2c062", kill_on_drop: false }` [INFO] [stdout] 3dc1f30d00e15e46cac79360a193e70989b98592774ac6f1216f8c2d30a2c062 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 09224bde209ea6718132ea42f282b83da75c9d4cd760e345d0b4a04ceb097fdc [INFO] running `Command { std: "docker" "start" "-a" "09224bde209ea6718132ea42f282b83da75c9d4cd760e345d0b4a04ceb097fdc", kill_on_drop: false }` [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking rustc-hex v2.1.0 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking radium v0.3.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking byte-slice-cast v0.3.5 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tetsy-impl-serde v0.2.2 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking tetsy-rlp v0.4.5 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking parking_lot_core v0.7.3 [INFO] [stderr] Checking tetsy-jsonrpc-core v14.2.1 [INFO] [stderr] Checking tetsy-impl-rlp v0.2.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking bitvec v0.17.4 [INFO] [stderr] Checking uint-crate v0.8.1 [INFO] [stderr] Checking tiny-keccak v1.5.0 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tokio-udp v0.1.6 [INFO] [stderr] Checking tokio-uds v0.2.7 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stderr] Checking tetsy-scale-codec v1.3.0 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking tetsy-fixed-hash v0.5.0 [INFO] [stderr] Checking vapbloom v0.8.0 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tetsy-jsonrpc-server-utils v14.2.1 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking tetsy-jsonrpc-tcp-server v14.2.1 [INFO] [stderr] Checking tetsy-impl-codec v0.4.1 [INFO] [stderr] Checking tetsy-primitive-types v0.6.0 [INFO] [stderr] Checking vapory-types v0.8.0 [INFO] [stderr] Checking tetsy-keccak-hash v0.4.0 [INFO] [stderr] Checking vapcore-stratum v1.12.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:145:6 [INFO] [stdout] | [INFO] [stdout] 138 | fn subscribe(&self, _params: Params, meta: SocketMetadata) -> RpcResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Ok(match self.dispatcher.initial() { [INFO] [stdout] | ____________^ [INFO] [stdout] 146 | | Some(initial) => match tetsy_jsonrpc_core::Value::from_str(&initial) { [INFO] [stdout] 147 | | Ok(val) => Ok(val), [INFO] [stdout] 148 | | Err(e) => { [INFO] [stdout] ... | [INFO] [stdout] 153 | | None => to_value(&[0u8; 0]), [INFO] [stdout] 154 | | }.expect("Empty slices are serializable; qed")) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:159:3 [INFO] [stdout] | [INFO] [stdout] 158 | fn authorize(&self, params: Params, meta: SocketMetadata) -> RpcResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | / params.parse::<(String, String)>().map(|(worker_id, secret)| { [INFO] [stdout] 160 | | if let Some(valid_secret) = self.secret { [INFO] [stdout] 161 | | let hash = keccak(secret); [INFO] [stdout] 162 | | if hash != valid_secret { [INFO] [stdout] ... | [INFO] [stdout] 168 | | to_value(true) [INFO] [stdout] 169 | | }).map(|v| v.expect("Only true/false is returned and it's always serializable; qed")) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:174:6 [INFO] [stdout] | [INFO] [stdout] 173 | fn submit(&self, params: Params, meta: SocketMetadata) -> RpcResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | Ok(match params { [INFO] [stdout] | ____________^ [INFO] [stdout] 175 | | Params::Array(vals) => { [INFO] [stdout] 176 | | // first two elements are service messages (worker_id & job_id) [INFO] [stdout] 177 | | match self.dispatcher.submit(vals.iter().skip(2) [INFO] [stdout] ... | [INFO] [stdout] 196 | | } [INFO] [stdout] 197 | | }.expect("Only true/false is returned and it's always serializable; qed")) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vapcore-stratum` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:145:6 [INFO] [stdout] | [INFO] [stdout] 138 | fn subscribe(&self, _params: Params, meta: SocketMetadata) -> RpcResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Ok(match self.dispatcher.initial() { [INFO] [stdout] | ____________^ [INFO] [stdout] 146 | | Some(initial) => match tetsy_jsonrpc_core::Value::from_str(&initial) { [INFO] [stdout] 147 | | Ok(val) => Ok(val), [INFO] [stdout] 148 | | Err(e) => { [INFO] [stdout] ... | [INFO] [stdout] 153 | | None => to_value(&[0u8; 0]), [INFO] [stdout] 154 | | }.expect("Empty slices are serializable; qed")) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:159:3 [INFO] [stdout] | [INFO] [stdout] 158 | fn authorize(&self, params: Params, meta: SocketMetadata) -> RpcResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | / params.parse::<(String, String)>().map(|(worker_id, secret)| { [INFO] [stdout] 160 | | if let Some(valid_secret) = self.secret { [INFO] [stdout] 161 | | let hash = keccak(secret); [INFO] [stdout] 162 | | if hash != valid_secret { [INFO] [stdout] ... | [INFO] [stdout] 168 | | to_value(true) [INFO] [stdout] 169 | | }).map(|v| v.expect("Only true/false is returned and it's always serializable; qed")) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:174:6 [INFO] [stdout] | [INFO] [stdout] 173 | fn submit(&self, params: Params, meta: SocketMetadata) -> RpcResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | Ok(match params { [INFO] [stdout] | ____________^ [INFO] [stdout] 175 | | Params::Array(vals) => { [INFO] [stdout] 176 | | // first two elements are service messages (worker_id & job_id) [INFO] [stdout] 177 | | match self.dispatcher.submit(vals.iter().skip(2) [INFO] [stdout] ... | [INFO] [stdout] 196 | | } [INFO] [stdout] 197 | | }.expect("Only true/false is returned and it's always serializable; qed")) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:447:18 [INFO] [stdout] | [INFO] [stdout] 444 | .and_then(move |(stream, read_buf0)| { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 447 | Timeout::new(future::ok(stream), ::std::time::Duration::from_millis(100)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:453:18 [INFO] [stdout] | [INFO] [stdout] 419 | let stratum = Stratum::start( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 450 | .and_then(move |stream| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 453 | Timeout::new(future::ok(stream), ::std::time::Duration::from_millis(100)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vapcore-stratum` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "09224bde209ea6718132ea42f282b83da75c9d4cd760e345d0b4a04ceb097fdc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09224bde209ea6718132ea42f282b83da75c9d4cd760e345d0b4a04ceb097fdc", kill_on_drop: false }` [INFO] [stdout] 09224bde209ea6718132ea42f282b83da75c9d4cd760e345d0b4a04ceb097fdc