[INFO] fetching crate van-core 0.2.1... [INFO] checking van-core-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate van-core 0.2.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate van-core 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate van-core 0.2.1 [INFO] finished tweaking crates.io crate van-core 0.2.1 [INFO] tweaked toml for crates.io crate van-core 0.2.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 73 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding cursive v0.18.0 (latest: v0.21.1) [INFO] [stderr] Adding cursive_core v0.3.7 (latest: v0.4.6) [INFO] [stderr] Adding ncurses v5.101.0 (latest: v6.0.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 95a7923f5a909a60be73fa274df19d9b39cbc5ef4033cf067de169f299433b38 [INFO] running `Command { std: "docker" "start" "-a" "95a7923f5a909a60be73fa274df19d9b39cbc5ef4033cf067de169f299433b38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "95a7923f5a909a60be73fa274df19d9b39cbc5ef4033cf067de169f299433b38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95a7923f5a909a60be73fa274df19d9b39cbc5ef4033cf067de169f299433b38", kill_on_drop: false }` [INFO] [stdout] 95a7923f5a909a60be73fa274df19d9b39cbc5ef4033cf067de169f299433b38 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 84ad94468012a19328b9b08d8ef97c17d4a7638ad01a0274f317baafbbdbfb9d [INFO] running `Command { std: "docker" "start" "-a" "84ad94468012a19328b9b08d8ef97c17d4a7638ad01a0274f317baafbbdbfb9d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Compiling libmpv-sys v3.1.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking xi-unicode v0.3.0 [INFO] [stderr] Compiling libmpv v2.0.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling ncurses v5.101.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling enumset_derive v0.10.0 [INFO] [stderr] Checking enumset v1.1.5 [INFO] [stderr] Checking cursive_core v0.3.7 [INFO] [stderr] Checking cursive v0.18.0 [INFO] [stderr] Checking van-core v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `current`, `playing`, and `id` are never read [INFO] [stdout] --> src/mpv.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 36 | pub struct PlayListItem { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 37 | pub filename: String, [INFO] [stdout] 38 | pub current: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 39 | pub playing: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 40 | pub id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlayListItem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 121 | let mut vol_view = TextView::new(format!("vol: {}", DEFAULT_VOL)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let vol_status = Arc::new(vol_view.get_shared_content()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | [INFO] [stdout] 124 | let mut current_song_view = TextView::new("Unknown"); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let current_song_status = Arc::new(current_song_view.get_shared_content()); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | [INFO] [stdout] 127 | let mut current_time_view = TextView::new("-/-"); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let current_time_status = Arc::new(current_time_view.get_shared_content()); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | [INFO] [stdout] 130 | let mut current_artist_view = TextView::new("Unknown"); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | let current_artist_status = Arc::new(current_artist_view.get_shared_content()); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | [INFO] [stdout] 133 | let view = wrap_in_dialog( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | / CurrentStatus { [INFO] [stdout] 149 | | vol: Some(vol_status), [INFO] [stdout] 150 | | current_song_status, [INFO] [stdout] 151 | | current_artist_status, [INFO] [stdout] 152 | | current_time_status, [INFO] [stdout] 153 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:264:5 [INFO] [stdout] | [INFO] [stdout] 263 | fn wrap_in_dialog>(inner: V, title: S, width: Option) -> Dialog { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | / Dialog::around(ResizedView::new( [INFO] [stdout] 265 | | SizeConstraint::AtMost(width.unwrap_or(64)), [INFO] [stdout] 266 | | SizeConstraint::Free, [INFO] [stdout] 267 | | ScrollView::new(inner), [INFO] [stdout] 268 | | )) [INFO] [stdout] 269 | | .padding_lrtb(2, 2, 1, 1) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `van-core` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `current`, `playing`, and `id` are never read [INFO] [stdout] --> src/mpv.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 36 | pub struct PlayListItem { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 37 | pub filename: String, [INFO] [stdout] 38 | pub current: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 39 | pub playing: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 40 | pub id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlayListItem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 121 | let mut vol_view = TextView::new(format!("vol: {}", DEFAULT_VOL)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let vol_status = Arc::new(vol_view.get_shared_content()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | [INFO] [stdout] 124 | let mut current_song_view = TextView::new("Unknown"); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let current_song_status = Arc::new(current_song_view.get_shared_content()); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | [INFO] [stdout] 127 | let mut current_time_view = TextView::new("-/-"); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let current_time_status = Arc::new(current_time_view.get_shared_content()); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | [INFO] [stdout] 130 | let mut current_artist_view = TextView::new("Unknown"); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | let current_artist_status = Arc::new(current_artist_view.get_shared_content()); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | [INFO] [stdout] 133 | let view = wrap_in_dialog( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | / CurrentStatus { [INFO] [stdout] 149 | | vol: Some(vol_status), [INFO] [stdout] 150 | | current_song_status, [INFO] [stdout] 151 | | current_artist_status, [INFO] [stdout] 152 | | current_time_status, [INFO] [stdout] 153 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:264:5 [INFO] [stdout] | [INFO] [stdout] 263 | fn wrap_in_dialog>(inner: V, title: S, width: Option) -> Dialog { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | / Dialog::around(ResizedView::new( [INFO] [stdout] 265 | | SizeConstraint::AtMost(width.unwrap_or(64)), [INFO] [stdout] 266 | | SizeConstraint::Free, [INFO] [stdout] 267 | | ScrollView::new(inner), [INFO] [stdout] 268 | | )) [INFO] [stdout] 269 | | .padding_lrtb(2, 2, 1, 1) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `van-core` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "84ad94468012a19328b9b08d8ef97c17d4a7638ad01a0274f317baafbbdbfb9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "84ad94468012a19328b9b08d8ef97c17d4a7638ad01a0274f317baafbbdbfb9d", kill_on_drop: false }` [INFO] [stdout] 84ad94468012a19328b9b08d8ef97c17d4a7638ad01a0274f317baafbbdbfb9d