[INFO] fetching crate value-log 1.0.0-pre.1... [INFO] checking value-log-1.0.0-pre.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate value-log 1.0.0-pre.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate value-log 1.0.0-pre.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate value-log 1.0.0-pre.1 [INFO] finished tweaking crates.io crate value-log 1.0.0-pre.1 [INFO] tweaked toml for crates.io crate value-log 1.0.0-pre.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 134 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding quick_cache v0.5.2 (latest: v0.6.6) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4251a95d6520d4445c3f0f7ff081f7d33956b2e8b3731afc52fad9b58e94109b [INFO] running `Command { std: "docker" "start" "-a" "4251a95d6520d4445c3f0f7ff081f7d33956b2e8b3731afc52fad9b58e94109b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4251a95d6520d4445c3f0f7ff081f7d33956b2e8b3731afc52fad9b58e94109b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4251a95d6520d4445c3f0f7ff081f7d33956b2e8b3731afc52fad9b58e94109b", kill_on_drop: false }` [INFO] [stdout] 4251a95d6520d4445c3f0f7ff081f7d33956b2e8b3731afc52fad9b58e94109b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5218522629f3e0b2905f276296829334e0f8805a33e68e4b1cb2c61394a9569c [INFO] running `Command { std: "docker" "start" "-a" "5218522629f3e0b2905f276296829334e0f8805a33e68e4b1cb2c61394a9569c", kill_on_drop: false }` [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking path-dedot v3.1.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling test-log-macros v0.2.16 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking min-max-heap v1.3.0 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking path-absolutize v3.1.1 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking quick_cache v0.5.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking value-log v1.0.0-pre.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key_range.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 54 | let key_min: UserKey = Arc::from(key_min); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let key_max: UserKey = Arc::from(key_max); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | [INFO] [stdout] 61 | Ok(Self::new((key_min, key_max))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 104 | pub(crate) fn recover>(folder: P) -> crate::Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let segments = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let mut map = HashMap::with_capacity(100); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | let trailer = SegmentFileTrailer::from_file(&path)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | Ok(Self(Arc::new(SegmentManifestInner { [INFO] [stdout] | ____________^ [INFO] [stdout] 139 | | path, [INFO] [stdout] 140 | | segments: RwLock::new(segments), [INFO] [stdout] 141 | | }))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/path.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn absolute_path>(path: P) -> PathBuf { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 6 | // TODO: replace with https://doc.rust-lang.org/std/path/fn.absolute.html once stable [INFO] [stdout] 7 | / path.as_ref() [INFO] [stdout] 8 | | .absolutize() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/meta.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 63 | let key_range = KeyRange::deserialize(reader)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | [INFO] [stdout] 65 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | item_count, [INFO] [stdout] 67 | | compressed_bytes, [INFO] [stdout] 68 | | total_uncompressed_bytes, [INFO] [stdout] 69 | | compression, [INFO] [stdout] 70 | | key_range, [INFO] [stdout] 71 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/multi_writer.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 29 | id_generator: IdGenerator, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | target_size: u64, [INFO] [stdout] 31 | folder: P, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | index_writer: W, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | id_generator, [INFO] [stdout] 42 | | folder: folder.into(), [INFO] [stdout] 43 | | target_size, [INFO] [stdout] ... | [INFO] [stdout] 48 | | compression, [INFO] [stdout] 49 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/multi_writer.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 131 | pub(crate) fn finish(mut self) -> crate::Result<(Vec, W)> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Ok((self.writers, self.index_writer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/reader.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 23 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let file_reader = BufReader::new(File::open(path)?); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | [INFO] [stdout] 30 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 31 | | segment_id, [INFO] [stdout] 32 | | inner: file_reader, [INFO] [stdout] 33 | | item_count, [INFO] [stdout] 34 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/reader.rs:89:14 [INFO] [stdout] | [INFO] [stdout] 48 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Some(Ok((key, val))) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/trailer.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn from_file>(path: P) -> crate::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let mut reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let metadata = Metadata::deserialize(&mut reader)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | [INFO] [stdout] 49 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 50 | | metadata, [INFO] [stdout] 51 | | metadata_ptr, [INFO] [stdout] 52 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/writer.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 39 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let file = File::create(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | [INFO] [stdout] 47 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | path: path.into(), [INFO] [stdout] 49 | | segment_id, [INFO] [stdout] 50 | | writer: BufWriter::new(file), [INFO] [stdout] ... | [INFO] [stdout] 59 | | compression, [INFO] [stdout] 60 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_log.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 89 | pub(crate) fn create_new>(path: P, config: Config) -> crate::Result { [INFO] [stdout] | ------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let mut file = std::fs::File::create(marker_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let blob_cache = config.blob_cache.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let manifest = SegmentManifest::create_new(&path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | [INFO] [stdout] 121 | Ok(Self(Arc::new(ValueLogInner { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | id: get_next_vlog_id(), [INFO] [stdout] 123 | | config, [INFO] [stdout] 124 | | path, [INFO] [stdout] ... | [INFO] [stdout] 128 | | rollover_guard: Mutex::new(()), [INFO] [stdout] 129 | | }))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_log.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 132 | pub(crate) fn recover>(path: P, config: Config) -> crate::Result { [INFO] [stdout] | ------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | let blob_cache = config.blob_cache.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let manifest = SegmentManifest::recover(&path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | Ok(Self(Arc::new(ValueLogInner { [INFO] [stdout] | ____________^ [INFO] [stdout] 161 | | id: get_next_vlog_id(), [INFO] [stdout] 162 | | config, [INFO] [stdout] 163 | | path, [INFO] [stdout] ... | [INFO] [stdout] 167 | | rollover_guard: Mutex::new(()), [INFO] [stdout] 168 | | }))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_log.rs:229:12 [INFO] [stdout] | [INFO] [stdout] 192 | let Some(segment) = self.manifest.get_segment(handle.segment_id) else { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | let mut reader = BufReader::new(File::open(&segment.path)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | let val: UserValue = value.into(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | Ok(Some(val)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_log.rs:238:12 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn get_writer(&self, index_writer: W) -> crate::Result> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | Ok(SegmentWriter::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 239 | | self.id_generator.clone(), [INFO] [stdout] 240 | | self.config.segment_size_bytes, [INFO] [stdout] 241 | | self.path.join(SEGMENTS_FOLDER), [INFO] [stdout] 242 | | index_writer, [INFO] [stdout] 243 | | self.config.compression, [INFO] [stdout] 244 | | )?) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_log.rs:383:34 [INFO] [stdout] | [INFO] [stdout] 382 | let (handle, size) = handle.map_err(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | crate::Error::Io(std::io::Error::new( [INFO] [stdout] | __________________________________^ [INFO] [stdout] 384 | | std::io::ErrorKind::Other, [INFO] [stdout] 385 | | "Index returned error", [INFO] [stdout] 386 | | )) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_log.rs:467:12 [INFO] [stdout] | [INFO] [stdout] 460 | let segments = self.manifest.segments.read().expect("lock is poisoned"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 461 | [INFO] [stdout] 462 | let readers = segments [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 467 | Ok(MergeReader::new(readers)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `value-log` (lib) due to 17 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5218522629f3e0b2905f276296829334e0f8805a33e68e4b1cb2c61394a9569c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5218522629f3e0b2905f276296829334e0f8805a33e68e4b1cb2c61394a9569c", kill_on_drop: false }` [INFO] [stdout] 5218522629f3e0b2905f276296829334e0f8805a33e68e4b1cb2c61394a9569c