[INFO] fetching crate valu3-parquet 0.4.5... [INFO] checking valu3-parquet-0.4.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate valu3-parquet 0.4.5 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate valu3-parquet 0.4.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate valu3-parquet 0.4.5 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate valu3-parquet 0.4.5 [INFO] tweaked toml for crates.io crate valu3-parquet 0.4.5 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate valu3-parquet 0.4.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 31bf222f277f29e659f314d7be06d099a47e0185056eb1030772049a547399ea [INFO] running `Command { std: "docker" "start" "-a" "31bf222f277f29e659f314d7be06d099a47e0185056eb1030772049a547399ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "31bf222f277f29e659f314d7be06d099a47e0185056eb1030772049a547399ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31bf222f277f29e659f314d7be06d099a47e0185056eb1030772049a547399ea", kill_on_drop: false }` [INFO] [stdout] 31bf222f277f29e659f314d7be06d099a47e0185056eb1030772049a547399ea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f7ebc47d565004cfbcfa78e660226aebb1f6acfed6593d57de0de1a643e4e59b [INFO] running `Command { std: "docker" "start" "-a" "f7ebc47d565004cfbcfa78e660226aebb1f6acfed6593d57de0de1a643e4e59b", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking arrow-schema v50.0.0 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling unicode-ident v1.0.10 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling thiserror v1.0.43 [INFO] [stderr] Compiling semver v1.0.21 [INFO] [stderr] Compiling pkg-config v0.3.29 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking half v2.3.1 [INFO] [stderr] Checking chrono v0.4.33 [INFO] [stderr] Compiling jobserver v0.1.28 [INFO] [stderr] Checking num-iter v0.1.44 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Compiling flatbuffers v23.5.26 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling zstd-safe v7.0.0 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling zstd-sys v2.0.9+zstd.1.5.5 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking indexmap v2.2.2 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking num v0.4.1 [INFO] [stderr] Checking brotli-decompressor v2.5.1 [INFO] [stderr] Checking arrow-buffer v50.0.0 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking integer-encoding v3.0.4 [INFO] [stderr] Checking arrow-data v50.0.0 [INFO] [stderr] Checking lz4_flex v0.11.2 [INFO] [stderr] Checking thrift v0.17.0 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Compiling seq-macro v0.3.5 [INFO] [stderr] Checking brotli v3.4.0 [INFO] [stderr] Checking arrow-array v50.0.0 [INFO] [stderr] Compiling thiserror-impl v1.0.43 [INFO] [stderr] Compiling valu3-derive v0.4.5 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling pest v2.7.6 [INFO] [stderr] Checking arrow-select v50.0.0 [INFO] [stderr] Checking arrow-row v50.0.0 [INFO] [stderr] Checking arrow-arith v50.0.0 [INFO] [stderr] Checking arrow-cast v50.0.0 [INFO] [stderr] Checking arrow-string v50.0.0 [INFO] [stderr] Checking arrow-ipc v50.0.0 [INFO] [stderr] Checking arrow-csv v50.0.0 [INFO] [stderr] Checking arrow-json v50.0.0 [INFO] [stderr] Checking arrow-ord v50.0.0 [INFO] [stderr] Compiling pest_meta v2.7.0 [INFO] [stderr] Compiling pest_generator v2.7.0 [INFO] [stderr] Checking arrow v50.0.0 [INFO] [stderr] Compiling pest_derive v2.7.0 [INFO] [stderr] Checking valu3 v0.4.4 [INFO] [stderr] Checking zstd v0.13.0 [INFO] [stderr] Checking parquet v50.0.0 [INFO] [stderr] Checking valu3-parquet v0.4.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `from::*` [INFO] [stdout] --> src/lib.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | pub use from::*; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `from::*` [INFO] [stdout] --> src/lib.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | pub use from::*; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table_record_batch.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 127 | let mut schema_types: Vec = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | [INFO] [stdout] 129 | let mut columns: Vec> = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 295 | let schema = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | let fields = value_table [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | Ok(match RecordBatch::try_new(schema.clone(), columns) { [INFO] [stdout] | ____________^ [INFO] [stdout] 307 | | Ok(record_batch) => Self { [INFO] [stdout] 308 | | record_batch, [INFO] [stdout] 309 | | schema, [INFO] [stdout] ... | [INFO] [stdout] 316 | | } [INFO] [stdout] 317 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table_record_batch.rs:300:59 [INFO] [stdout] | [INFO] [stdout] 300 | .map(|(index, header)| Field::new(header, schema_types[index].clone(), true)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table_record_batch.rs:522:12 [INFO] [stdout] | [INFO] [stdout] 500 | let file = match File::open(file_path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 501 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 502 | Err(error) => return Err(TableRecordBatchError::IO(error)), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 505 | let parquet_reader = match ParquetRecordBatchReaderBuilder::try_new(file) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 506 | Ok(parquet_reader) => match parquet_reader.with_batch_size(8192).build() { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | Ok(parquet_reader) => parquet_reader, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 508 | Err(error) => return Err(TableRecordBatchError::ParquetRead(error)), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 509 | }, [INFO] [stdout] 510 | Err(error) => return Err(TableRecordBatchError::ParquetRead(error)), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 513 | let mut batches: Vec = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 522 | Ok(Self::from(&batches)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `valu3-parquet` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table_record_batch.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 127 | let mut schema_types: Vec = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | [INFO] [stdout] 129 | let mut columns: Vec> = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 295 | let schema = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | let fields = value_table [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | Ok(match RecordBatch::try_new(schema.clone(), columns) { [INFO] [stdout] | ____________^ [INFO] [stdout] 307 | | Ok(record_batch) => Self { [INFO] [stdout] 308 | | record_batch, [INFO] [stdout] 309 | | schema, [INFO] [stdout] ... | [INFO] [stdout] 316 | | } [INFO] [stdout] 317 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table_record_batch.rs:300:59 [INFO] [stdout] | [INFO] [stdout] 300 | .map(|(index, header)| Field::new(header, schema_types[index].clone(), true)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table_record_batch.rs:522:12 [INFO] [stdout] | [INFO] [stdout] 500 | let file = match File::open(file_path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 501 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 502 | Err(error) => return Err(TableRecordBatchError::IO(error)), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 505 | let parquet_reader = match ParquetRecordBatchReaderBuilder::try_new(file) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 506 | Ok(parquet_reader) => match parquet_reader.with_batch_size(8192).build() { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | Ok(parquet_reader) => parquet_reader, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 508 | Err(error) => return Err(TableRecordBatchError::ParquetRead(error)), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 509 | }, [INFO] [stdout] 510 | Err(error) => return Err(TableRecordBatchError::ParquetRead(error)), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 513 | let mut batches: Vec = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 522 | Ok(Self::from(&batches)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `valu3-parquet` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f7ebc47d565004cfbcfa78e660226aebb1f6acfed6593d57de0de1a643e4e59b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7ebc47d565004cfbcfa78e660226aebb1f6acfed6593d57de0de1a643e4e59b", kill_on_drop: false }` [INFO] [stdout] f7ebc47d565004cfbcfa78e660226aebb1f6acfed6593d57de0de1a643e4e59b