[INFO] fetching crate valora 0.2.12... [INFO] checking valora-0.2.12 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate valora 0.2.12 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate valora 0.2.12 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate valora 0.2.12 [INFO] finished tweaking crates.io crate valora 0.2.12 [INFO] tweaked toml for crates.io crate valora 0.2.12 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate valora 0.2.12 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1d16d18e28df39e1ec667ea5505210725e45cb17b8eb96158cc8389621883c25 [INFO] running `Command { std: "docker" "start" "-a" "1d16d18e28df39e1ec667ea5505210725e45cb17b8eb96158cc8389621883c25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1d16d18e28df39e1ec667ea5505210725e45cb17b8eb96158cc8389621883c25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d16d18e28df39e1ec667ea5505210725e45cb17b8eb96158cc8389621883c25", kill_on_drop: false }` [INFO] [stdout] 1d16d18e28df39e1ec667ea5505210725e45cb17b8eb96158cc8389621883c25 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e79a220fdf1850f12f1df1013653965e1b797a3568bbfea003a73ac22478c4a3 [INFO] running `Command { std: "docker" "start" "-a" "e79a220fdf1850f12f1df1013653965e1b797a3568bbfea003a73ac22478c4a3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libm v0.2.1 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling xml-rs v0.8.2 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling cc v1.0.52 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling syn v1.0.18 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling gl_generator v0.13.1 [INFO] [stderr] Compiling ppv-lite86 v0.2.6 [INFO] [stderr] Compiling num-iter v0.1.40 [INFO] [stderr] Compiling siphasher v0.3.3 [INFO] [stderr] Compiling wayland-scanner v0.23.6 [INFO] [stderr] Checking downcast-rs v1.1.1 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.2 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Compiling backtrace-sys v0.1.36 [INFO] [stderr] Compiling phf_shared v0.8.0 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Compiling x11-dl v2.18.5 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking smallvec v1.4.0 [INFO] [stderr] Compiling glutin_egl_sys v0.1.4 [INFO] [stderr] Compiling glutin_glx_sys v0.1.6 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking line_drawing v0.7.0 [INFO] [stderr] Checking wayland-sys v0.23.6 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking euclid v0.20.10 [INFO] [stderr] Checking rusttype v0.8.3 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Compiling proc-macro-error v1.0.2 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Compiling rand_pcg v0.2.1 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Checking rusttype v0.7.9 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking andrew v0.2.1 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling failure_derive v0.1.7 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking backtrace v0.3.46 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking inflate v0.3.4 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling wayland-client v0.23.6 [INFO] [stderr] Compiling wayland-protocols v0.23.6 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking instant v0.1.3 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking arrayvec v0.5.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking lyon_geom v0.15.2 [INFO] [stderr] Compiling glium v0.27.0 [INFO] [stderr] Checking wayland-commons v0.23.6 [INFO] [stderr] Checking calloop v0.4.4 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking gif v0.9.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Compiling phf_generator v0.8.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Compiling phf_codegen v0.8.0 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Compiling palette v0.5.0 [INFO] [stderr] Checking jpeg-decoder v0.1.18 [INFO] [stderr] Checking png v0.15.3 [INFO] [stderr] Checking lyon_path v0.15.2 [INFO] [stderr] Checking alga v0.9.3 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Checking phf v0.8.0 [INFO] [stderr] Checking sid v0.6.1 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking takeable-option v0.5.0 [INFO] [stderr] Checking rpds v0.5.0 [INFO] [stderr] Checking lyon_geom v0.14.1 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking lyon_tessellation v0.15.8 [INFO] [stderr] Checking float-ord v0.2.0 [INFO] [stderr] Checking nalgebra v0.18.1 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Compiling palette_derive v0.5.0 [INFO] [stderr] Compiling valora_derive v0.1.0 [INFO] [stderr] Checking regex v1.3.7 [INFO] [stderr] Checking noise v0.6.0 [INFO] [stderr] Compiling structopt-derive v0.4.7 [INFO] [stderr] Checking failure v0.1.7 [INFO] [stderr] Checking glslwatch v0.1.3 [INFO] [stderr] Checking tiff v0.3.1 [INFO] [stderr] Checking image v0.22.5 [INFO] [stderr] Checking structopt v0.3.14 [INFO] [stderr] Checking smithay-client-toolkit v0.6.6 [INFO] [stderr] Checking winit v0.22.1 [INFO] [stderr] Checking glutin v0.24.0 [INFO] [stderr] Checking valora v0.2.12 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `shaders::*` [INFO] [stdout] --> src/lib.rs:22:64 [INFO] [stdout] | [INFO] [stdout] 22 | attributes::*, canvas::*, forms::*, paint::*, path::*, shaders::*, transforms::*, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `shaders::*` [INFO] [stdout] --> src/lib.rs:22:64 [INFO] [stdout] | [INFO] [stdout] 22 | attributes::*, canvas::*, forms::*, paint::*, path::*, shaders::*, transforms::*, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `NoUniforms` is never constructed [INFO] [stdout] --> src/gpu.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 44 | struct NoUniforms; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:253:21 [INFO] [stdout] | [INFO] [stdout] 240 | let gpu_clone = gpu.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | / gpu_clone [INFO] [stdout] 254 | | .get_frame() [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:313:12 [INFO] [stdout] | [INFO] [stdout] 311 | run_fn(options, |gpu, world, rng| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | let mut artist = A::setup(gpu, world, rng)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 313 | Ok(move |ctx: Context, canvas: &mut Canvas| artist.paint(ctx, canvas)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpu.rs:83:28 [INFO] [stdout] | [INFO] [stdout] 81 | fn from(src: U) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | UniformBuffer { [INFO] [stdout] 83 | user_uniforms: Some(Rc::new(src)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpu.rs:164:12 [INFO] [stdout] | [INFO] [stdout] 145 | let events_loop = EventLoop::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | let ctx = glium::glutin::ContextBuilder::new() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let ctx = Rc::new(Headless::new(ctx)?); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | [INFO] [stdout] 157 | let program = Rc::new(Program::from_source( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 165 | | Gpu { [INFO] [stdout] 166 | | program, [INFO] [stdout] 167 | | ctx, [INFO] [stdout] ... | [INFO] [stdout] 170 | | events_loop, [INFO] [stdout] 171 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpu.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 178 | let events_loop = EventLoop::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | let wb = winit::window::WindowBuilder::new() [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | let display = glium::Display::new(wb, cb, &events_loop).unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let dimensions = display.get_framebuffer_dimensions(); [INFO] [stdout] 191 | let ctx = Rc::new(DisplayFacade(display)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | [INFO] [stdout] 193 | let program = Rc::new(Program::from_source( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 201 | | Gpu { [INFO] [stdout] 202 | | program, [INFO] [stdout] 203 | | ctx, [INFO] [stdout] ... | [INFO] [stdout] 207 | | dimensions, [INFO] [stdout] 208 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpu.rs:240:23 [INFO] [stdout] | [INFO] [stdout] 234 | program: Rc, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | uniforms: impl Into, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | uniforms: uniforms.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forms/polygon.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 29 | let last_iter = self.vertices().rev().take(1); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | / last_iter [INFO] [stdout] 31 | | .clone() [INFO] [stdout] 32 | | .chain(self.vertices()) [INFO] [stdout] 33 | | .chain(last_iter) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forms/polygon.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 52 | let from_start = self.vertices(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let skipped = self.vertices().skip(1).chain(self.vertices().take(1)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | [INFO] [stdout] 55 | / from_start [INFO] [stdout] 56 | | .zip(skipped) [INFO] [stdout] 57 | | .flat_map(|(a, b)| { [INFO] [stdout] 58 | | let midpoint = a + ((b + (a.to_vector() * -1.)) * 0.5).to_vector(); [INFO] [stdout] 59 | | ArrayVec::from([a, midpoint]).into_iter() [INFO] [stdout] 60 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forms/polygon.rs:121:23 [INFO] [stdout] | [INFO] [stdout] 116 | fn from_iter(iter: T) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | vertices: iter.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shaders.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 31 | glsl: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | gpu: gpu.clone(), [INFO] [stdout] 36 | | tree: GLSLTree::new(glsl, include_directories)?, [INFO] [stdout] 37 | | last_shader: gpu.default_shader(), [INFO] [stdout] 38 | | last_program: None, [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shaders.rs:44:15 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn bind(&mut self, uniforms: impl OwnedUniforms + 'static) -> Shader { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | match self.try_bind(uniforms) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shaders.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn try_bind(&mut self, uniforms: impl OwnedUniforms + 'static) -> Result { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let program = if self.tree.expired()? { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let program = self.gpu.compile_glsl(src)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let program = self.gpu.compile_glsl(src)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(self.last_shader.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `NoUniforms` is never constructed [INFO] [stdout] --> src/gpu.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 44 | struct NoUniforms; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:253:21 [INFO] [stdout] | [INFO] [stdout] 240 | let gpu_clone = gpu.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | / gpu_clone [INFO] [stdout] 254 | | .get_frame() [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:313:12 [INFO] [stdout] | [INFO] [stdout] 311 | run_fn(options, |gpu, world, rng| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | let mut artist = A::setup(gpu, world, rng)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 313 | Ok(move |ctx: Context, canvas: &mut Canvas| artist.paint(ctx, canvas)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpu.rs:83:28 [INFO] [stdout] | [INFO] [stdout] 81 | fn from(src: U) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | UniformBuffer { [INFO] [stdout] 83 | user_uniforms: Some(Rc::new(src)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpu.rs:164:12 [INFO] [stdout] | [INFO] [stdout] 145 | let events_loop = EventLoop::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | let ctx = glium::glutin::ContextBuilder::new() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let ctx = Rc::new(Headless::new(ctx)?); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | [INFO] [stdout] 157 | let program = Rc::new(Program::from_source( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 165 | | Gpu { [INFO] [stdout] 166 | | program, [INFO] [stdout] 167 | | ctx, [INFO] [stdout] ... | [INFO] [stdout] 170 | | events_loop, [INFO] [stdout] 171 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpu.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 178 | let events_loop = EventLoop::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | let wb = winit::window::WindowBuilder::new() [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | let display = glium::Display::new(wb, cb, &events_loop).unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let dimensions = display.get_framebuffer_dimensions(); [INFO] [stdout] 191 | let ctx = Rc::new(DisplayFacade(display)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | [INFO] [stdout] 193 | let program = Rc::new(Program::from_source( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 201 | | Gpu { [INFO] [stdout] 202 | | program, [INFO] [stdout] 203 | | ctx, [INFO] [stdout] ... | [INFO] [stdout] 207 | | dimensions, [INFO] [stdout] 208 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `valora` (lib) due to 13 previous errors; 2 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpu.rs:240:23 [INFO] [stdout] | [INFO] [stdout] 234 | program: Rc, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | uniforms: impl Into, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | uniforms: uniforms.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forms/polygon.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 29 | let last_iter = self.vertices().rev().take(1); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | / last_iter [INFO] [stdout] 31 | | .clone() [INFO] [stdout] 32 | | .chain(self.vertices()) [INFO] [stdout] 33 | | .chain(last_iter) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forms/polygon.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 52 | let from_start = self.vertices(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let skipped = self.vertices().skip(1).chain(self.vertices().take(1)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | [INFO] [stdout] 55 | / from_start [INFO] [stdout] 56 | | .zip(skipped) [INFO] [stdout] 57 | | .flat_map(|(a, b)| { [INFO] [stdout] 58 | | let midpoint = a + ((b + (a.to_vector() * -1.)) * 0.5).to_vector(); [INFO] [stdout] 59 | | ArrayVec::from([a, midpoint]).into_iter() [INFO] [stdout] 60 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/forms/polygon.rs:121:23 [INFO] [stdout] | [INFO] [stdout] 116 | fn from_iter(iter: T) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | vertices: iter.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shaders.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 31 | glsl: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | gpu: gpu.clone(), [INFO] [stdout] 36 | | tree: GLSLTree::new(glsl, include_directories)?, [INFO] [stdout] 37 | | last_shader: gpu.default_shader(), [INFO] [stdout] 38 | | last_program: None, [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shaders.rs:44:15 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn bind(&mut self, uniforms: impl OwnedUniforms + 'static) -> Shader { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | match self.try_bind(uniforms) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shaders.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn try_bind(&mut self, uniforms: impl OwnedUniforms + 'static) -> Result { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let program = if self.tree.expired()? { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let program = self.gpu.compile_glsl(src)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let program = self.gpu.compile_glsl(src)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(self.last_shader.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `valora` (lib test) due to 13 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e79a220fdf1850f12f1df1013653965e1b797a3568bbfea003a73ac22478c4a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e79a220fdf1850f12f1df1013653965e1b797a3568bbfea003a73ac22478c4a3", kill_on_drop: false }` [INFO] [stdout] e79a220fdf1850f12f1df1013653965e1b797a3568bbfea003a73ac22478c4a3