[INFO] fetching crate valkyrie-docgen 0.0.5... [INFO] checking valkyrie-docgen-0.0.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate valkyrie-docgen 0.0.5 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate valkyrie-docgen 0.0.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate valkyrie-docgen 0.0.5 [INFO] finished tweaking crates.io crate valkyrie-docgen 0.0.5 [INFO] tweaked toml for crates.io crate valkyrie-docgen 0.0.5 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate valkyrie-docgen 0.0.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2d83730f737ac6d451dc71cd3f7d95599fdf787f5c8ca2f4204b883074535dec [INFO] running `Command { std: "docker" "start" "-a" "2d83730f737ac6d451dc71cd3f7d95599fdf787f5c8ca2f4204b883074535dec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2d83730f737ac6d451dc71cd3f7d95599fdf787f5c8ca2f4204b883074535dec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2d83730f737ac6d451dc71cd3f7d95599fdf787f5c8ca2f4204b883074535dec", kill_on_drop: false }` [INFO] [stdout] 2d83730f737ac6d451dc71cd3f7d95599fdf787f5c8ca2f4204b883074535dec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2f1fa49bf93fad3b2d8b9a23822dbba8903080b84d831a9d7c107178c06fc934 [INFO] running `Command { std: "docker" "start" "-a" "2f1fa49bf93fad3b2d8b9a23822dbba8903080b84d831a9d7c107178c06fc934", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.58 [INFO] [stderr] Compiling log v0.4.13 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.69 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling bumpalo v3.4.0 [INFO] [stderr] Compiling wasm-bindgen v0.2.69 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling serde_derive v1.0.120 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Checking futures-core v0.3.12 [INFO] [stderr] Compiling serde v1.0.120 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Checking futures-sink v0.3.12 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking pin-project-lite v0.2.4 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking futures-channel v0.3.12 [INFO] [stderr] Checking futures-task v0.3.12 [INFO] [stderr] Checking futures-io v0.3.12 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling serde_json v1.0.61 [INFO] [stderr] Compiling anyhow v1.0.38 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Compiling boolinator v2.4.0 [INFO] [stderr] Compiling yew v0.17.4 [INFO] [stderr] Checking cfg-match v0.2.1 [INFO] [stderr] Checking anymap v0.12.1 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling indexmap v1.6.1 [INFO] [stderr] Checking itertools v0.10.0 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking http v0.2.3 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.69 [INFO] [stderr] Compiling futures-macro v0.3.12 [INFO] [stderr] Compiling thiserror-impl v1.0.23 [INFO] [stderr] Compiling yew-macro v0.17.0 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.69 [INFO] [stderr] Checking futures-util v0.3.12 [INFO] [stderr] Checking thiserror v1.0.23 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.69 [INFO] [stderr] Checking js-sys v0.3.46 [INFO] [stderr] Checking console_error_panic_hook v0.1.6 [INFO] [stderr] Checking futures-executor v0.3.12 [INFO] [stderr] Checking futures v0.3.12 [INFO] [stderr] Checking web-sys v0.3.46 [INFO] [stderr] Checking wasm-bindgen-futures v0.4.19 [INFO] [stderr] Checking bincode v1.3.1 [INFO] [stderr] Checking gloo-events v0.1.1 [INFO] [stderr] Checking gloo-console-timer v0.1.0 [INFO] [stderr] Checking gloo-timers v0.2.1 [INFO] [stderr] Checking gloo-file v0.1.0 [INFO] [stderr] Checking gloo v0.2.1 [INFO] [stderr] Checking valkyrie-docgen v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `once_cell` has been stable since 1.70.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(once_cell)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `once_cell` has been stable since 1.70.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(once_cell)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: a method with this name may be added to the standard library in the future [INFO] [stdout] --> src/items/container/listable.rs:37:54 [INFO] [stdout] | [INFO] [stdout] 37 | .chain(self.0.iter().map(|s| s.render()).intersperse(T::delimiter())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `itertools::Itertools::intersperse(...)` to keep using the current method [INFO] [stdout] = note: `#[warn(unstable_name_collisions)]` on by default [INFO] [stdout] help: add `#![feature(iter_intersperse)]` to the crate attributes to enable `std::iter::Iterator::intersperse` [INFO] [stdout] --> src/lib.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 + #![feature(iter_intersperse)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: a method with this name may be added to the standard library in the future [INFO] [stdout] --> src/items/container/listable.rs:37:54 [INFO] [stdout] | [INFO] [stdout] 37 | .chain(self.0.iter().map(|s| s.render()).intersperse(T::delimiter())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `itertools::Itertools::intersperse(...)` to keep using the current method [INFO] [stdout] = note: `#[warn(unstable_name_collisions)]` on by default [INFO] [stdout] help: add `#![feature(iter_intersperse)]` to the crate attributes to enable `std::iter::Iterator::intersperse` [INFO] [stdout] --> src/lib.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 + #![feature(iter_intersperse)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: a method with this name may be added to the standard library in the future [INFO] [stdout] --> src/items/definition/function.rs:39:67 [INFO] [stdout] | [INFO] [stdout] 39 | .chain(self.parameters.clone().into_vec().into_iter().intersperse(comma)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `itertools::Itertools::intersperse(...)` to keep using the current method [INFO] [stdout] help: add `#![feature(iter_intersperse)]` to the crate attributes to enable `std::iter::Iterator::intersperse` [INFO] [stdout] --> src/lib.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 + #![feature(iter_intersperse)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: a method with this name may be added to the standard library in the future [INFO] [stdout] --> src/items/definition/function.rs:39:67 [INFO] [stdout] | [INFO] [stdout] 39 | .chain(self.parameters.clone().into_vec().into_iter().intersperse(comma)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `itertools::Itertools::intersperse(...)` to keep using the current method [INFO] [stdout] help: add `#![feature(iter_intersperse)]` to the crate attributes to enable `std::iter::Iterator::intersperse` [INFO] [stdout] --> src/lib.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 + #![feature(iter_intersperse)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/items/container/listable.rs:79:42 [INFO] [stdout] | [INFO] [stdout] 79 | RcList(v.iter().map(|&e| Rc::new(T::from(e))).collect()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/items/container/signature.rs:91:15 [INFO] [stdout] | [INFO] [stdout] 72 | let code = self.data.get_signature(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let anchor = Anchor(format!("#{}", id)); [INFO] [stdout] 74 | let collapse = match self.collapse { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | None => html! { [INFO] [stdout] | _____________________- [INFO] [stdout] 76 | | // {"[x]"} [INFO] [stdout] 77 | | {"[x]"} [INFO] [stdout] | | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | | }, [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Some(true) => html! { [INFO] [stdout] | ___________________________- [INFO] [stdout] 80 | | {"[-]"} [INFO] [stdout] | | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | | }, [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | Some(false) => html! { [INFO] [stdout] | ____________________________- [INFO] [stdout] 83 | | {"[+]"} [INFO] [stdout] | | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | | }, [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | match self.children.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/items/container/listable.rs:79:42 [INFO] [stdout] | [INFO] [stdout] 79 | RcList(v.iter().map(|&e| Rc::new(T::from(e))).collect()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/items/container/signature.rs:91:15 [INFO] [stdout] | [INFO] [stdout] 72 | let code = self.data.get_signature(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let anchor = Anchor(format!("#{}", id)); [INFO] [stdout] 74 | let collapse = match self.collapse { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | None => html! { [INFO] [stdout] | _____________________- [INFO] [stdout] 76 | | // {"[x]"} [INFO] [stdout] 77 | | {"[x]"} [INFO] [stdout] | | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | | }, [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Some(true) => html! { [INFO] [stdout] | ___________________________- [INFO] [stdout] 80 | | {"[-]"} [INFO] [stdout] | | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | | }, [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | Some(false) => html! { [INFO] [stdout] | ____________________________- [INFO] [stdout] 83 | | {"[+]"} [INFO] [stdout] | | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | | }, [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | match self.children.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `valkyrie-docgen` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `valkyrie-docgen` (lib) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2f1fa49bf93fad3b2d8b9a23822dbba8903080b84d831a9d7c107178c06fc934", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f1fa49bf93fad3b2d8b9a23822dbba8903080b84d831a9d7c107178c06fc934", kill_on_drop: false }` [INFO] [stdout] 2f1fa49bf93fad3b2d8b9a23822dbba8903080b84d831a9d7c107178c06fc934