[INFO] fetching crate validate 0.6.1... [INFO] checking validate-0.6.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate validate 0.6.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate validate 0.6.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate validate 0.6.1 [INFO] finished tweaking crates.io crate validate 0.6.1 [INFO] tweaked toml for crates.io crate validate 0.6.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 12 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.5.3 (latest: v1.1.3) [INFO] [stderr] Adding memchr v0.1.11 (latest: v2.7.4) [INFO] [stderr] Adding regex v0.1.80 (latest: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.3.9 (latest: v0.8.4) [INFO] [stderr] Adding thread-id v2.0.0 (latest: v4.2.2) [INFO] [stderr] Adding thread_local v0.2.7 (latest: v1.1.8) [INFO] [stderr] Adding utf8-ranges v0.1.3 (latest: v1.0.5) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 258b97aea62e91589e7c7deef541b721c1a914e2a5307ae7d17054a513f209f4 [INFO] running `Command { std: "docker" "start" "-a" "258b97aea62e91589e7c7deef541b721c1a914e2a5307ae7d17054a513f209f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "258b97aea62e91589e7c7deef541b721c1a914e2a5307ae7d17054a513f209f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "258b97aea62e91589e7c7deef541b721c1a914e2a5307ae7d17054a513f209f4", kill_on_drop: false }` [INFO] [stdout] 258b97aea62e91589e7c7deef541b721c1a914e2a5307ae7d17054a513f209f4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f7ed14c334e6edd28ffdfe93fdf56b4b7e965447e838d13f191f64f7b40a92c0 [INFO] running `Command { std: "docker" "start" "-a" "f7ed14c334e6edd28ffdfe93fdf56b4b7e965447e838d13f191f64f7b40a92c0", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking regex-syntax v0.3.9 [INFO] [stderr] Checking utf8-ranges v0.1.3 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking validate v0.6.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rule.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | rule: Box ValidationResult> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | rule: Box ValidationResult> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/rule.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | rule: Box ValidationResult> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | rule: Box ValidationResult> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rule.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn map<'b, F, U>(self, get: F) -> Rule [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Rule::from(move |input: &U| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 32 | | let mapped_input = get(input); [INFO] [stdout] 33 | | self.validate(&mapped_input) [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rule.rs:49:14 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn nest<'b, R, F, U>(get: F, rule: R) -> Self [INFO] [stdout] | ------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let converted_rule = rule.into(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Rule::from(move |input: &T| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 50 | | let mapped_input = get(input); [INFO] [stdout] 51 | | converted_rule.validate(&mapped_input) [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rule.rs:58:14 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn name(self, name: &str) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let name = name.to_owned(); [INFO] [stdout] 58 | Rule::from(move |input: &T| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 59 | | self.validate(&input).map_err(|err: Error| { [INFO] [stdout] 60 | | (name.clone() + " " + &err.get_message()).into() [INFO] [stdout] 61 | | }) [INFO] [stdout] 62 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rule.rs:71:10 [INFO] [stdout] | [INFO] [stdout] 69 | fn from(func: F) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Rule { [INFO] [stdout] 71 | rule: Box::new(func) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rule.rs:81:14 [INFO] [stdout] | [INFO] [stdout] 79 | fn add(self, rule: R) -> Self::Output { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let rule = rule.into(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | Rule::from(move |input: &T| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 82 | | self.validate(input)?; [INFO] [stdout] 83 | | rule.validate(input) [INFO] [stdout] 84 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rules.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 19 | let regex = Regex::new(pattern).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let description = description.to_owned(); [INFO] [stdout] 21 | Rule::from(move |input: &str| { [INFO] [stdout] | ________________^ [INFO] [stdout] 22 | | match regex.is_match(input) { [INFO] [stdout] 23 | | true => Ok(()), [INFO] [stdout] 24 | | false => Err(format!("must be {}", description).into()) [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `validate` (lib test) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rule.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn map<'b, F, U>(self, get: F) -> Rule [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Rule::from(move |input: &U| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 32 | | let mapped_input = get(input); [INFO] [stdout] 33 | | self.validate(&mapped_input) [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rule.rs:49:14 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn nest<'b, R, F, U>(get: F, rule: R) -> Self [INFO] [stdout] | ------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let converted_rule = rule.into(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Rule::from(move |input: &T| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 50 | | let mapped_input = get(input); [INFO] [stdout] 51 | | converted_rule.validate(&mapped_input) [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rule.rs:58:14 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn name(self, name: &str) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let name = name.to_owned(); [INFO] [stdout] 58 | Rule::from(move |input: &T| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 59 | | self.validate(&input).map_err(|err: Error| { [INFO] [stdout] 60 | | (name.clone() + " " + &err.get_message()).into() [INFO] [stdout] 61 | | }) [INFO] [stdout] 62 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rule.rs:71:10 [INFO] [stdout] | [INFO] [stdout] 69 | fn from(func: F) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Rule { [INFO] [stdout] 71 | rule: Box::new(func) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rule.rs:81:14 [INFO] [stdout] | [INFO] [stdout] 79 | fn add(self, rule: R) -> Self::Output { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let rule = rule.into(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | Rule::from(move |input: &T| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 82 | | self.validate(input)?; [INFO] [stdout] 83 | | rule.validate(input) [INFO] [stdout] 84 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rules.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 19 | let regex = Regex::new(pattern).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let description = description.to_owned(); [INFO] [stdout] 21 | Rule::from(move |input: &str| { [INFO] [stdout] | ________________^ [INFO] [stdout] 22 | | match regex.is_match(input) { [INFO] [stdout] 23 | | true => Ok(()), [INFO] [stdout] 24 | | false => Err(format!("must be {}", description).into()) [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `validate` (lib) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f7ed14c334e6edd28ffdfe93fdf56b4b7e965447e838d13f191f64f7b40a92c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7ed14c334e6edd28ffdfe93fdf56b4b7e965447e838d13f191f64f7b40a92c0", kill_on_drop: false }` [INFO] [stdout] f7ed14c334e6edd28ffdfe93fdf56b4b7e965447e838d13f191f64f7b40a92c0