[INFO] fetching crate valid 0.3.1... [INFO] checking valid-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate valid 0.3.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate valid 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate valid 0.3.1 [INFO] finished tweaking crates.io crate valid 0.3.1 [INFO] tweaked toml for crates.io crate valid 0.3.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 115 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding bigdecimal v0.1.2 (latest: v0.4.5) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding num-bigint v0.2.6 (latest: v0.4.6) [INFO] [stderr] Adding proptest v0.9.6 (latest: v1.5.0) [INFO] [stderr] Adding pulldown-cmark v0.9.6 (latest: v0.12.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding rusty-fork v0.2.2 (latest: v0.3.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding toml v0.7.8 (latest: v0.8.19) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 23eed1ef9912c70181434afc41c943f4588c46ba4e93626b99e16b444ae4ac7b [INFO] running `Command { std: "docker" "start" "-a" "23eed1ef9912c70181434afc41c943f4588c46ba4e93626b99e16b444ae4ac7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "23eed1ef9912c70181434afc41c943f4588c46ba4e93626b99e16b444ae4ac7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "23eed1ef9912c70181434afc41c943f4588c46ba4e93626b99e16b444ae4ac7b", kill_on_drop: false }` [INFO] [stdout] 23eed1ef9912c70181434afc41c943f4588c46ba4e93626b99e16b444ae4ac7b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 21dd67c76aab4a64fa975e48509cc829f826387c950bc622b08dee9405a68ba0 [INFO] running `Command { std: "docker" "start" "-a" "21dd67c76aab4a64fa975e48509cc829f826387c950bc622b08dee9405a68ba0", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling pulldown-cmark v0.9.6 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking valid v0.3.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking url v2.5.2 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/mod.rs:340:20 [INFO] [stdout] | [INFO] [stdout] 339 | pub fn success(valid: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | Validation(InnerValidation::Success(PhantomData, valid)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/mod.rs:348:20 [INFO] [stdout] | [INFO] [stdout] 347 | pub fn failure(constraint_violations: impl IntoIterator) -> Self { [INFO] [stdout] | -------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | Validation(InnerValidation::Failure(Vec::from_iter( [INFO] [stdout] | ____________________^ [INFO] [stdout] 349 | | constraint_violations.into_iter(), [INFO] [stdout] 350 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/mod.rs:433:15 [INFO] [stdout] | [INFO] [stdout] 432 | pub fn and(self, other: Validation) -> Validation { [INFO] [stdout] | ---- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 433 | match (self.0, other.0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/mod.rs:1149:32 [INFO] [stdout] | [INFO] [stdout] 1144 | code: impl Into>, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1145 | params: impl IntoIterator, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1149 | params: Vec::from_iter(params.into_iter()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `valid` (lib) due to 5 previous errors [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "21dd67c76aab4a64fa975e48509cc829f826387c950bc622b08dee9405a68ba0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21dd67c76aab4a64fa975e48509cc829f826387c950bc622b08dee9405a68ba0", kill_on_drop: false }` [INFO] [stdout] 21dd67c76aab4a64fa975e48509cc829f826387c950bc622b08dee9405a68ba0