[INFO] fetching crate valence_protocol_macros 0.2.0-alpha.1+mc.1.20.1... [INFO] checking valence_protocol_macros-0.2.0-alpha.1+mc.1.20.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate valence_protocol_macros 0.2.0-alpha.1+mc.1.20.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate valence_protocol_macros 0.2.0-alpha.1+mc.1.20.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate valence_protocol_macros 0.2.0-alpha.1+mc.1.20.1 [INFO] finished tweaking crates.io crate valence_protocol_macros 0.2.0-alpha.1+mc.1.20.1 [INFO] tweaked toml for crates.io crate valence_protocol_macros 0.2.0-alpha.1+mc.1.20.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 49cdc54fe191d1279dd5ae19f8f40638bcc3a420d3bc4706edfd2aa1780378f1 [INFO] running `Command { std: "docker" "start" "-a" "49cdc54fe191d1279dd5ae19f8f40638bcc3a420d3bc4706edfd2aa1780378f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "49cdc54fe191d1279dd5ae19f8f40638bcc3a420d3bc4706edfd2aa1780378f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49cdc54fe191d1279dd5ae19f8f40638bcc3a420d3bc4706edfd2aa1780378f1", kill_on_drop: false }` [INFO] [stdout] 49cdc54fe191d1279dd5ae19f8f40638bcc3a420d3bc4706edfd2aa1780378f1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7145eb2c71466aca6f77e390fcca51a9855ed8a6acb6f25a09b9ea6b21b2e731 [INFO] running `Command { std: "docker" "start" "-a" "7145eb2c71466aca6f77e390fcca51a9855ed8a6acb6f25a09b9ea6b21b2e731", kill_on_drop: false }` [INFO] [stderr] Checking valence_protocol_macros v0.2.0-alpha.1+mc.1.20.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:34:11 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn derive_encode(item: StdTokenStream) -> StdTokenStream { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | match encode::derive_encode(item.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:42:11 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn derive_decode(item: StdTokenStream) -> StdTokenStream { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | match decode::derive_decode(item.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:50:11 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn derive_packet(item: StdTokenStream) -> StdTokenStream { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | match packet::derive_packet(item.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 57 | variants: impl IntoIterator, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | / variants [INFO] [stdout] 61 | | .into_iter() [INFO] [stdout] 62 | | .map(|v| { [INFO] [stdout] 63 | | if let Some(i) = parse_tag_attr(&v.attrs)? { [INFO] [stdout] ... | [INFO] [stdout] 69 | | Ok(pair) [INFO] [stdout] 70 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:34:11 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn derive_encode(item: StdTokenStream) -> StdTokenStream { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | match encode::derive_encode(item.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:42:11 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn derive_decode(item: StdTokenStream) -> StdTokenStream { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | match decode::derive_decode(item.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:50:11 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn derive_packet(item: StdTokenStream) -> StdTokenStream { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | match packet::derive_packet(item.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 57 | variants: impl IntoIterator, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | / variants [INFO] [stdout] 61 | | .into_iter() [INFO] [stdout] 62 | | .map(|v| { [INFO] [stdout] 63 | | if let Some(i) = parse_tag_attr(&v.attrs)? { [INFO] [stdout] ... | [INFO] [stdout] 69 | | Ok(pair) [INFO] [stdout] 70 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `valence_protocol_macros` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `valence_protocol_macros` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "7145eb2c71466aca6f77e390fcca51a9855ed8a6acb6f25a09b9ea6b21b2e731", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7145eb2c71466aca6f77e390fcca51a9855ed8a6acb6f25a09b9ea6b21b2e731", kill_on_drop: false }` [INFO] [stdout] 7145eb2c71466aca6f77e390fcca51a9855ed8a6acb6f25a09b9ea6b21b2e731