[INFO] fetching crate valence_network 0.2.0-alpha.1+mc.1.20.1... [INFO] checking valence_network-0.2.0-alpha.1+mc.1.20.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate valence_network 0.2.0-alpha.1+mc.1.20.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate valence_network 0.2.0-alpha.1+mc.1.20.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate valence_network 0.2.0-alpha.1+mc.1.20.1 [INFO] finished tweaking crates.io crate valence_network 0.2.0-alpha.1+mc.1.20.1 [INFO] tweaked toml for crates.io crate valence_network 0.2.0-alpha.1+mc.1.20.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 241 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bevy_app v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bevy_derive v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bevy_ecs v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bevy_ecs_macros v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bevy_macro_utils v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bevy_ptr v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bevy_tasks v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bevy_utils v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bevy_utils_proc_macros v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bitfield-struct v0.3.2 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding der v0.6.1 (latest: v0.7.9) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding flume v0.10.14 (latest: v0.11.0) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding glam v0.23.0 (latest: v0.29.0) [INFO] [stderr] Adding h2 v0.3.26 (latest: v0.4.6) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (latest: v1.4.1) [INFO] [stderr] Adding hyper-rustls v0.24.2 (latest: v0.27.2) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding pem-rfc7468 v0.6.0 (latest: v0.7.0) [INFO] [stderr] Adding pkcs1 v0.4.1 (latest: v0.7.5) [INFO] [stderr] Adding pkcs8 v0.9.0 (latest: v0.10.2) [INFO] [stderr] Adding reqwest v0.11.27 (latest: v0.12.7) [INFO] [stderr] Adding rsa v0.7.2 (latest: v0.9.6) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding signature v1.6.4 (latest: v2.2.0) [INFO] [stderr] Adding spki v0.6.0 (latest: v0.7.3) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding sync_wrapper v0.1.2 (latest: v1.0.1) [INFO] [stderr] Adding system-configuration v0.5.1 (latest: v0.6.1) [INFO] [stderr] Adding system-configuration-sys v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding tokio-rustls v0.24.1 (latest: v0.26.0) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding valence_nbt v0.6.1 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki-roots v0.25.4 (latest: v0.26.5) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] [stderr] Adding winreg v0.50.0 (latest: v0.52.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c4e6771ba4c9d5e3a2abbbf895a50417b109a9c6785f07dda15448ff146bf257 [INFO] running `Command { std: "docker" "start" "-a" "c4e6771ba4c9d5e3a2abbbf895a50417b109a9c6785f07dda15448ff146bf257", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c4e6771ba4c9d5e3a2abbbf895a50417b109a9c6785f07dda15448ff146bf257", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4e6771ba4c9d5e3a2abbbf895a50417b109a9c6785f07dda15448ff146bf257", kill_on_drop: false }` [INFO] [stdout] c4e6771ba4c9d5e3a2abbbf895a50417b109a9c6785f07dda15448ff146bf257 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f959f52dffb1ce23123139795f41669cdafa4888d08589ea06ff5b35819866e [INFO] running `Command { std: "docker" "start" "-a" "0f959f52dffb1ce23123139795f41669cdafa4888d08589ea06ff5b35819866e", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling gimli v0.29.0 [INFO] [stderr] Compiling adler v1.0.2 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling rustc-demangle v0.1.24 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling miniz_oxide v0.7.4 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Compiling object v0.36.4 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking glam v0.23.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking bevy_ptr v0.11.3 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking cesu8 v1.1.0 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking cfb8 v0.8.1 [INFO] [stderr] Checking pem-rfc7468 v0.6.0 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking der v0.6.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking bevy_tasks v0.11.3 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking spki v0.6.0 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking pkcs8 v0.9.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking pkcs1 v0.4.1 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking valence_math v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling addr2line v0.22.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Compiling bevy_macro_utils v0.11.3 [INFO] [stderr] Compiling bitfield-struct v0.3.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling valence_ident_macros v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Compiling bevy_utils_proc_macros v0.11.3 [INFO] [stderr] Compiling bevy_ecs_macros v0.11.3 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling valence_protocol_macros v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Compiling bevy_derive v0.11.3 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling valence_build_utils v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking simple_asn1 v0.6.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking rsa-der v0.3.0 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking rsa v0.7.2 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking valence_ident v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking valence_nbt v0.6.1 [INFO] [stderr] Compiling valence_generated v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Compiling valence_entity v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Compiling valence_lang v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Checking valence_text v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking bevy_utils v0.11.3 [INFO] [stderr] Checking bevy_ecs v0.11.3 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking bevy_app v0.11.3 [INFO] [stderr] Checking valence_protocol v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Checking valence_server_common v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Checking valence_registry v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Checking valence_server v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Checking valence_network v0.2.0-alpha.1+mc.1.20.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:305:20 [INFO] [stdout] | [INFO] [stdout] 303 | pub fn new(callbacks: impl NetworkCallbacks) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 304 | Self { [INFO] [stdout] 305 | inner: Arc::new(callbacks), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet_io.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 31 | pub(crate) fn new(stream: TcpStream, enc: PacketEncoder, dec: PacketDecoder) -> Self { [INFO] [stdout] | ----------------- ------------------ ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | frame: PacketFrame { [INFO] [stdout] | ____________________^ [INFO] [stdout] 37 | | id: -1, [INFO] [stdout] 38 | | body: BytesMut::new(), [INFO] [stdout] 39 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet_io.rs:194:19 [INFO] [stdout] | [INFO] [stdout] 89 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | cleanup: CleanupOnDrop, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | ) -> ClientBundleArgs { [INFO] [stdout] 95 | let (incoming_sender, incoming_receiver) = flume::unbounded(); [INFO] [stdout] | --------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let recv_sem = Arc::new(Semaphore::new(incoming_byte_limit)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let recv_sem_clone = recv_sem.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | [INFO] [stdout] 102 | let (mut reader, mut writer) = self.stream.into_split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | [INFO] [stdout] 104 | let reader_task = tokio::spawn(async move { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let (outgoing_sender, mut outgoing_receiver) = byte_channel(outgoing_byte_limit); [INFO] [stdout] | --------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | [INFO] [stdout] 173 | let writer_task = tokio::spawn(async move { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | conn: Box::new(RealClientConnection { [INFO] [stdout] | ___________________^ [INFO] [stdout] 195 | | send: outgoing_sender, [INFO] [stdout] 196 | | recv: incoming_receiver, [INFO] [stdout] 197 | | recv_sem: recv_sem_clone, [INFO] [stdout] ... | [INFO] [stdout] 200 | | _cleanup: cleanup, [INFO] [stdout] 201 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet_io.rs:220:15 [INFO] [stdout] | [INFO] [stdout] 219 | fn try_send(&mut self, bytes: BytesMut) -> anyhow::Result<()> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | match self.send.try_send(bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `valence_network` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:305:20 [INFO] [stdout] | [INFO] [stdout] 303 | pub fn new(callbacks: impl NetworkCallbacks) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 304 | Self { [INFO] [stdout] 305 | inner: Arc::new(callbacks), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet_io.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 31 | pub(crate) fn new(stream: TcpStream, enc: PacketEncoder, dec: PacketDecoder) -> Self { [INFO] [stdout] | ----------------- ------------------ ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | frame: PacketFrame { [INFO] [stdout] | ____________________^ [INFO] [stdout] 37 | | id: -1, [INFO] [stdout] 38 | | body: BytesMut::new(), [INFO] [stdout] 39 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet_io.rs:194:19 [INFO] [stdout] | [INFO] [stdout] 89 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | cleanup: CleanupOnDrop, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | ) -> ClientBundleArgs { [INFO] [stdout] 95 | let (incoming_sender, incoming_receiver) = flume::unbounded(); [INFO] [stdout] | --------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let recv_sem = Arc::new(Semaphore::new(incoming_byte_limit)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let recv_sem_clone = recv_sem.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | [INFO] [stdout] 102 | let (mut reader, mut writer) = self.stream.into_split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | [INFO] [stdout] 104 | let reader_task = tokio::spawn(async move { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let (outgoing_sender, mut outgoing_receiver) = byte_channel(outgoing_byte_limit); [INFO] [stdout] | --------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | [INFO] [stdout] 173 | let writer_task = tokio::spawn(async move { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | conn: Box::new(RealClientConnection { [INFO] [stdout] | ___________________^ [INFO] [stdout] 195 | | send: outgoing_sender, [INFO] [stdout] 196 | | recv: incoming_receiver, [INFO] [stdout] 197 | | recv_sem: recv_sem_clone, [INFO] [stdout] ... | [INFO] [stdout] 200 | | _cleanup: cleanup, [INFO] [stdout] 201 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet_io.rs:220:15 [INFO] [stdout] | [INFO] [stdout] 219 | fn try_send(&mut self, bytes: BytesMut) -> anyhow::Result<()> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | match self.send.try_send(bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `valence_network` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "0f959f52dffb1ce23123139795f41669cdafa4888d08589ea06ff5b35819866e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f959f52dffb1ce23123139795f41669cdafa4888d08589ea06ff5b35819866e", kill_on_drop: false }` [INFO] [stdout] 0f959f52dffb1ce23123139795f41669cdafa4888d08589ea06ff5b35819866e