[INFO] fetching crate valence_inventory 0.2.0-alpha.1+mc.1.20.1... [INFO] checking valence_inventory-0.2.0-alpha.1+mc.1.20.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate valence_inventory 0.2.0-alpha.1+mc.1.20.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate valence_inventory 0.2.0-alpha.1+mc.1.20.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate valence_inventory 0.2.0-alpha.1+mc.1.20.1 [INFO] finished tweaking crates.io crate valence_inventory 0.2.0-alpha.1+mc.1.20.1 [INFO] tweaked toml for crates.io crate valence_inventory 0.2.0-alpha.1+mc.1.20.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 140 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bevy_app v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bevy_derive v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bevy_ecs v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bevy_ecs_macros v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bevy_macro_utils v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bevy_ptr v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bevy_tasks v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bevy_utils v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bevy_utils_proc_macros v0.11.3 (latest: v0.14.1) [INFO] [stderr] Adding bitfield-struct v0.3.2 (latest: v0.8.0) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding glam v0.23.0 (latest: v0.29.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding valence_nbt v0.6.1 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 644c405f0a09c07dcddcb0913ecfee66744c30188ebdbe401d01930ccb5d9913 [INFO] running `Command { std: "docker" "start" "-a" "644c405f0a09c07dcddcb0913ecfee66744c30188ebdbe401d01930ccb5d9913", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "644c405f0a09c07dcddcb0913ecfee66744c30188ebdbe401d01930ccb5d9913", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "644c405f0a09c07dcddcb0913ecfee66744c30188ebdbe401d01930ccb5d9913", kill_on_drop: false }` [INFO] [stdout] 644c405f0a09c07dcddcb0913ecfee66744c30188ebdbe401d01930ccb5d9913 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 19cd2aead035a545aa01eccb00ce25fbd17f9533af348df31f5b9fff8fe46064 [INFO] running `Command { std: "docker" "start" "-a" "19cd2aead035a545aa01eccb00ce25fbd17f9533af348df31f5b9fff8fe46064", kill_on_drop: false }` [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling gimli v0.29.0 [INFO] [stderr] Compiling adler v1.0.2 [INFO] [stderr] Compiling object v0.36.4 [INFO] [stderr] Compiling rustc-demangle v0.1.24 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling bevy_macro_utils v0.11.3 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling valence_ident_macros v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Compiling bevy_utils_proc_macros v0.11.3 [INFO] [stderr] Compiling miniz_oxide v0.7.4 [INFO] [stderr] Checking bevy_ptr v0.11.3 [INFO] [stderr] Checking cesu8 v1.1.0 [INFO] [stderr] Checking glam v0.23.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling bitfield-struct v0.3.2 [INFO] [stderr] Checking valence_nbt v0.6.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling valence_protocol_macros v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Checking valence_ident v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Compiling bevy_ecs_macros v0.11.3 [INFO] [stderr] Compiling bevy_derive v0.11.3 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking bevy_tasks v0.11.3 [INFO] [stderr] Checking valence_text v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking valence_math v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Compiling addr2line v0.22.0 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking bevy_utils v0.11.3 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking bevy_ecs v0.11.3 [INFO] [stderr] Compiling valence_build_utils v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Compiling valence_generated v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Compiling valence_entity v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Checking bevy_app v0.11.3 [INFO] [stderr] Checking valence_protocol v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Checking valence_server_common v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Checking valence_registry v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Checking valence_server v0.2.0-alpha.1+mc.1.20.1 [INFO] [stderr] Checking valence_inventory v0.2.0-alpha.1+mc.1.20.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:101:20 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn with_title<'a>(kind: InventoryKind, title: impl IntoText<'a>) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | Inventory { [INFO] [stdout] 101 | title: title.into_cow_text().into_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:103:20 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn with_title<'a>(kind: InventoryKind, title: impl IntoText<'a>) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | slots: vec![None; kind.slot_count()].into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:274:44 [INFO] [stdout] | [INFO] [stdout] 272 | pub fn replace_title<'a>(&mut self, title: impl IntoText<'a>) -> Text { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | // TODO: set title modified flag [INFO] [stdout] 274 | std::mem::replace(&mut self.title, title.into_cow_text().into_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:101:20 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn with_title<'a>(kind: InventoryKind, title: impl IntoText<'a>) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | Inventory { [INFO] [stdout] 101 | title: title.into_cow_text().into_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:103:20 [INFO] [stdout] | [INFO] [stdout] 99 | pub fn with_title<'a>(kind: InventoryKind, title: impl IntoText<'a>) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | slots: vec![None; kind.slot_count()].into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:274:44 [INFO] [stdout] | [INFO] [stdout] 272 | pub fn replace_title<'a>(&mut self, title: impl IntoText<'a>) -> Text { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | // TODO: set title modified flag [INFO] [stdout] 274 | std::mem::replace(&mut self.title, title.into_cow_text().into_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `valence_inventory` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `valence_inventory` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "19cd2aead035a545aa01eccb00ce25fbd17f9533af348df31f5b9fff8fe46064", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19cd2aead035a545aa01eccb00ce25fbd17f9533af348df31f5b9fff8fe46064", kill_on_drop: false }` [INFO] [stdout] 19cd2aead035a545aa01eccb00ce25fbd17f9533af348df31f5b9fff8fe46064