[INFO] fetching crate va-ts 0.0.4... [INFO] checking va-ts-0.0.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate va-ts 0.0.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate va-ts 0.0.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate va-ts 0.0.4 [INFO] finished tweaking crates.io crate va-ts 0.0.4 [INFO] tweaked toml for crates.io crate va-ts 0.0.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate va-ts 0.0.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b75cf6ac8a04abaec106049dbfda27a14e6579fd67039c1ba5af453a7d17d430 [INFO] running `Command { std: "docker" "start" "-a" "b75cf6ac8a04abaec106049dbfda27a14e6579fd67039c1ba5af453a7d17d430", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b75cf6ac8a04abaec106049dbfda27a14e6579fd67039c1ba5af453a7d17d430", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b75cf6ac8a04abaec106049dbfda27a14e6579fd67039c1ba5af453a7d17d430", kill_on_drop: false }` [INFO] [stdout] b75cf6ac8a04abaec106049dbfda27a14e6579fd67039c1ba5af453a7d17d430 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7c305ca9dd09645a1779aeb24806e8953b04ed3c05e274e60bc3c5ea058a7c0c [INFO] running `Command { std: "docker" "start" "-a" "7c305ca9dd09645a1779aeb24806e8953b04ed3c05e274e60bc3c5ea058a7c0c", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling libc v0.2.49 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Compiling encoding_rs v0.8.17 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Checking smallvec v0.6.9 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking form_urlencoded v1.0.0 [INFO] [stderr] Checking unicode-normalization v0.1.8 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking chrono v0.4.8 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking url v2.2.0 [INFO] [stderr] Checking va-ts v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/demuxer.rs:462:58 [INFO] [stdout] | [INFO] [stdout] 462 | pub fn demux_tables(&mut self, raw: &[u8]) -> Result<(bool)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 462 - pub fn demux_tables(&mut self, raw: &[u8]) -> Result<(bool)> { [INFO] [stdout] 462 + pub fn demux_tables(&mut self, raw: &[u8]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::bat::BAT` [INFO] [stdout] --> src/section/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub use self::bat::BAT; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::cat::CAT` [INFO] [stdout] --> src/section/mod.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub use self::cat::CAT; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::nit::NIT` [INFO] [stdout] --> src/section/mod.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub use self::nit::NIT; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:42:18 [INFO] [stdout] | [INFO] [stdout] 42 | self.description() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:88:38 [INFO] [stdout] | [INFO] [stdout] 88 | Kind::Io(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/demuxer.rs:530:13 [INFO] [stdout] | [INFO] [stdout] 530 | let mut packet = match self.packets.0.get_mut(&pid) { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `buf` is never read [INFO] [stdout] --> src/descriptor/desc_dvb_0x4e.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct DescDVB0x4E<'buf> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 10 | buf: &'buf [u8], [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DescDVB0x4E` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `buf` is never read [INFO] [stdout] --> src/descriptor/desc_dvb_0x53.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct DescDVB0x53<'buf> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 10 | buf: &'buf [u8], [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DescDVB0x53` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `buf` is never read [INFO] [stdout] --> src/descriptor/desc_dvb_0x54.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct DescDVB0x54<'buf> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 10 | buf: &'buf [u8], [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DescDVB0x54` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `buf` is never read [INFO] [stdout] --> src/descriptor/desc_dvb_0x56.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct DescDVB0x56<'buf> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 10 | buf: &'buf [u8], [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DescDVB0x56` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `buf` is never read [INFO] [stdout] --> src/descriptor/desc_dvb_0x6a.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct DescDVB0x6A<'buf> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 10 | buf: &'buf [u8], [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DescDVB0x6A` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `segment_last_section_number` and `last_table_id` are never used [INFO] [stdout] --> src/section/eit.rs:87:8 [INFO] [stdout] | [INFO] [stdout] 69 | trait WithEITHeaderSpecific<'buf>: Bufer<'buf> { [INFO] [stdout] | --------------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 87 | fn segment_last_section_number(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 92 | fn last_table_id(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `WithCRC32` is never used [INFO] [stdout] --> src/section/traits.rs:156:18 [INFO] [stdout] | [INFO] [stdout] 156 | pub(crate) trait WithCRC32<'buf>: Bufer<'buf> {} [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:125:20 [INFO] [stdout] | [INFO] [stdout] 124 | fn from(err: IoError) -> Error { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Error::new(Kind::Io(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/demuxer.rs:89:36 [INFO] [stdout] | [INFO] [stdout] 89 | self.0.iter_mut().find(|s| s.borrow().number == number) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/demuxer.rs:96:38 [INFO] [stdout] | [INFO] [stdout] 96 | .sort_unstable_by(|a, b| a.borrow().number.cmp(&b.borrow().number)); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/demuxer.rs:96:61 [INFO] [stdout] | [INFO] [stdout] 96 | .sort_unstable_by(|a, b| a.borrow().number.cmp(&b.borrow().number)); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/demuxer.rs:275:18 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn new(events: T) -> Demuxer { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | pat: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/demuxer.rs:276:18 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn new(events: T) -> Demuxer { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | pmt: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/demuxer.rs:277:18 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn new(events: T) -> Demuxer { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | eit: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/demuxer.rs:278:18 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn new(events: T) -> Demuxer { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | sdt: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/demuxer.rs:279:18 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn new(events: T) -> Demuxer { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | nit: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/demuxer.rs:280:18 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn new(events: T) -> Demuxer { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | cat: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/demuxer.rs:281:18 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn new(events: T) -> Demuxer { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | bat: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/section/traits.rs:150:14 [INFO] [stdout] | [INFO] [stdout] 135 | let row = match T::try_new(self.buf) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | Ok(row) => row, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | Some(Ok(row)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `va-ts` (lib) due to 13 previous errors; 14 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "7c305ca9dd09645a1779aeb24806e8953b04ed3c05e274e60bc3c5ea058a7c0c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c305ca9dd09645a1779aeb24806e8953b04ed3c05e274e60bc3c5ea058a7c0c", kill_on_drop: false }` [INFO] [stdout] 7c305ca9dd09645a1779aeb24806e8953b04ed3c05e274e60bc3c5ea058a7c0c