[INFO] fetching crate uu_sort 0.0.27... [INFO] checking uu_sort-0.0.27 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate uu_sort 0.0.27 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate uu_sort 0.0.27 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate uu_sort 0.0.27 [INFO] finished tweaking crates.io crate uu_sort 0.0.27 [INFO] tweaked toml for crates.io crate uu_sort 0.0.27 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate uu_sort 0.0.27 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6d6007c04025ccbfb9ea0bc4ce95d923539aa0501f4a5db2939854aa4bec7785 [INFO] running `Command { std: "docker" "start" "-a" "6d6007c04025ccbfb9ea0bc4ce95d923539aa0501f4a5db2939854aa4bec7785", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6d6007c04025ccbfb9ea0bc4ce95d923539aa0501f4a5db2939854aa4bec7785", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d6007c04025ccbfb9ea0bc4ce95d923539aa0501f4a5db2939854aa4bec7785", kill_on_drop: false }` [INFO] [stdout] 6d6007c04025ccbfb9ea0bc4ce95d923539aa0501f4a5db2939854aa4bec7785 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ccbf03e8172119569e5d10960c6d8a740c5c3bf34c334504ed1d8f38a036905c [INFO] running `Command { std: "docker" "start" "-a" "ccbf03e8172119569e5d10960c6d8a740c5c3bf34c334504ed1d8f38a036905c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling rustix v0.37.26 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling unicode-ident v1.0.5 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking anstyle-parse v0.2.0 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Compiling uuhelp_parser v0.0.27 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking anstream v0.5.0 [INFO] [stderr] Checking os_display v0.1.3 [INFO] [stderr] Checking compare v0.1.0 [INFO] [stderr] Checking dunce v1.0.4 [INFO] [stderr] Checking wild v2.2.1 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking self_cell v1.0.4 [INFO] [stderr] Checking binary-heap-plus v0.5.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling uucore_procs v0.0.27 [INFO] [stderr] Checking crossbeam-epoch v0.9.17 [INFO] [stderr] Checking crossbeam-deque v0.8.4 [INFO] [stderr] Checking getrandom v0.2.9 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking terminal_size v0.2.6 [INFO] [stderr] Checking ctrlc v3.4.4 [INFO] [stderr] Checking clap_builder v4.4.2 [INFO] [stderr] Checking clap v4.4.2 [INFO] [stderr] Checking uucore v0.0.27 [INFO] [stderr] Checking uu_sort v0.0.27 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sort.rs:270:12 [INFO] [stdout] | [INFO] [stdout] 252 | let file = if let Some(name) = name { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | Ok(Self { file }) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sort.rs:274:24 [INFO] [stdout] | [INFO] [stdout] 273 | fn into_write(self) -> BufWriter> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | BufWriter::new(match self.file { [INFO] [stdout] | ________________________^ [INFO] [stdout] 275 | | Some((_name, file)) => { [INFO] [stdout] 276 | | // truncate the file [INFO] [stdout] 277 | | let _ = file.set_len(0); [INFO] [stdout] ... | [INFO] [stdout] 280 | | None => Box::new(stdout()), [INFO] [stdout] 281 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sort.rs:1842:11 [INFO] [stdout] | [INFO] [stdout] 1833 | fn open(path: impl AsRef) -> UResult> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1842 | match File::open(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:81:29 [INFO] [stdout] | [INFO] [stdout] 81 | .map(|file| open(file).map(|file| PlainMergeInput { inner: file })), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:89:29 [INFO] [stdout] | [INFO] [stdout] 89 | .map(|file| open(file).map(|file| PlainMergeInput { inner: file })), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:194:8 [INFO] [stdout] | [INFO] [stdout] 142 | files: F, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let (request_sender, request_receiver) = channel(); [INFO] [stdout] | -------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | let mut reader_files = Vec::with_capacity(files.size_hint().0); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | let mut loaded_receivers = Vec::with_capacity(files.size_hint().0); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | let reader_join_handle = thread::spawn({ [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let mut mergeable_files = vec![]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | Ok(FileMerger { [INFO] [stdout] | ________^ [INFO] [stdout] 195 | | heap: binary_heap_plus::BinaryHeap::from_vec_cmp( [INFO] [stdout] 196 | | mergeable_files, [INFO] [stdout] 197 | | FileComparator { settings }, [INFO] [stdout] ... | [INFO] [stdout] 201 | | reader_join_handle, [INFO] [stdout] 202 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:280:9 [INFO] [stdout] | [INFO] [stdout] 277 | pub fn write_all_to(mut self, settings: &GlobalSettings, out: &mut impl Write) -> UResult<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | self.reader_join_handle.join().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:418:12 [INFO] [stdout] | [INFO] [stdout] 417 | fn create((file, path): (File, PathBuf), _: Option<&str>) -> UResult { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 418 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 419 | | file: BufWriter::new(file), [INFO] [stdout] 420 | | path, [INFO] [stdout] 421 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:487:12 [INFO] [stdout] | [INFO] [stdout] 477 | fn create((file, path): (File, PathBuf), compress_prog: Option<&str>) -> UResult { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | let compress_prog = compress_prog.unwrap(); [INFO] [stdout] 479 | let mut command = Command::new(compress_prog); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 480 | command.stdin(Stdio::piped()).stdout(file); [INFO] [stdout] 481 | let mut child = command [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 486 | let child_stdin = child.stdin.take().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 487 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 488 | | path, [INFO] [stdout] 489 | | compress_prog: compress_prog.to_owned(), [INFO] [stdout] 490 | | child, [INFO] [stdout] 491 | | child_stdin: BufWriter::new(child_stdin), [INFO] [stdout] 492 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:521:12 [INFO] [stdout] | [INFO] [stdout] 512 | let mut command = Command::new(&self.compress_prog); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 513 | let file = File::open(&self.path).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 514 | command.stdin(file).stdout(Stdio::piped()).arg("-d"); [INFO] [stdout] 515 | let mut child = command [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 520 | let child_stdout = child.stdout.take().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 521 | Ok(CompressedTmpMergeInput { [INFO] [stdout] | ____________^ [INFO] [stdout] 522 | | path: self.path, [INFO] [stdout] 523 | | compress_prog: self.compress_prog, [INFO] [stdout] 524 | | child, [INFO] [stdout] 525 | | child_stdout, [INFO] [stdout] 526 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tmp_dir.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 53 | let lock = self.lock.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | / ctrlc::set_handler(move || { [INFO] [stdout] 55 | | // Take the lock so that `next_file_path` returns no new file path, [INFO] [stdout] 56 | | // and the program doesn't terminate before the handler has finished [INFO] [stdout] 57 | | let _lock = lock.lock().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 61 | | std::process::exit(2) [INFO] [stdout] 62 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tmp_dir.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 71 | let _lock = self.lock.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 76 | | File::create(&path).map_err(|error| SortError::OpenTmpFileFailed { error })?, [INFO] [stdout] 77 | | path, [INFO] [stdout] 78 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sort.rs:270:12 [INFO] [stdout] | [INFO] [stdout] 252 | let file = if let Some(name) = name { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | Ok(Self { file }) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sort.rs:274:24 [INFO] [stdout] | [INFO] [stdout] 273 | fn into_write(self) -> BufWriter> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | BufWriter::new(match self.file { [INFO] [stdout] | ________________________^ [INFO] [stdout] 275 | | Some((_name, file)) => { [INFO] [stdout] 276 | | // truncate the file [INFO] [stdout] 277 | | let _ = file.set_len(0); [INFO] [stdout] ... | [INFO] [stdout] 280 | | None => Box::new(stdout()), [INFO] [stdout] 281 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sort.rs:1842:11 [INFO] [stdout] | [INFO] [stdout] 1833 | fn open(path: impl AsRef) -> UResult> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1842 | match File::open(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:81:29 [INFO] [stdout] | [INFO] [stdout] 81 | .map(|file| open(file).map(|file| PlainMergeInput { inner: file })), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:89:29 [INFO] [stdout] | [INFO] [stdout] 89 | .map(|file| open(file).map(|file| PlainMergeInput { inner: file })), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:194:8 [INFO] [stdout] | [INFO] [stdout] 142 | files: F, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let (request_sender, request_receiver) = channel(); [INFO] [stdout] | -------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | let mut reader_files = Vec::with_capacity(files.size_hint().0); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | let mut loaded_receivers = Vec::with_capacity(files.size_hint().0); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | let reader_join_handle = thread::spawn({ [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let mut mergeable_files = vec![]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | Ok(FileMerger { [INFO] [stdout] | ________^ [INFO] [stdout] 195 | | heap: binary_heap_plus::BinaryHeap::from_vec_cmp( [INFO] [stdout] 196 | | mergeable_files, [INFO] [stdout] 197 | | FileComparator { settings }, [INFO] [stdout] ... | [INFO] [stdout] 201 | | reader_join_handle, [INFO] [stdout] 202 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:280:9 [INFO] [stdout] | [INFO] [stdout] 277 | pub fn write_all_to(mut self, settings: &GlobalSettings, out: &mut impl Write) -> UResult<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | self.reader_join_handle.join().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:418:12 [INFO] [stdout] | [INFO] [stdout] 417 | fn create((file, path): (File, PathBuf), _: Option<&str>) -> UResult { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 418 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 419 | | file: BufWriter::new(file), [INFO] [stdout] 420 | | path, [INFO] [stdout] 421 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:487:12 [INFO] [stdout] | [INFO] [stdout] 477 | fn create((file, path): (File, PathBuf), compress_prog: Option<&str>) -> UResult { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | let compress_prog = compress_prog.unwrap(); [INFO] [stdout] 479 | let mut command = Command::new(compress_prog); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 480 | command.stdin(Stdio::piped()).stdout(file); [INFO] [stdout] 481 | let mut child = command [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 486 | let child_stdin = child.stdin.take().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 487 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 488 | | path, [INFO] [stdout] 489 | | compress_prog: compress_prog.to_owned(), [INFO] [stdout] 490 | | child, [INFO] [stdout] 491 | | child_stdin: BufWriter::new(child_stdin), [INFO] [stdout] 492 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:521:12 [INFO] [stdout] | [INFO] [stdout] 512 | let mut command = Command::new(&self.compress_prog); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 513 | let file = File::open(&self.path).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 514 | command.stdin(file).stdout(Stdio::piped()).arg("-d"); [INFO] [stdout] 515 | let mut child = command [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 520 | let child_stdout = child.stdout.take().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 521 | Ok(CompressedTmpMergeInput { [INFO] [stdout] | ____________^ [INFO] [stdout] 522 | | path: self.path, [INFO] [stdout] 523 | | compress_prog: self.compress_prog, [INFO] [stdout] 524 | | child, [INFO] [stdout] 525 | | child_stdout, [INFO] [stdout] 526 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tmp_dir.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 53 | let lock = self.lock.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | / ctrlc::set_handler(move || { [INFO] [stdout] 55 | | // Take the lock so that `next_file_path` returns no new file path, [INFO] [stdout] 56 | | // and the program doesn't terminate before the handler has finished [INFO] [stdout] 57 | | let _lock = lock.lock().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 61 | | std::process::exit(2) [INFO] [stdout] 62 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tmp_dir.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 71 | let _lock = self.lock.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 76 | | File::create(&path).map_err(|error| SortError::OpenTmpFileFailed { error })?, [INFO] [stdout] 77 | | path, [INFO] [stdout] 78 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `uu_sort` (lib test) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `uu_sort` (lib) due to 13 previous errors [INFO] running `Command { std: "docker" "inspect" "ccbf03e8172119569e5d10960c6d8a740c5c3bf34c334504ed1d8f38a036905c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ccbf03e8172119569e5d10960c6d8a740c5c3bf34c334504ed1d8f38a036905c", kill_on_drop: false }` [INFO] [stdout] ccbf03e8172119569e5d10960c6d8a740c5c3bf34c334504ed1d8f38a036905c