[INFO] fetching crate utilz 0.5.0... [INFO] checking utilz-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate utilz 0.5.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate utilz 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate utilz 0.5.0 [INFO] finished tweaking crates.io crate utilz 0.5.0 [INFO] tweaked toml for crates.io crate utilz 0.5.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate utilz 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e5227bc2dd9f94969ea3575b8afa8d454df2d2d1d686a6bd5bf94053aad3063d [INFO] running `Command { std: "docker" "start" "-a" "e5227bc2dd9f94969ea3575b8afa8d454df2d2d1d686a6bd5bf94053aad3063d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e5227bc2dd9f94969ea3575b8afa8d454df2d2d1d686a6bd5bf94053aad3063d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5227bc2dd9f94969ea3575b8afa8d454df2d2d1d686a6bd5bf94053aad3063d", kill_on_drop: false }` [INFO] [stdout] e5227bc2dd9f94969ea3575b8afa8d454df2d2d1d686a6bd5bf94053aad3063d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4890981c427c7de0a694a09f32b6a4388af92ec18eabb6d39e6e65619aaed825 [INFO] running `Command { std: "docker" "start" "-a" "4890981c427c7de0a694a09f32b6a4388af92ec18eabb6d39e6e65619aaed825", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.157 [INFO] [stderr] Checking utilz v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockfile.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 37 | fn _lock>(path: P, what: libc::c_int) -> Result, Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | // Hold ACTIVELY_LOCKING during the entire lock protocol. [INFO] [stdout] 39 | let mut lock_table = ACTIVELY_LOCKING.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | // Open the lock. It doesn't matter if the lock file already exists. [INFO] [stdout] 41 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(Some(Lockfile { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | file: Some(file), [INFO] [stdout] 90 | | dev: metadata.dev(), [INFO] [stdout] 91 | | ino: metadata.ino(), [INFO] [stdout] 92 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `utilz` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lockfile.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 37 | fn _lock>(path: P, what: libc::c_int) -> Result, Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | // Hold ACTIVELY_LOCKING during the entire lock protocol. [INFO] [stdout] 39 | let mut lock_table = ACTIVELY_LOCKING.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | // Open the lock. It doesn't matter if the lock file already exists. [INFO] [stdout] 41 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(Some(Lockfile { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | file: Some(file), [INFO] [stdout] 90 | | dev: metadata.dev(), [INFO] [stdout] 91 | | ino: metadata.ino(), [INFO] [stdout] 92 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `utilz` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "4890981c427c7de0a694a09f32b6a4388af92ec18eabb6d39e6e65619aaed825", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4890981c427c7de0a694a09f32b6a4388af92ec18eabb6d39e6e65619aaed825", kill_on_drop: false }` [INFO] [stdout] 4890981c427c7de0a694a09f32b6a4388af92ec18eabb6d39e6e65619aaed825