[INFO] fetching crate usher 0.2.1... [INFO] checking usher-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate usher 0.2.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate usher 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate usher 0.2.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate usher 0.2.1 [INFO] tweaked toml for crates.io crate usher 0.2.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate usher 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b594f6838f9fcf7f9215c32884a593707589ecac508a478ae41ec1ea9857e601 [INFO] running `Command { std: "docker" "start" "-a" "b594f6838f9fcf7f9215c32884a593707589ecac508a478ae41ec1ea9857e601", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b594f6838f9fcf7f9215c32884a593707589ecac508a478ae41ec1ea9857e601", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b594f6838f9fcf7f9215c32884a593707589ecac508a478ae41ec1ea9857e601", kill_on_drop: false }` [INFO] [stdout] b594f6838f9fcf7f9215c32884a593707589ecac508a478ae41ec1ea9857e601 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ae2ecc8f6b7657a7b0691de8d94715ed7c61f4237f480bee3132f98fb75a149 [INFO] running `Command { std: "docker" "start" "-a" "1ae2ecc8f6b7657a7b0691de8d94715ed7c61f4237f480bee3132f98fb75a149", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking smallvec v1.8.1 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Checking tracing-core v0.1.28 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking hashbrown v0.12.1 [INFO] [stderr] Compiling httparse v1.7.1 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking tracing v0.1.35 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking usher v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `extensions::*` [INFO] [stdout] --> src/lib.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub use extensions::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 32 | pub(crate) fn new(matcher: Box) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | value: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:36:23 [INFO] [stdout] | [INFO] [stdout] 32 | pub(crate) fn new(matcher: Box) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:40:19 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new(mut parsers: Vec>) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let parsed = parse_segment(&parsers, "/"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let parsed = parsed.expect("unparsed segment"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | root: Node::new(parsed), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:52:27 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn insert(&mut self, path: &str, t: T) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | self.update(path, |_| t) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `usher` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "1ae2ecc8f6b7657a7b0691de8d94715ed7c61f4237f480bee3132f98fb75a149", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ae2ecc8f6b7657a7b0691de8d94715ed7c61f4237f480bee3132f98fb75a149", kill_on_drop: false }` [INFO] [stdout] 1ae2ecc8f6b7657a7b0691de8d94715ed7c61f4237f480bee3132f98fb75a149