[INFO] fetching crate usdpl-front 0.11.0... [INFO] checking usdpl-front-0.11.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate usdpl-front 0.11.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate usdpl-front 0.11.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate usdpl-front 0.11.0 [INFO] finished tweaking crates.io crate usdpl-front 0.11.0 [INFO] tweaked toml for crates.io crate usdpl-front 0.11.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 77 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding gloo-net v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding obfstr v0.3.0 (latest: v0.4.3) [INFO] [stderr] Adding prost v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding prost-derive v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5ade933fab40ceabe94491ffc6563a480c86a4d69ec33850048de5d38f7e2f80 [INFO] running `Command { std: "docker" "start" "-a" "5ade933fab40ceabe94491ffc6563a480c86a4d69ec33850048de5d38f7e2f80", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5ade933fab40ceabe94491ffc6563a480c86a4d69ec33850048de5d38f7e2f80", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ade933fab40ceabe94491ffc6563a480c86a4d69ec33850048de5d38f7e2f80", kill_on_drop: false }` [INFO] [stdout] 5ade933fab40ceabe94491ffc6563a480c86a4d69ec33850048de5d38f7e2f80 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2589622063c82fb133d4e8e0c227d8683e2c84232ecfd5e961089f9a6ef4dcef [INFO] running `Command { std: "docker" "start" "-a" "2589622063c82fb133d4e8e0c227d8683e2c84232ecfd5e961089f9a6ef4dcef", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking usdpl-core v0.11.0 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.93 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling wasm-bindgen-test-macro v0.3.43 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.93 [INFO] [stderr] Compiling prost-derive v0.11.9 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.93 [INFO] [stderr] Checking wasm-bindgen v0.2.93 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking prost v0.11.9 [INFO] [stderr] Checking nrpc v0.10.0 [INFO] [stderr] Checking js-sys v0.3.70 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Checking wasm-bindgen-futures v0.4.43 [INFO] [stderr] Checking web-sys v0.3.70 [INFO] [stderr] Checking wasm-bindgen-test v0.3.43 [INFO] [stderr] Checking gloo-utils v0.2.0 [INFO] [stderr] Checking gloo-net v0.4.0 [INFO] [stderr] Checking usdpl-front v0.11.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `encrypt` [INFO] [stdout] --> src/lib.rs:37:7 [INFO] [stdout] | [INFO] [stdout] 37 | #[cfg(feature = "encrypt")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `console_error_panic_hook`, `debug`, `decky`, `default`, `hex`, and `obfstr` [INFO] [stdout] = help: consider adding `encrypt` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `encrypt` [INFO] [stdout] --> src/lib.rs:37:7 [INFO] [stdout] | [INFO] [stdout] 37 | #[cfg(feature = "encrypt")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `console_error_panic_hook`, `debug`, `decky`, `default`, `hex`, and `obfstr` [INFO] [stdout] = help: consider adding `encrypt` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:52:53 [INFO] [stdout] | [INFO] [stdout] 52 | .map_err(|e| web_sys::console::error_1(&format!("Failed to setup USDPL logger: {}", e).into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client_handler.rs:154:70 [INFO] [stdout] | [INFO] [stdout] 153 | input: ServiceClientStream<'a, bytes::Bytes>, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | ) -> Result, ServiceError> { [INFO] [stdout] | ______________________________________________________________________^ [INFO] [stdout] 155 | | let id = LAST_ID.fetch_add(1, Ordering::SeqCst); [INFO] [stdout] 156 | | let url = format!( [INFO] [stdout] 157 | | "ws://usdpl-ws-{}.localhost:{}/{}.{}/{}", [INFO] [stdout] ... | [INFO] [stdout] 166 | | .map_err(|e| ServiceError::Method(Box::new(ErrorStr(e))))))) [INFO] [stdout] 167 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client_handler.rs:164:71 [INFO] [stdout] | [INFO] [stdout] 164 | Ok(Box::new(rx.map(|buf_result: Result| buf_result [INFO] [stdout] | _____________________________----------------------------------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | | .map(|buf| bytes::Bytes::from(buf)) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client_handler.rs:166:47 [INFO] [stdout] | [INFO] [stdout] 166 | .map_err(|e| ServiceError::Method(Box::new(ErrorStr(e))))))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wasm/js_function_stream.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn from_function(f: Function) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | promise: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wasm/js_function_stream.rs:60:86 [INFO] [stdout] | [INFO] [stdout] 60 | Some(T::from_wasm_streamable(t).map_err(|e| ServiceError::Method(s_to_err(format!("JS type conversion error: {}", e))))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:52:53 [INFO] [stdout] | [INFO] [stdout] 52 | .map_err(|e| web_sys::console::error_1(&format!("Failed to setup USDPL logger: {}", e).into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client_handler.rs:154:70 [INFO] [stdout] | [INFO] [stdout] 153 | input: ServiceClientStream<'a, bytes::Bytes>, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | ) -> Result, ServiceError> { [INFO] [stdout] | ______________________________________________________________________^ [INFO] [stdout] 155 | | let id = LAST_ID.fetch_add(1, Ordering::SeqCst); [INFO] [stdout] 156 | | let url = format!( [INFO] [stdout] 157 | | "ws://usdpl-ws-{}.localhost:{}/{}.{}/{}", [INFO] [stdout] ... | [INFO] [stdout] 166 | | .map_err(|e| ServiceError::Method(Box::new(ErrorStr(e))))))) [INFO] [stdout] 167 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client_handler.rs:164:71 [INFO] [stdout] | [INFO] [stdout] 164 | Ok(Box::new(rx.map(|buf_result: Result| buf_result [INFO] [stdout] | _____________________________----------------------------------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | | .map(|buf| bytes::Bytes::from(buf)) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client_handler.rs:166:47 [INFO] [stdout] | [INFO] [stdout] 166 | .map_err(|e| ServiceError::Method(Box::new(ErrorStr(e))))))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wasm/js_function_stream.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn from_function(f: Function) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | promise: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wasm/js_function_stream.rs:60:86 [INFO] [stdout] | [INFO] [stdout] 60 | Some(T::from_wasm_streamable(t).map_err(|e| ServiceError::Method(s_to_err(format!("JS type conversion error: {}", e))))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `usdpl-front` (lib test) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `usdpl-front` (lib) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "2589622063c82fb133d4e8e0c227d8683e2c84232ecfd5e961089f9a6ef4dcef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2589622063c82fb133d4e8e0c227d8683e2c84232ecfd5e961089f9a6ef4dcef", kill_on_drop: false }` [INFO] [stdout] 2589622063c82fb133d4e8e0c227d8683e2c84232ecfd5e961089f9a6ef4dcef