[INFO] fetching crate usbd-ethernet 0.1.2... [INFO] checking usbd-ethernet-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate usbd-ethernet 0.1.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate usbd-ethernet 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate usbd-ethernet 0.1.2 [INFO] finished tweaking crates.io crate usbd-ethernet 0.1.2 [INFO] tweaked toml for crates.io crate usbd-ethernet 0.1.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 31 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding hash32 v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding heapless v0.7.17 (latest: v0.8.0) [INFO] [stderr] Adding smoltcp v0.9.1 (latest: v0.11.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding usb-device v0.2.9 (latest: v0.3.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bbb4501a7dd2bd0868f66e827e414f9db024c57b5c14bc7798acbc9443eae3fd [INFO] running `Command { std: "docker" "start" "-a" "bbb4501a7dd2bd0868f66e827e414f9db024c57b5c14bc7798acbc9443eae3fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bbb4501a7dd2bd0868f66e827e414f9db024c57b5c14bc7798acbc9443eae3fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bbb4501a7dd2bd0868f66e827e414f9db024c57b5c14bc7798acbc9443eae3fd", kill_on_drop: false }` [INFO] [stdout] bbb4501a7dd2bd0868f66e827e414f9db024c57b5c14bc7798acbc9443eae3fd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c7cc6a355fb9db3ff5cbfe3d3d71d45aec519064801d3c8276b5885a77b47bc5 [INFO] running `Command { std: "docker" "start" "-a" "c7cc6a355fb9db3ff5cbfe3d3d71d45aec519064801d3c8276b5885a77b47bc5", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling defmt v0.3.8 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling defmt-macros v0.3.9 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling smoltcp v0.9.1 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking managed v0.8.0 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling defmt-parser v0.3.4 [INFO] [stderr] Checking usb-device v0.2.9 [INFO] [stderr] Checking usbd-ethernet v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `get_u8` is never used [INFO] [stdout] --> src/bytes.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub(crate) trait Buf { [INFO] [stdout] | --- method in this trait [INFO] [stdout] ... [INFO] [stdout] 36 | fn get_u8(&mut self) -> Option { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 45 | f: impl FnOnce(&mut [u8]) -> Result<(usize, R)>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let (written, r) = f(buf)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok((written, r)) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 69 | f: impl FnOnce(&mut [u8]) -> Result<(usize, R)>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let (read, r) = f(buf)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok((read, r)) [INFO] [stdout] | ^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ethernet.rs:271:41 [INFO] [stdout] | [INFO] [stdout] 231 | pub fn write_datagram(&mut self, len: u16, f: F) -> Result [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | .write(len.into(), |buf| Ok((len.into(), f(buf))))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ethernet.rs:361:47 [INFO] [stdout] | [INFO] [stdout] 350 | fn read_datagram(&mut self, f: F) -> Result [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | .read(datagram_len, |data| Ok((datagram_len, f(data))))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ethernet.rs:848:9 [INFO] [stdout] | [INFO] [stdout] 844 | fn consume(self, f: F) -> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 848 | self.ethernet.read_datagram(f).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ethernet.rs:866:9 [INFO] [stdout] | [INFO] [stdout] 862 | fn consume(self, len: usize, f: F) -> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 866 | / self.ethernet [INFO] [stdout] 867 | | .write_datagram(len.try_into().unwrap(), f) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `usbd-ethernet` (lib test) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `get_u8` is never used [INFO] [stdout] --> src/bytes.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 24 | pub(crate) trait Buf { [INFO] [stdout] | --- method in this trait [INFO] [stdout] ... [INFO] [stdout] 36 | fn get_u8(&mut self) -> Option { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 45 | f: impl FnOnce(&mut [u8]) -> Result<(usize, R)>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let (written, r) = f(buf)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok((written, r)) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 69 | f: impl FnOnce(&mut [u8]) -> Result<(usize, R)>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let (read, r) = f(buf)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok((read, r)) [INFO] [stdout] | ^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ethernet.rs:271:41 [INFO] [stdout] | [INFO] [stdout] 231 | pub fn write_datagram(&mut self, len: u16, f: F) -> Result [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | .write(len.into(), |buf| Ok((len.into(), f(buf))))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ethernet.rs:361:47 [INFO] [stdout] | [INFO] [stdout] 350 | fn read_datagram(&mut self, f: F) -> Result [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | .read(datagram_len, |data| Ok((datagram_len, f(data))))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ethernet.rs:848:9 [INFO] [stdout] | [INFO] [stdout] 844 | fn consume(self, f: F) -> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 848 | self.ethernet.read_datagram(f).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ethernet.rs:866:9 [INFO] [stdout] | [INFO] [stdout] 862 | fn consume(self, len: usize, f: F) -> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 866 | / self.ethernet [INFO] [stdout] 867 | | .write_datagram(len.try_into().unwrap(), f) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `usbd-ethernet` (lib) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "c7cc6a355fb9db3ff5cbfe3d3d71d45aec519064801d3c8276b5885a77b47bc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7cc6a355fb9db3ff5cbfe3d3d71d45aec519064801d3c8276b5885a77b47bc5", kill_on_drop: false }` [INFO] [stdout] c7cc6a355fb9db3ff5cbfe3d3d71d45aec519064801d3c8276b5885a77b47bc5