[INFO] fetching crate upnp-daemon 0.6.0... [INFO] checking upnp-daemon-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate upnp-daemon 0.6.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate upnp-daemon 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate upnp-daemon 0.6.0 [INFO] finished tweaking crates.io crate upnp-daemon 0.6.0 [INFO] tweaked toml for crates.io crate upnp-daemon 0.6.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate upnp-daemon 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 898a66408c07ad5005d15e96b0a5974f83fca8ed5355d4eeb2c51774de34e856 [INFO] running `Command { std: "docker" "start" "-a" "898a66408c07ad5005d15e96b0a5974f83fca8ed5355d4eeb2c51774de34e856", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "898a66408c07ad5005d15e96b0a5974f83fca8ed5355d4eeb2c51774de34e856", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "898a66408c07ad5005d15e96b0a5974f83fca8ed5355d4eeb2c51774de34e856", kill_on_drop: false }` [INFO] [stdout] 898a66408c07ad5005d15e96b0a5974f83fca8ed5355d4eeb2c51774de34e856 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 58cf651d94291b52941cf6c69b47bc1b48078ae7e8f237fc7a06244c4ca5beb1 [INFO] running `Command { std: "docker" "start" "-a" "58cf651d94291b52941cf6c69b47bc1b48078ae7e8f237fc7a06244c4ca5beb1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking wildmatch v1.1.0 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking xml-rs v0.8.20 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking c_linked_list v1.1.1 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking debug-helper v0.3.13 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking attohttpc v0.16.3 [INFO] [stderr] Checking xmltree v0.10.3 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking getrandom v0.2.13 [INFO] [stderr] Checking get_if_addrs v0.5.3 [INFO] [stderr] Checking daemonize v0.5.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking igd v0.12.1 [INFO] [stderr] Checking ctrlc v3.4.4 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking serde v1.0.197 [INFO] [stderr] Checking cidr-utils v0.5.11 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking easy-upnp v0.2.0 [INFO] [stderr] Checking upnp-daemon v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:401:8 [INFO] [stdout] | [INFO] [stdout] 398 | let mut builder = csv::ReaderBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | Ok(match input { [INFO] [stdout] | ________^ [INFO] [stdout] 402 | | Input::File(file) => { [INFO] [stdout] 403 | | // Clone file handle, so we don't move the original handle away. [INFO] [stdout] 404 | | let mut file = file.try_clone()?; [INFO] [stdout] ... | [INFO] [stdout] 410 | | Input::PathBuf(pathbuf) => reader_builder.from_path(pathbuf)?, [INFO] [stdout] 411 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:445:22 [INFO] [stdout] | [INFO] [stdout] 445 | .map(|v| serde_json::from_value::(v).map_err(anyhow::Error::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:452:5 [INFO] [stdout] | [INFO] [stdout] 451 | fn filter_out_and_log_errors(result: anyhow::Result) -> Option { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 452 | / result [INFO] [stdout] 453 | | .map_err(|err| { [INFO] [stdout] 454 | | error!("{}", err); [INFO] [stdout] 455 | | err [INFO] [stdout] 456 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `upnp-daemon` (bin "upnp-daemon") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:401:8 [INFO] [stdout] | [INFO] [stdout] 398 | let mut builder = csv::ReaderBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | Ok(match input { [INFO] [stdout] | ________^ [INFO] [stdout] 402 | | Input::File(file) => { [INFO] [stdout] 403 | | // Clone file handle, so we don't move the original handle away. [INFO] [stdout] 404 | | let mut file = file.try_clone()?; [INFO] [stdout] ... | [INFO] [stdout] 410 | | Input::PathBuf(pathbuf) => reader_builder.from_path(pathbuf)?, [INFO] [stdout] 411 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:445:22 [INFO] [stdout] | [INFO] [stdout] 445 | .map(|v| serde_json::from_value::(v).map_err(anyhow::Error::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:452:5 [INFO] [stdout] | [INFO] [stdout] 451 | fn filter_out_and_log_errors(result: anyhow::Result) -> Option { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 452 | / result [INFO] [stdout] 453 | | .map_err(|err| { [INFO] [stdout] 454 | | error!("{}", err); [INFO] [stdout] 455 | | err [INFO] [stdout] 456 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `upnp-daemon` (bin "upnp-daemon" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "58cf651d94291b52941cf6c69b47bc1b48078ae7e8f237fc7a06244c4ca5beb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58cf651d94291b52941cf6c69b47bc1b48078ae7e8f237fc7a06244c4ca5beb1", kill_on_drop: false }` [INFO] [stdout] 58cf651d94291b52941cf6c69b47bc1b48078ae7e8f237fc7a06244c4ca5beb1