[INFO] fetching crate update-ssh-keys 0.7.0... [INFO] checking update-ssh-keys-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate update-ssh-keys 0.7.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate update-ssh-keys 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate update-ssh-keys 0.7.0 [INFO] finished tweaking crates.io crate update-ssh-keys 0.7.0 [INFO] tweaked toml for crates.io crate update-ssh-keys 0.7.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate update-ssh-keys 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e988d98d8a7e1a0fbc07e6f8afd87fcfc79fb0ee5c1ca6e5c7373ff0b067b1a2 [INFO] running `Command { std: "docker" "start" "-a" "e988d98d8a7e1a0fbc07e6f8afd87fcfc79fb0ee5c1ca6e5c7373ff0b067b1a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e988d98d8a7e1a0fbc07e6f8afd87fcfc79fb0ee5c1ca6e5c7373ff0b067b1a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e988d98d8a7e1a0fbc07e6f8afd87fcfc79fb0ee5c1ca6e5c7373ff0b067b1a2", kill_on_drop: false }` [INFO] [stdout] e988d98d8a7e1a0fbc07e6f8afd87fcfc79fb0ee5c1ca6e5c7373ff0b067b1a2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ca38dc353a8107478017631d0f386699b5ee181cbb23a00cee467159381b42a [INFO] running `Command { std: "docker" "start" "-a" "1ca38dc353a8107478017631d0f386699b5ee181cbb23a00cee467159381b42a", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Compiling libc v0.2.79 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking cpuid-bool v0.1.2 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking users v0.11.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking md-5 v0.9.1 [INFO] [stderr] Checking sha2 v0.9.1 [INFO] [stderr] Checking openssh-keys v0.4.2 [INFO] [stderr] Checking update-ssh-keys v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `lock` is never read [INFO] [stdout] --> src/lib.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 145 | pub struct AuthorizedKeys { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 149 | lock: FileLock, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AuthorizedKeys` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:191:5 [INFO] [stdout] | [INFO] [stdout] 172 | fn truncate_dir>(dir: P) -> Result<()> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | fs::create_dir_all(dir).chain_err(|| format!("failed to create directory '{:?}'", dir)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:502:12 [INFO] [stdout] | [INFO] [stdout] 461 | pub fn open(user: User, create: bool, ssh_dir: Option) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 462 | // switch users [INFO] [stdout] 463 | let _guard = switch_user(&user)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 464 | // make a new file lock and lock it [INFO] [stdout] 465 | let lock = FileLock::try_new(&lock_file(&user))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 478 | let file = File::open(&filename).chain_err(|| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 502 | Ok(AuthorizedKeys { [INFO] [stdout] | ____________^ [INFO] [stdout] 503 | | ssh_dir, [INFO] [stdout] 504 | | user, [INFO] [stdout] 505 | | keys, [INFO] [stdout] 506 | | lock, [INFO] [stdout] 507 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `update-ssh-keys` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `lock` is never read [INFO] [stdout] --> src/lib.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 145 | pub struct AuthorizedKeys { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 149 | lock: FileLock, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AuthorizedKeys` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:191:5 [INFO] [stdout] | [INFO] [stdout] 172 | fn truncate_dir>(dir: P) -> Result<()> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | fs::create_dir_all(dir).chain_err(|| format!("failed to create directory '{:?}'", dir)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:502:12 [INFO] [stdout] | [INFO] [stdout] 461 | pub fn open(user: User, create: bool, ssh_dir: Option) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 462 | // switch users [INFO] [stdout] 463 | let _guard = switch_user(&user)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 464 | // make a new file lock and lock it [INFO] [stdout] 465 | let lock = FileLock::try_new(&lock_file(&user))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 478 | let file = File::open(&filename).chain_err(|| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 502 | Ok(AuthorizedKeys { [INFO] [stdout] | ____________^ [INFO] [stdout] 503 | | ssh_dir, [INFO] [stdout] 504 | | user, [INFO] [stdout] 505 | | keys, [INFO] [stdout] 506 | | lock, [INFO] [stdout] 507 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `update-ssh-keys` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "1ca38dc353a8107478017631d0f386699b5ee181cbb23a00cee467159381b42a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ca38dc353a8107478017631d0f386699b5ee181cbb23a00cee467159381b42a", kill_on_drop: false }` [INFO] [stdout] 1ca38dc353a8107478017631d0f386699b5ee181cbb23a00cee467159381b42a