[INFO] fetching crate unsegen_terminal 0.3.1... [INFO] checking unsegen_terminal-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate unsegen_terminal 0.3.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate unsegen_terminal 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate unsegen_terminal 0.3.1 [INFO] finished tweaking crates.io crate unsegen_terminal 0.3.1 [INFO] tweaked toml for crates.io crate unsegen_terminal 0.3.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 37 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding derive_more v0.14.1 (latest: v1.0.0) [INFO] [stderr] Adding itertools v0.5.10 (latest: v0.13.0) [INFO] [stderr] Adding matrixmultiply v0.1.15 (latest: v0.3.9) [INFO] [stderr] Adding ndarray v0.8.4 (latest: v0.16.1) [INFO] [stderr] Adding nix v0.17.0 (latest: v0.29.0) [INFO] [stderr] Adding num-complex v0.1.43 (latest: v0.4.6) [INFO] [stderr] Adding num-traits v0.1.43 (latest: v0.2.19) [INFO] [stderr] Adding numtoa v0.1.0 (latest: v0.2.4) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding rawpointer v0.1.0 (latest: v0.2.1) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding smallvec v0.3.4 (latest: v1.13.2) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding termion v1.5.6 (latest: v4.0.2) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] [stderr] Adding utf8parse v0.1.1 (latest: v0.2.2) [INFO] [stderr] Adding vte v0.3.3 (latest: v0.13.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6ac526d01e06a7812255d7628099eba28906490b58f604d4de2a423dfbfdfa44 [INFO] running `Command { std: "docker" "start" "-a" "6ac526d01e06a7812255d7628099eba28906490b58f604d4de2a423dfbfdfa44", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6ac526d01e06a7812255d7628099eba28906490b58f604d4de2a423dfbfdfa44", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ac526d01e06a7812255d7628099eba28906490b58f604d4de2a423dfbfdfa44", kill_on_drop: false }` [INFO] [stdout] 6ac526d01e06a7812255d7628099eba28906490b58f604d4de2a423dfbfdfa44 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9c453beacb022b9b292bdcdd960106421f6e55f80dc99acd5ac8469ff40d5e78 [INFO] running `Command { std: "docker" "start" "-a" "9c453beacb022b9b292bdcdd960106421f6e55f80dc99acd5ac8469ff40d5e78", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling matrixmultiply v0.1.15 [INFO] [stderr] Compiling ndarray v0.8.4 [INFO] [stderr] Checking rawpointer v0.1.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling nix v0.17.0 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking smallvec v0.3.4 [INFO] [stderr] Checking itertools v0.5.10 [INFO] [stderr] Checking utf8parse v0.1.1 [INFO] [stderr] Checking vte v0.3.3 [INFO] [stderr] Checking termion v1.5.6 [INFO] [stderr] Compiling derive_more v0.14.1 [INFO] [stderr] Checking raw_tty v0.1.0 [INFO] [stderr] Checking unsegen v0.3.0 [INFO] [stderr] Checking unsegen_terminal v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `dev` [INFO] [stdout] --> src/pty/mod.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | #![cfg_attr(feature = "dev", allow(unstable_features))] [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `dev` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `dev` [INFO] [stdout] --> src/pty/mod.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | #![cfg_attr(feature = "dev", feature(plugin))] [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `dev` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `dev` [INFO] [stdout] --> src/pty/mod.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | #![cfg_attr(feature = "dev", plugin(clippy))] [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `dev` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `dev` [INFO] [stdout] --> src/pty/mod.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | #![cfg_attr(feature = "dev", allow(unstable_features))] [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `dev` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `dev` [INFO] [stdout] --> src/pty/mod.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | #![cfg_attr(feature = "dev", feature(plugin))] [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `dev` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `dev` [INFO] [stdout] --> src/pty/mod.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | #![cfg_attr(feature = "dev", plugin(clippy))] [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `dev` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn new(input_sink: S) -> std::io::Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | let process_pty = PTY::open().expect("Could not create pty."); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let (pty_input, pty_output) = process_pty.split_io(); [INFO] [stdout] | --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let mut pts = std::fs::OpenOptions::new() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | Ok(Terminal { [INFO] [stdout] | ____________^ [INFO] [stdout] 166 | | terminal_window: RefCell::new(DualWindow::new()), [INFO] [stdout] 167 | | master_input_sink: RefCell::new(pty_input), [INFO] [stdout] 168 | | //slave_input_thread: slave_input_thread, [INFO] [stdout] ... | [INFO] [stdout] 171 | | ansi_processor: Processor::new(), [INFO] [stdout] 172 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pty/mod.rs:96:10 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn split_io(self) -> (PTYInput, PTYOutput) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let read = Arc::new(Mutex::new(self)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let write = read.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | (PTYInput { pty: read }, PTYOutput { pty: write }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pty/mod.rs:96:34 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn split_io(self) -> (PTYInput, PTYOutput) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let read = Arc::new(Mutex::new(self)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let write = read.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | (PTYInput { pty: read }, PTYOutput { pty: write }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unsegen_terminal` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn new(input_sink: S) -> std::io::Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | let process_pty = PTY::open().expect("Could not create pty."); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let (pty_input, pty_output) = process_pty.split_io(); [INFO] [stdout] | --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let mut pts = std::fs::OpenOptions::new() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | Ok(Terminal { [INFO] [stdout] | ____________^ [INFO] [stdout] 166 | | terminal_window: RefCell::new(DualWindow::new()), [INFO] [stdout] 167 | | master_input_sink: RefCell::new(pty_input), [INFO] [stdout] 168 | | //slave_input_thread: slave_input_thread, [INFO] [stdout] ... | [INFO] [stdout] 171 | | ansi_processor: Processor::new(), [INFO] [stdout] 172 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pty/mod.rs:96:10 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn split_io(self) -> (PTYInput, PTYOutput) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let read = Arc::new(Mutex::new(self)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let write = read.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | (PTYInput { pty: read }, PTYOutput { pty: write }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pty/mod.rs:96:34 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn split_io(self) -> (PTYInput, PTYOutput) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let read = Arc::new(Mutex::new(self)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let write = read.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | (PTYInput { pty: read }, PTYOutput { pty: write }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unsegen_terminal` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9c453beacb022b9b292bdcdd960106421f6e55f80dc99acd5ac8469ff40d5e78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c453beacb022b9b292bdcdd960106421f6e55f80dc99acd5ac8469ff40d5e78", kill_on_drop: false }` [INFO] [stdout] 9c453beacb022b9b292bdcdd960106421f6e55f80dc99acd5ac8469ff40d5e78