[INFO] fetching crate unpack 0.2.4... [INFO] checking unpack-0.2.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate unpack 0.2.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate unpack 0.2.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate unpack 0.2.4 [INFO] finished tweaking crates.io crate unpack 0.2.4 [INFO] tweaked toml for crates.io crate unpack 0.2.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate unpack 0.2.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `goblin` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bdbf20b044c93c517c69daed9f8071cd01c82af47503ec0c0b2044b7360bd185 [INFO] running `Command { std: "docker" "start" "-a" "bdbf20b044c93c517c69daed9f8071cd01c82af47503ec0c0b2044b7360bd185", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bdbf20b044c93c517c69daed9f8071cd01c82af47503ec0c0b2044b7360bd185", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bdbf20b044c93c517c69daed9f8071cd01c82af47503ec0c0b2044b7360bd185", kill_on_drop: false }` [INFO] [stdout] bdbf20b044c93c517c69daed9f8071cd01c82af47503ec0c0b2044b7360bd185 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 034c4976d5915b4910918acd592a1729c326fa2fbf2d09b059f30dfcf8724af0 [INFO] running `Command { std: "docker" "start" "-a" "034c4976d5915b4910918acd592a1729c326fa2fbf2d09b059f30dfcf8724af0", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `goblin` dependency) [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling syn v1.0.57 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling miniz_oxide v0.4.3 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.21 [INFO] [stderr] Checking adler v0.2.3 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking gimli v0.23.0 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking smallvec v1.6.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking object v0.22.0 [INFO] [stderr] Checking rustc-demangle v0.1.18 [INFO] [stderr] Checking fixedbitset v0.2.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking libflate_lz77 v1.0.0 [INFO] [stderr] Checking petgraph v0.5.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking rle-decode-fast v1.0.1 [INFO] [stderr] Checking number_prefix v0.3.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking libflate v1.0.3 [INFO] [stderr] Checking strum v0.20.0 [INFO] [stderr] Checking ar v0.8.0 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Compiling bzip2-sys v0.1.9+1.0.8 [INFO] [stderr] Compiling lzma-sys v0.1.17 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking terminal_size v0.1.15 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking flate2 v1.0.14 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking filetime v0.2.13 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking xattr v0.2.2 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking xz2 v0.1.6 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking tar v0.4.30 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking addr2line v0.14.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking bzip2 v0.4.1 [INFO] [stderr] Checking tree_magic v0.2.3 [INFO] [stderr] Checking regex v1.4.2 [INFO] [stderr] Checking backtrace v0.3.55 [INFO] [stderr] Checking uuid v0.8.1 [INFO] [stderr] Compiling synstructure v0.12.4 [INFO] [stderr] Checking cab v0.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.23 [INFO] [stderr] Compiling scroll_derive v0.10.4 [INFO] [stderr] Compiling strum_macros v0.20.1 [INFO] [stderr] Checking console v0.14.0 [INFO] [stderr] Checking indicatif v0.15.0 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking scroll v0.10.2 [INFO] [stderr] Checking thiserror v1.0.23 [INFO] [stderr] Checking zip v0.5.9 [INFO] [stderr] Checking goblin v0.3.0 [INFO] [stderr] Checking unpack v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `dst` is never read [INFO] [stdout] --> src/utils.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 61 | pub struct TempDirectory { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 62 | tmp: PathBuf, [INFO] [stdout] 63 | dst: PathBuf, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TempDirectory` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 66 | let pb = match archive.total_size() { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | Some(total_size) => { [INFO] [stdout] 68 | let pb = ProgressBar::new(total_size); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let pb = ProgressBar::new_spinner(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(UnpackHelper { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | archive_base, [INFO] [stdout] 88 | | dst, [INFO] [stdout] 89 | | tmp, [INFO] [stdout] 90 | | pb, [INFO] [stdout] 91 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn write_file>(&mut self, filename: P) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | Ok(fs::File::create(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `dst` is never read [INFO] [stdout] --> src/utils.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 61 | pub struct TempDirectory { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 62 | tmp: PathBuf, [INFO] [stdout] 63 | dst: PathBuf, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TempDirectory` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 66 | let pb = match archive.total_size() { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | Some(total_size) => { [INFO] [stdout] 68 | let pb = ProgressBar::new(total_size); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let pb = ProgressBar::new_spinner(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(UnpackHelper { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | archive_base, [INFO] [stdout] 88 | | dst, [INFO] [stdout] 89 | | tmp, [INFO] [stdout] 90 | | pb, [INFO] [stdout] 91 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn write_file>(&mut self, filename: P) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | Ok(fs::File::create(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/cab.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 76 | fn from_cab_and_path(cab: Cabinet>, path: PathBuf) -> Result { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | Ok(CabArchive { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | path, [INFO] [stdout] 87 | | cab, [INFO] [stdout] 88 | | total_size, [INFO] [stdout] 89 | | files, [INFO] [stdout] 90 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/zip.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let path = path.as_ref().canonicalize()?; [INFO] [stdout] 20 | let mut rdr = ZipArchiveReader::new(BufReader::new(File::open(&path)?))?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok(ZipArchive { [INFO] [stdout] | ____________^ [INFO] [stdout] 25 | | path, [INFO] [stdout] 26 | | rdr, [INFO] [stdout] 27 | | total_size, [INFO] [stdout] 28 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/zip.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 22 | .map(|x| rdr.by_index(x).ok().map_or(0, |x| x.size())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/cab.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 76 | fn from_cab_and_path(cab: Cabinet>, path: PathBuf) -> Result { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | Ok(CabArchive { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | path, [INFO] [stdout] 87 | | cab, [INFO] [stdout] 88 | | total_size, [INFO] [stdout] 89 | | files, [INFO] [stdout] 90 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/zip.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let path = path.as_ref().canonicalize()?; [INFO] [stdout] 20 | let mut rdr = ZipArchiveReader::new(BufReader::new(File::open(&path)?))?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok(ZipArchive { [INFO] [stdout] | ____________^ [INFO] [stdout] 25 | | path, [INFO] [stdout] 26 | | rdr, [INFO] [stdout] 27 | | total_size, [INFO] [stdout] 28 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/zip.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 22 | .map(|x| rdr.by_index(x).ok().map_or(0, |x| x.size())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unpack` (bin "unpack" test) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `unpack` (bin "unpack") due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "034c4976d5915b4910918acd592a1729c326fa2fbf2d09b059f30dfcf8724af0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "034c4976d5915b4910918acd592a1729c326fa2fbf2d09b059f30dfcf8724af0", kill_on_drop: false }` [INFO] [stdout] 034c4976d5915b4910918acd592a1729c326fa2fbf2d09b059f30dfcf8724af0