[INFO] fetching crate unobtanium 1.0.0... [INFO] checking unobtanium-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate unobtanium 1.0.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate unobtanium 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate unobtanium 1.0.0 [INFO] finished tweaking crates.io crate unobtanium 1.0.0 [INFO] tweaked toml for crates.io crate unobtanium 1.0.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 65 packages to latest compatible versions [INFO] [stderr] Adding criterium v1.0.0 (latest: v2.0.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding libsqlite3-sys v0.28.0 (latest: v0.30.1) [INFO] [stderr] Adding rusqlite v0.31.0 (latest: v0.32.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5f5fdfc93d7399ab3a2375e92504aef0ada2633c30249287ee441016647be595 [INFO] running `Command { std: "docker" "start" "-a" "5f5fdfc93d7399ab3a2375e92504aef0ada2633c30249287ee441016647be595", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5f5fdfc93d7399ab3a2375e92504aef0ada2633c30249287ee441016647be595", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f5fdfc93d7399ab3a2375e92504aef0ada2633c30249287ee441016647be595", kill_on_drop: false }` [INFO] [stdout] 5f5fdfc93d7399ab3a2375e92504aef0ada2633c30249287ee441016647be595 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 322e1a0763fbaad1b9ed88d80439c3326d3bebb5c4b1d3a7db668c02df02399b [INFO] running `Command { std: "docker" "start" "-a" "322e1a0763fbaad1b9ed88d80439c3326d3bebb5c4b1d3a7db668c02df02399b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking mediatype v0.19.18 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking criterium v1.0.0 [INFO] [stderr] Checking unobtanium v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/base.rs:366:7 [INFO] [stdout] | [INFO] [stdout] 366 | Ok(MediaTypeBuf::from_string( [INFO] [stdout] | ________________^ [INFO] [stdout] 367 | | row.get(0)? [INFO] [stdout] 368 | | ).map_err(|_| Error::QueryReturnedNoRows)?) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/summary.rs:441:8 [INFO] [stdout] | [INFO] [stdout] 441 | Ok(WithEntityGenerationId { [INFO] [stdout] | ____________________^ [INFO] [stdout] 442 | | entity_generation_id: id, [INFO] [stdout] 443 | | data: file_summary_row_to_summary(&self, row, id, fetch_text_pile)?, [INFO] [stdout] 444 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/summary.rs:960:5 [INFO] [stdout] | [INFO] [stdout] 945 | let mut mimetype: Option = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 960 | Ok(FileSummary{ [INFO] [stdout] | ________^ [INFO] [stdout] 961 | | mime_type: mimetype, [INFO] [stdout] 962 | | size: row.get(0)?, [INFO] [stdout] 963 | | text: text, [INFO] [stdout] 964 | | link_stats: None, [INFO] [stdout] 965 | | description: description, [INFO] [stdout] 966 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/result.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 16 | fn to_unobtanium_res(self) -> UnobtaniumResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | self.ok_or(UnobtaniumError::NotFound) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unobtanium` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/base.rs:366:7 [INFO] [stdout] | [INFO] [stdout] 366 | Ok(MediaTypeBuf::from_string( [INFO] [stdout] | ________________^ [INFO] [stdout] 367 | | row.get(0)? [INFO] [stdout] 368 | | ).map_err(|_| Error::QueryReturnedNoRows)?) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/summary.rs:441:8 [INFO] [stdout] | [INFO] [stdout] 441 | Ok(WithEntityGenerationId { [INFO] [stdout] | ____________________^ [INFO] [stdout] 442 | | entity_generation_id: id, [INFO] [stdout] 443 | | data: file_summary_row_to_summary(&self, row, id, fetch_text_pile)?, [INFO] [stdout] 444 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/summary.rs:960:5 [INFO] [stdout] | [INFO] [stdout] 945 | let mut mimetype: Option = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 960 | Ok(FileSummary{ [INFO] [stdout] | ________^ [INFO] [stdout] 961 | | mime_type: mimetype, [INFO] [stdout] 962 | | size: row.get(0)?, [INFO] [stdout] 963 | | text: text, [INFO] [stdout] 964 | | link_stats: None, [INFO] [stdout] 965 | | description: description, [INFO] [stdout] 966 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/result.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 16 | fn to_unobtanium_res(self) -> UnobtaniumResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | self.ok_or(UnobtaniumError::NotFound) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unobtanium` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "322e1a0763fbaad1b9ed88d80439c3326d3bebb5c4b1d3a7db668c02df02399b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "322e1a0763fbaad1b9ed88d80439c3326d3bebb5c4b1d3a7db668c02df02399b", kill_on_drop: false }` [INFO] [stdout] 322e1a0763fbaad1b9ed88d80439c3326d3bebb5c4b1d3a7db668c02df02399b