[INFO] fetching crate unit-testing 3.1.0... [INFO] checking unit-testing-3.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate unit-testing 3.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate unit-testing 3.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate unit-testing 3.1.0 [INFO] finished tweaking crates.io crate unit-testing 3.1.0 [INFO] tweaked toml for crates.io crate unit-testing 3.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 27 packages to latest compatible versions [INFO] [stderr] Adding approx v0.1.1 (latest: v0.5.1) [INFO] [stderr] Adding cgmath v0.16.1 (latest: v0.18.0) [INFO] [stderr] Adding num-traits v0.1.43 (latest: v0.2.19) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding winconsole v0.10.0 (latest: v0.11.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] adca66b4b8f95f8c63dc9ca83f2ca85e4f981d85fef64842e892aa8ed9b36d45 [INFO] running `Command { std: "docker" "start" "-a" "adca66b4b8f95f8c63dc9ca83f2ca85e4f981d85fef64842e892aa8ed9b36d45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "adca66b4b8f95f8c63dc9ca83f2ca85e4f981d85fef64842e892aa8ed9b36d45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "adca66b4b8f95f8c63dc9ca83f2ca85e4f981d85fef64842e892aa8ed9b36d45", kill_on_drop: false }` [INFO] [stdout] adca66b4b8f95f8c63dc9ca83f2ca85e4f981d85fef64842e892aa8ed9b36d45 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 965640bae385d591827977219352342b493dd72a731503745fd789b2428a6ec6 [INFO] running `Command { std: "docker" "start" "-a" "965640bae385d591827977219352342b493dd72a731503745fd789b2428a6ec6", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling cgmath v0.16.1 [INFO] [stderr] Compiling winapi v0.3.9 [INFO] [stderr] Checking approx v0.1.1 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking progress_bar v1.0.5 [INFO] [stderr] Checking is_executable v1.0.1 [INFO] [stderr] Checking rgb v0.8.50 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking winconsole v0.10.0 [INFO] [stderr] Checking colored_truecolor v0.1.0 [INFO] [stderr] Checking unit-testing v3.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assertions/mod.rs:70:32 [INFO] [stdout] | [INFO] [stdout] 69 | fn theorem(&mut self, expected: T, actual: &dyn Fn() -> T) -> &mut Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | self.take(expected.eq(&actual()), THEORY_IS_TRUE, THEORY_IS_FALSE) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assertions/mod.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 72 | fn theory(&mut self, expected: T, callback: &dyn Fn() -> T) -> &mut Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | self.take( [INFO] [stdout] 74 | expected == callback(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assertions/mod.rs:238:19 [INFO] [stdout] | [INFO] [stdout] 237 | fn option_contains(&mut self, a: Option, b: T) -> &mut Self { [INFO] [stdout] | ------------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | self.take(a.expect("") == b, ASSERT_CONTAINS, ASSERT_SHOULD_CONTAINS) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/suite/mod.rs:239:18 [INFO] [stdout] | [INFO] [stdout] 235 | x: X, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | .run(c(x).eq(expected), IS_EQUALS, IS_UNEQUALS) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unit/mod.rs:58:19 [INFO] [stdout] | [INFO] [stdout] 57 | fn theory(&mut self, expected: T, callback: &dyn Fn() -> T) -> &mut Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | self.take(callback() == expected, THEORY_IS_TRUE, THEORY_IS_FALSE) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unit/mod.rs:62:32 [INFO] [stdout] | [INFO] [stdout] 61 | fn theorem(&mut self, expected: T, actual: &dyn Fn() -> T) -> &mut Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | self.take(expected.eq(&actual()), THEORY_IS_TRUE, THEORY_IS_FALSE) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unit/mod.rs:238:19 [INFO] [stdout] | [INFO] [stdout] 237 | fn option_contains(&mut self, a: Option, b: T) -> &mut Self { [INFO] [stdout] | ------------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | self.take(a.expect("failed") == b, IS_CONTAINS, IS_NOT_CONTAINS) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assertions/mod.rs:70:32 [INFO] [stdout] | [INFO] [stdout] 69 | fn theorem(&mut self, expected: T, actual: &dyn Fn() -> T) -> &mut Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | self.take(expected.eq(&actual()), THEORY_IS_TRUE, THEORY_IS_FALSE) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assertions/mod.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 72 | fn theory(&mut self, expected: T, callback: &dyn Fn() -> T) -> &mut Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | self.take( [INFO] [stdout] 74 | expected == callback(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assertions/mod.rs:238:19 [INFO] [stdout] | [INFO] [stdout] 237 | fn option_contains(&mut self, a: Option, b: T) -> &mut Self { [INFO] [stdout] | ------------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | self.take(a.expect("") == b, ASSERT_CONTAINS, ASSERT_SHOULD_CONTAINS) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/suite/mod.rs:239:18 [INFO] [stdout] | [INFO] [stdout] 235 | x: X, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | .run(c(x).eq(expected), IS_EQUALS, IS_UNEQUALS) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unit/mod.rs:58:19 [INFO] [stdout] | [INFO] [stdout] 57 | fn theory(&mut self, expected: T, callback: &dyn Fn() -> T) -> &mut Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | self.take(callback() == expected, THEORY_IS_TRUE, THEORY_IS_FALSE) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unit/mod.rs:62:32 [INFO] [stdout] | [INFO] [stdout] 61 | fn theorem(&mut self, expected: T, actual: &dyn Fn() -> T) -> &mut Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | self.take(expected.eq(&actual()), THEORY_IS_TRUE, THEORY_IS_FALSE) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unit/mod.rs:238:19 [INFO] [stdout] | [INFO] [stdout] 237 | fn option_contains(&mut self, a: Option, b: T) -> &mut Self { [INFO] [stdout] | ------------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | self.take(a.expect("failed") == b, IS_CONTAINS, IS_NOT_CONTAINS) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unit-testing` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `unit-testing` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "965640bae385d591827977219352342b493dd72a731503745fd789b2428a6ec6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "965640bae385d591827977219352342b493dd72a731503745fd789b2428a6ec6", kill_on_drop: false }` [INFO] [stdout] 965640bae385d591827977219352342b493dd72a731503745fd789b2428a6ec6