[INFO] fetching crate union_impl 0.1.3... [INFO] checking union_impl-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate union_impl 0.1.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate union_impl 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate union_impl 0.1.3 [INFO] finished tweaking crates.io crate union_impl 0.1.3 [INFO] tweaked toml for crates.io crate union_impl 0.1.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 452a9e1eaf5845d34713db645897e0fc28689b90bd4792bd56feb5aef9b783b0 [INFO] running `Command { std: "docker" "start" "-a" "452a9e1eaf5845d34713db645897e0fc28689b90bd4792bd56feb5aef9b783b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "452a9e1eaf5845d34713db645897e0fc28689b90bd4792bd56feb5aef9b783b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "452a9e1eaf5845d34713db645897e0fc28689b90bd4792bd56feb5aef9b783b0", kill_on_drop: false }` [INFO] [stdout] 452a9e1eaf5845d34713db645897e0fc28689b90bd4792bd56feb5aef9b783b0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9673847dbdbd5101ee9e7a3612a4562b27737a6222451bb736212df3c80d905d [INFO] running `Command { std: "docker" "start" "-a" "9673847dbdbd5101ee9e7a3612a4562b27737a6222451bb736212df3c80d905d", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Checking union_impl v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_chain/expr/default_expr.rs:60:14 [INFO] [stdout] | [INFO] [stdout] 59 | fn replace_expr(&self, expr: Expr) -> Option { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Some(match self { [INFO] [stdout] | ______________^ [INFO] [stdout] 61 | | Self::Or(_) => Self::Or(expr), [INFO] [stdout] 62 | | Self::OrElse(_) => Self::OrElse(expr), [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_chain/expr_chain_with_default.rs:167:30 [INFO] [stdout] | [INFO] [stdout] 167 | |v| Some(v.extract_expr().clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_chain/group/group_determiner.rs:125:18 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn check_parsed(&self, input: TokenStream) -> bool { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | .map(|checker| checker(input)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_chain/group/group_determiner.rs:133:45 [INFO] [stdout] | [INFO] [stdout] 133 | (0..self.length()).try_for_each(|_| input.parse::().map(|_| ()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_chain/utils.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn is_valid_expr(input: TokenStream) -> bool { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | syn::parse2::(input).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_chain/utils.rs:61:8 [INFO] [stdout] | [INFO] [stdout] 34 | let mut tokens = TokenStream::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(Unit { [INFO] [stdout] | ________^ [INFO] [stdout] 62 | | expr: parse2(tokens)?, [INFO] [stdout] 63 | | next_group_type: next_group.and_then(GroupDeterminer::get_group_type), [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr_chain/utils.rs:43:50 [INFO] [stdout] | [INFO] [stdout] 43 | .map(|group| !group.check_parsed(tokens.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/union/mod.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 106 | step_number: impl Into, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | chain_index: impl Into, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | (quote! {}, inner_expr.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/union/mod.rs:289:29 [INFO] [stdout] | [INFO] [stdout] 282 | .fold(None, |acc, ProcessWithDefault(expr, default_expr)| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | let or_clause = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | / acc.map( [INFO] [stdout] 290 | | |(previous_def_expr, previous_result)| [INFO] [stdout] 291 | | match &expr { [INFO] [stdout] 292 | | Some(ProcessActionExpr::Instant(process_expr)) => { [INFO] [stdout] ... | [INFO] [stdout] 303 | | } [INFO] [stdout] 304 | | ) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/union/mod.rs:307:37 [INFO] [stdout] | [INFO] [stdout] 307 | / ... match expr { [INFO] [stdout] 308 | | ... Some(ProcessActionExpr::Deferred(process_expr)) => { [INFO] [stdout] 309 | | ... let previous_result_name = get_chain_result_name(chain_index); [INFO] [stdout] 310 | | ... let previous_result = previous_result_handler(quote! { #previous_result_name }); [INFO] [stdout] ... | [INFO] [stdout] 325 | | ... } [INFO] [stdout] 326 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/union/mod.rs:333:33 [INFO] [stdout] | [INFO] [stdout] 330 | .map(|(def_expr, chain)| [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | / if spawn { [INFO] [stdout] 334 | | if is_async { [INFO] [stdout] 335 | | let spawn_tokio_function_name = construct_spawn_tokio_function_name(); [INFO] [stdout] 336 | | quote! { [INFO] [stdout] ... | [INFO] [stdout] 346 | | quote! { #chain } [INFO] [stdout] 347 | | } [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/union/mod.rs:350:45 [INFO] [stdout] | [INFO] [stdout] 350 | .unwrap_or_else(|| (empty_stream.clone(), empty_stream.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/union/mod.rs:350:67 [INFO] [stdout] | [INFO] [stdout] 350 | .unwrap_or_else(|| (empty_stream.clone(), empty_stream.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/union/mod.rs:437:13 [INFO] [stdout] | [INFO] [stdout] 433 | (0..branch_count).fold(None, |acc, index| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 434 | let index = branch_count - index - 1; [INFO] [stdout] 435 | let value_var_name = construct_var_name(index); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 436 | let result_var_name = construct_result_name(index); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 437 | acc.and_then(|acc| Some(quote! { #result_var_name.and_then(|#value_var_name| #acc ) })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `union_impl` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9673847dbdbd5101ee9e7a3612a4562b27737a6222451bb736212df3c80d905d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9673847dbdbd5101ee9e7a3612a4562b27737a6222451bb736212df3c80d905d", kill_on_drop: false }` [INFO] [stdout] 9673847dbdbd5101ee9e7a3612a4562b27737a6222451bb736212df3c80d905d